From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org,
Stafford Horne <shorne@gmail.com>
Subject: Re: [PATCH v3 4/5] selftests: ftrace: Output only to console with "--logdir -"
Date: Fri, 7 Jul 2017 09:42:55 +0900 [thread overview]
Message-ID: <20170707094255.5d14981b1a48218bebbe55a8@kernel.org> (raw)
In-Reply-To: <20170706095026.5442dbc4@gandalf.local.home>
On Thu, 6 Jul 2017 09:50:26 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Thu, 6 Jul 2017 18:10:58 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > @@ -255,12 +262,18 @@ __run_test() { # testfile
> > # Run one test case
> > run_test() { # testfile
> > local testname=`basename $1`
> > - local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> > + if [ ! -z "$LOG_FILE" ] ; then
> > + local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> > + else
> > + local testlog=`/proc/self/fd/1`
>
> As Stafford mentioned. I don't think you want backticks here.
Oops, right!
--
Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2017-07-07 0:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 9:06 [PATCH v3 0/5] selftests: ftrace: ftracetest improvements Masami Hiramatsu
2017-07-06 9:07 ` [PATCH v3 1/5] selftests: ftrace: Do not failure if there is unsupported tests Masami Hiramatsu
2017-07-06 9:08 ` [PATCH v3 2/5] selftests: ftrace: Add --fail-unsupported option Masami Hiramatsu
2017-07-06 9:09 ` [PATCH v3 3/5] selftests: ftrace: Add more verbosity for immediate log Masami Hiramatsu
2017-07-06 9:10 ` [PATCH v3 4/5] selftests: ftrace: Output only to console with "--logdir -" Masami Hiramatsu
2017-07-06 13:50 ` Steven Rostedt
2017-07-07 0:42 ` Masami Hiramatsu [this message]
2017-07-06 9:12 ` [PATCH v3 5/5] selftests: ftrace: Check given string is not zero-length Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170707094255.5d14981b1a48218bebbe55a8@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=naresh.kamboju@linaro.org \
--cc=rostedt@goodmis.org \
--cc=shorne@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox