From: Masami Hiramatsu <mhiramat@kernel.org>
To: linux-kselftest@vger.kernel.org, shuah@kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Cc: mhiramat@kernel.org, Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org, naresh.kamboju@linaro.org
Subject: [PATCH v3 5/5] selftests: ftrace: Check given string is not zero-length
Date: Thu, 6 Jul 2017 18:12:02 +0900 [thread overview]
Message-ID: <149933231171.8910.8211757029671617912.stgit@devbox> (raw)
In-Reply-To: <149933198569.8910.14570277134817357038.stgit@devbox>
Use [ ! -z "$VAR" ] instead of [ "$VAR" ] to check
whether the given string variable is not zero-length
since it obviously shows what it means.
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
tools/testing/selftests/ftrace/ftracetest | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/ftrace/ftracetest b/tools/testing/selftests/ftrace/ftracetest
index 453f73d..aab3d5e 100755
--- a/tools/testing/selftests/ftrace/ftracetest
+++ b/tools/testing/selftests/ftrace/ftracetest
@@ -8,7 +8,7 @@
# Released under the terms of the GPL v2.
usage() { # errno [message]
-[ "$2" ] && echo $2
+[ ! -z "$2" ] && echo $2
echo "Usage: ftracetest [options] [testcase(s)] [testcase-directory(s)]"
echo " Options:"
echo " -h|--help Show help message"
@@ -50,7 +50,7 @@ parse_opts() { # opts
local OPT_TEST_CASES=
local OPT_TEST_DIR=
- while [ "$1" ]; do
+ while [ ! -z "$1" ]; do
case "$1" in
--help|-h)
usage 0
@@ -96,7 +96,7 @@ parse_opts() { # opts
;;
esac
done
- if [ "$OPT_TEST_CASES" ]; then
+ if [ ! -z "$OPT_TEST_CASES" ]; then
TEST_CASES=$OPT_TEST_CASES
fi
}
prev parent reply other threads:[~2017-07-06 9:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 9:06 [PATCH v3 0/5] selftests: ftrace: ftracetest improvements Masami Hiramatsu
2017-07-06 9:07 ` [PATCH v3 1/5] selftests: ftrace: Do not failure if there is unsupported tests Masami Hiramatsu
2017-07-06 9:08 ` [PATCH v3 2/5] selftests: ftrace: Add --fail-unsupported option Masami Hiramatsu
2017-07-06 9:09 ` [PATCH v3 3/5] selftests: ftrace: Add more verbosity for immediate log Masami Hiramatsu
2017-07-06 9:10 ` [PATCH v3 4/5] selftests: ftrace: Output only to console with "--logdir -" Masami Hiramatsu
2017-07-06 13:50 ` Steven Rostedt
2017-07-07 0:42 ` Masami Hiramatsu
2017-07-06 9:12 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=149933231171.8910.8211757029671617912.stgit@devbox \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=naresh.kamboju@linaro.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox