public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <willy@w.ods.org>
To: Nick Warne <nick@linicks.net>
Cc: linux-kernel@vger.kernel.org, marcelo.tosatti@cyclades.com
Subject: Re: [PATCH 2.4.31] Reintroduction i386 CONFIG_DUMMY_KEYB option
Date: Fri, 14 Oct 2005 06:32:34 +0200	[thread overview]
Message-ID: <20051014043234.GJ22601@alpha.home.local> (raw)
In-Reply-To: <200510131838.45082.nick@linicks.net>

Hi Nick,

On Thu, Oct 13, 2005 at 06:38:44PM +0100, Nick Warne wrote:
(...)
> diff -Naur linux-2.4.31.orig/arch/i386/kernel/dmi_scan.c 
> linux-2.4.31n/arch/i386/kernel/dmi_scan.c
> --- linux-2.4.31.orig/arch/i386/kernel/dmi_scan.c	Wed Nov 17 11:54:21 2004
> +++ linux-2.4.31n/arch/i386/kernel/dmi_scan.c	Wed Oct 12 15:57:27 2005
> @@ -412,11 +412,13 @@
>  static __init int broken_ps2_resume(struct dmi_blacklist *d)
>  {
>  #ifdef CONFIG_VT
> +#ifndef CONFIG_DUMMY_KEYB

Please could you change this to #if defined(CONFIG_VT) && !defined(CONFIG_DUMMY_KEYB) ?

Marcelo, I'd like this one to be merged, as it is useful to many of us, and
is already fixed in 2.6 (where you're not forced to have a keyboard). It's
not intrusive and at most a build fix. Would you please accept Nick's patch
after the little clean-up above ?

Thanks in advance,
Willy


  parent reply	other threads:[~2005-10-14  4:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-13 17:38 [PATCH 2.4.31] Reintroduction i386 CONFIG_DUMMY_KEYB option Nick Warne
2005-10-13 16:31 ` Jeff V. Merkey
2005-10-14  4:32 ` Willy Tarreau [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-10-14  9:19 Nick Warne
2005-10-18  8:02 ` Marcelo Tosatti
2005-10-18 18:30   ` Nick Warne
2005-10-18 22:41   ` Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051014043234.GJ22601@alpha.home.local \
    --to=willy@w.ods.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=nick@linicks.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox