From: Nick Warne <nick@linicks.net>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linux-kernel@vger.kernel.org, Willy Tarreau <willy@w.ods.org>
Subject: Re: [PATCH 2.4.31] Reintroduction i386 CONFIG_DUMMY_KEYB option
Date: Tue, 18 Oct 2005 19:30:44 +0100 [thread overview]
Message-ID: <200510181930.44170.nick@linicks.net> (raw)
In-Reply-To: <20051018080226.GB13299@logos.cnet>
On Tuesday 18 October 2005 09:02, Marcelo Tosatti wrote:
> > OK, the adjusted patch attached. I did look at the ifdefs in that file
> > for a few minutes; but I see now I should have done it like this in the
> > first place.
>
> Looks fine - Willy can you keep it in your tree and add it later on to the
> 2.4.33-pre tree?
Hi Marcelo,
I just noticed something - I maybe buggered up:
+
+if [ "$CONFIG_INPUT_KEYBDEV" == "n" ]; then
I think I done wrong there - should that be:
[ "$CONFIG_INPUT_KEYBDEV" = "n" ]
menuconfig all works correctly, though?
If so I will rectify the patch again.
Nick
--
http://sourceforge.net/projects/quake2plus
"Person who say it cannot be done should not interrupt person doing it."
-Chinese Proverb
next prev parent reply other threads:[~2005-10-18 18:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-14 9:19 [PATCH 2.4.31] Reintroduction i386 CONFIG_DUMMY_KEYB option Nick Warne
2005-10-18 8:02 ` Marcelo Tosatti
2005-10-18 18:30 ` Nick Warne [this message]
2005-10-18 22:41 ` Willy Tarreau
-- strict thread matches above, loose matches on Subject: below --
2005-10-13 17:38 Nick Warne
2005-10-13 16:31 ` Jeff V. Merkey
2005-10-14 4:32 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510181930.44170.nick@linicks.net \
--to=nick@linicks.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=willy@w.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox