From: Willy Tarreau <willy@w.ods.org>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: Nick Warne <nick@linicks.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.4.31] Reintroduction i386 CONFIG_DUMMY_KEYB option
Date: Wed, 19 Oct 2005 00:41:18 +0200 [thread overview]
Message-ID: <20051018224118.GA12326@alpha.home.local> (raw)
In-Reply-To: <20051018080226.GB13299@logos.cnet>
On Tue, Oct 18, 2005 at 06:02:26AM -0200, Marcelo Tosatti wrote:
> On Fri, Oct 14, 2005 at 10:19:44AM +0100, Nick Warne wrote:
> >
> > >> #ifdef CONFIG_VT
> > >> +#ifndef CONFIG_DUMMY_KEYB
> >
> > > Please could you change this to #if defined(CONFIG_VT) &&
> > > !defined(CONFIG_DUMMY_KEYB) ?
> >
> > > Marcelo, I'd like this one to be merged, as it is useful to many of us,
> > > and is already fixed in 2.6 (where you're not forced to have a
> > > keyboard). It's not intrusive and at most a build fix. Would you please
> > > accept Nick's patch after the little clean-up above ?
> >
> >
> > OK, the adjusted patch attached. I did look at the ifdefs in that file
> > for a few minutes; but I see now I should have done it like this in the
> > first place.
>
> Looks fine - Willy can you keep it in your tree and add it later on to the
> 2.4.33-pre tree?
OK, fine.
Willy
next prev parent reply other threads:[~2005-10-18 22:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-14 9:19 [PATCH 2.4.31] Reintroduction i386 CONFIG_DUMMY_KEYB option Nick Warne
2005-10-18 8:02 ` Marcelo Tosatti
2005-10-18 18:30 ` Nick Warne
2005-10-18 22:41 ` Willy Tarreau [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-10-13 17:38 Nick Warne
2005-10-13 16:31 ` Jeff V. Merkey
2005-10-14 4:32 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051018224118.GA12326@alpha.home.local \
--to=willy@w.ods.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=nick@linicks.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox