From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Nick Warne <nick@linicks.net>
Cc: linux-kernel@vger.kernel.org, Willy Tarreau <willy@w.ods.org>
Subject: Re: [PATCH 2.4.31] Reintroduction i386 CONFIG_DUMMY_KEYB option
Date: Tue, 18 Oct 2005 06:02:26 -0200 [thread overview]
Message-ID: <20051018080226.GB13299@logos.cnet> (raw)
In-Reply-To: <Pine.LNX.4.44.0510141006280.3868-200000@website2.europe.pwc.ca>
On Fri, Oct 14, 2005 at 10:19:44AM +0100, Nick Warne wrote:
>
> >> #ifdef CONFIG_VT
> >> +#ifndef CONFIG_DUMMY_KEYB
>
> > Please could you change this to #if defined(CONFIG_VT) &&
> > !defined(CONFIG_DUMMY_KEYB) ?
>
> > Marcelo, I'd like this one to be merged, as it is useful to many of us,
> > and is already fixed in 2.6 (where you're not forced to have a
> > keyboard). It's not intrusive and at most a build fix. Would you please
> > accept Nick's patch after the little clean-up above ?
>
>
> OK, the adjusted patch attached. I did look at the ifdefs in that file
> for a few minutes; but I see now I should have done it like this in the
> first place.
Looks fine - Willy can you keep it in your tree and add it later on to the
2.4.33-pre tree?
next prev parent reply other threads:[~2005-10-18 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-14 9:19 [PATCH 2.4.31] Reintroduction i386 CONFIG_DUMMY_KEYB option Nick Warne
2005-10-18 8:02 ` Marcelo Tosatti [this message]
2005-10-18 18:30 ` Nick Warne
2005-10-18 22:41 ` Willy Tarreau
-- strict thread matches above, loose matches on Subject: below --
2005-10-13 17:38 Nick Warne
2005-10-13 16:31 ` Jeff V. Merkey
2005-10-14 4:32 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051018080226.GB13299@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@linicks.net \
--cc=willy@w.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox