From: Andrew Morton <akpm@osdl.org>
To: Jim Cromie <jim.cromie@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch -mm 05/20] chardev: GPIO for SCx200 & PC-8736x: put gpio_dump on a diet
Date: Mon, 19 Jun 2006 22:22:04 -0700 [thread overview]
Message-ID: <20060619222204.362b30ca.akpm@osdl.org> (raw)
In-Reply-To: <44944976.80400@gmail.com>
On Sat, 17 Jun 2006 12:27:02 -0600
Jim Cromie <jim.cromie@gmail.com> wrote:
> + u32 config = scx200_gpio_configure(index, ~0, 0);
> +
> + printk(KERN_INFO NAME ": GPIO-%02u: 0x%08lx %s %s %s %s %s %s %s\n",
> + index, (unsigned long) config,
> + (config & 1) ? "OE" : "TS", /* output enabled / tristate */
> + (config & 2) ? "PP" : "OD", /* push pull / open drain */
> + (config & 4) ? "PUE" : "PUD", /* pull up enabled/disabled */
> + (config & 8) ? "LOCKED" : "", /* locked / unlocked */
> + (config & 16) ? "LEVEL" : "EDGE", /* level/edge input */
> + (config & 32) ? "HI" : "LO", /* trigger on rising/falling edge */
> + (config & 64) ? "DEBOUNCE" : ""); /* debounce */
> }
Please use hard tabs.
Casting `config' to ulong isn't needed here.
next prev parent reply other threads:[~2006-06-20 5:24 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <448DB57F.2050006@gmail.com>
[not found] ` <cfe85dfa0606121150y369f6beeqc643a1fe5c7ce69b@mail.gmail.com>
2006-06-17 18:23 ` [patch -mm 01/20] chardev: GPIO for SCx200 & PC-8736x: whitespace pre-clean Jim Cromie
2006-06-17 18:24 ` [patch -mm 02/20] chardev: GPIO for SCx200 & PC-8736x: modernize driver init to 2.6 api Jim Cromie
2006-06-20 5:21 ` Andrew Morton
2006-06-17 18:25 ` [patch -mm 03/20] chardev: GPIO for SCx200 & PC-8736x: add platforn_device for use w dev_dbg Jim Cromie
2006-06-20 5:22 ` Andrew Morton
2006-06-17 18:26 ` [patch -mm 04/20] chardev: GPIO for SCx200 & PC-8736x: device minor numbers are unsigned ints Jim Cromie
2006-06-17 18:27 ` [patch -mm 05/20] chardev: GPIO for SCx200 & PC-8736x: put gpio_dump on a diet Jim Cromie
2006-06-20 5:22 ` Andrew Morton [this message]
2006-06-17 18:28 ` [patch -mm 06/20] chardev: GPIO for SCx200 & PC-8736x: add 'v' command to device-file Jim Cromie
2006-06-17 18:29 ` [patch -mm 07/20] chardev: GPIO for SCx200 & PC-8736x: refactor scx200_probe to better segregate _gpio initialization Jim Cromie
2006-06-17 18:30 ` [patch -mm 09/20] chardev: GPIO for SCx200 & PC-8736x: dispatch via vtable Jim Cromie
2006-06-17 18:31 ` [patch -mm 10/20] chardev: GPIO for SCx200 & PC-8736x: add empty common-module Jim Cromie
2006-06-17 18:32 ` [patch -mm 11/20] chardev: GPIO for SCx200 & PC-8736x: migrate file-ops to common module Jim Cromie
2006-06-20 5:22 ` Andrew Morton
2006-06-17 18:33 ` [patch -mm 12/20] chardev: GPIO for SCx200 & PC-8736x: migrate gpio_dump " Jim Cromie
2006-06-17 18:33 ` [patch -mm 08/20] chardev: GPIO for SCx200 & PC-8736x: add gpio-ops vtable Jim Cromie
2006-06-17 18:34 ` [patch -mm 13/20] chardev: GPIO for SCx200 & PC-8736x: add new pc8736x_gpio module Jim Cromie
2006-06-20 5:22 ` Andrew Morton
2006-06-17 18:35 ` [patch -mm 14/20] chardev: GPIO for SCx200 & PC-8736x: add platform_device for use w dev_dbg Jim Cromie
2006-06-20 5:22 ` Andrew Morton
2006-06-17 18:36 ` [patch -mm 15/20] chardev: GPIO for SCx200 & PC-8736x: use dev_dbg in common module Jim Cromie
2006-06-20 5:22 ` Andrew Morton
2006-06-17 18:37 ` [patch -mm 16/20] chardev: GPIO for SCx200 & PC-8736x: fix gpio_current, use shadow regs Jim Cromie
2006-06-20 5:22 ` Andrew Morton
2006-06-17 18:38 ` [patch -mm 17/20] chardev: GPIO for SCx200 & PC-8736x: replace spinlocks w mutexes Jim Cromie
2006-06-20 5:22 ` Andrew Morton
2006-06-17 18:39 ` [patch -mm 18/20] chardev: GPIO for SCx200 & PC-8736x: display pin values in/out in gpio_dump Jim Cromie
2006-06-17 18:40 ` [patch -mm 19/20] chardev: GPIO for SCx200 & PC-8736x: add proper Kconfig, Makefile entries Jim Cromie
2006-06-17 18:42 ` [patch -mm 20/20 RFC] chardev: GPIO for SCx200 & PC-8736x: add sysfs-GPIO interface Jim Cromie
2006-06-20 5:22 ` Andrew Morton
2006-06-20 19:57 ` Jim Cromie
2006-06-20 20:14 ` Randy.Dunlap
2006-06-20 20:40 ` Jim Cromie
2006-06-20 20:52 ` Randy.Dunlap
2006-06-20 21:50 ` Jim Cromie
2006-06-20 22:52 ` Randy.Dunlap
2006-06-21 0:12 ` Andrew Morton
2006-06-21 3:49 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060619222204.362b30ca.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox