From: Christoph Hellwig <hch@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
akpm@linux-foundation.org, viro@ZenIV.linux.org.uk
Subject: Re: CONFIG_OPTIMIZE_INLINING
Date: Sun, 27 Apr 2008 02:26:00 -0400 [thread overview]
Message-ID: <20080427062600.GA4392@infradead.org> (raw)
In-Reply-To: <20080427055943.GA16290@elte.hu>
On Sun, Apr 27, 2008 at 07:59:43AM +0200, Ingo Molnar wrote:
> here, two months ago:
>
> http://lkml.org/lkml/2008/3/3/122
>
> i made it x86-only due to this FUD that went against it:
>
> "messing with a global #define in a way that the results on 24
> architectures with 7 different releases of gcc would be
> unpredictable."
>
> ... as i saw no reason why this feature, which i found rather useful,
> should be delayed another year or so. I'd be more than happy to promote
> this feature back to lib/Kconfig.debug, sparc64 interest would make that
> a strong argument.
>
> and here is the pull request that i posted to lkml, with the full patch
> included as well:
>
> http://www.gossamer-threads.com/lists/linux/kernel/911104?page=last
This still does not explain why it's two commits. It also doesn't
explain the horrible cpp and ifdef abuse in there - having a config
symbol in one architecture only and then a cpp symbol to prevent the ill
effects of it in one signle architecture is simply utterly braindead,
sorry.
This kind of thing should be discussed at least on linux-arch and input
from at least partially wise people would have led too a much better
solution. Like, umm moving the option to a global config file and let
the architecture default it to y/n where needed.
next prev parent reply other threads:[~2008-04-27 6:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-27 4:55 CONFIG_OPTIMIZE_INLINING David Miller
2008-04-27 5:59 ` CONFIG_OPTIMIZE_INLINING Ingo Molnar
2008-04-27 6:08 ` CONFIG_OPTIMIZE_INLINING David Miller
2008-04-27 8:20 ` CONFIG_OPTIMIZE_INLINING Ingo Molnar
2008-04-27 9:10 ` CONFIG_OPTIMIZE_INLINING SL Baur
2008-04-27 9:16 ` CONFIG_OPTIMIZE_INLINING Dave Airlie
2008-04-27 9:21 ` CONFIG_OPTIMIZE_INLINING David Miller
2008-04-27 12:13 ` CONFIG_OPTIMIZE_INLINING Ingo Molnar
2008-04-27 11:22 ` CONFIG_OPTIMIZE_INLINING Ingo Molnar
2008-04-27 17:25 ` CONFIG_OPTIMIZE_INLINING Pavel Machek
2008-04-28 10:42 ` CONFIG_OPTIMIZE_INLINING Adrian Bunk
2008-04-27 6:26 ` Christoph Hellwig [this message]
2008-04-27 10:56 ` CONFIG_OPTIMIZE_INLINING Sam Ravnborg
2008-04-27 6:02 ` CONFIG_OPTIMIZE_INLINING Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080427062600.GA4392@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox