public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: David Miller <davem@davemloft.net>
Cc: airlied@gmail.com, steve@xemacs.org,
	linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	akpm@linux-foundation.org, viro@zeniv.linux.org.uk
Subject: Re: CONFIG_OPTIMIZE_INLINING
Date: Sun, 27 Apr 2008 14:13:57 +0200	[thread overview]
Message-ID: <20080427121357.GA9305@elte.hu> (raw)
In-Reply-To: <20080427.022130.193697611.davem@davemloft.net>


* David Miller <davem@davemloft.net> wrote:

> From: "Dave Airlie" <airlied@gmail.com>
> Date: Sun, 27 Apr 2008 19:16:31 +1000
> 
> > just because something lands in the core kernel tree doesn't mean it 
> > is actually perfect, far from it..
> 
> This is entirely missing the point.
> 
> We get patches reviewed before they hit the tree, not afterwards.
> 
> Ingo is making that impossible.

hrmpf. David, i can only repeat that what you say is plain out false. 
The CONFIG_OPTIMIZE_INLINING patch was posted to lkml originally, about 
two months ago:

  http://lkml.org/lkml/2008/3/3/122
 
then it was re-posted at the time of the pull request as well:

  http://www.gossamer-threads.com/lists/linux/kernel/911104?page=last

and i just posted a (trivial) RFC patch to lkml today that would turn it 
into a generic feature:

  http://lkml.org/lkml/2008/4/27/47

so i'm not sure what this big fuss is about ...

Moving this (now apparently hotly desired!) feature from 
arch/x86/Kconfig to init/Kconfig is no big deal and lets continue with 
more important issues. No puppies got hurt, really :)

You can use the patch i posted or you've got my conceptual Acked-by for 
touching arch/x86/Kconfig or can do it without asking - i dont mind -, 
it's an obviously correct change that i not only wanted all along but 
also implemented that way originally (twice!), until stupid lkml 
objections forced it into arch/x86 as i went the path of least 
resistance.

Yes, in hindsight, i should have stood up for that change and should 
have made a stink about it on linux-arch but there's just so many 
flamewars that fit into a day ;-)

	Ingo

  reply	other threads:[~2008-04-27 12:14 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-27  4:55 CONFIG_OPTIMIZE_INLINING David Miller
2008-04-27  5:59 ` CONFIG_OPTIMIZE_INLINING Ingo Molnar
2008-04-27  6:08   ` CONFIG_OPTIMIZE_INLINING David Miller
2008-04-27  8:20     ` CONFIG_OPTIMIZE_INLINING Ingo Molnar
2008-04-27  9:10     ` CONFIG_OPTIMIZE_INLINING SL Baur
2008-04-27  9:16       ` CONFIG_OPTIMIZE_INLINING Dave Airlie
2008-04-27  9:21         ` CONFIG_OPTIMIZE_INLINING David Miller
2008-04-27 12:13           ` Ingo Molnar [this message]
2008-04-27 11:22     ` CONFIG_OPTIMIZE_INLINING Ingo Molnar
2008-04-27 17:25     ` CONFIG_OPTIMIZE_INLINING Pavel Machek
2008-04-28 10:42       ` CONFIG_OPTIMIZE_INLINING Adrian Bunk
2008-04-27  6:26   ` CONFIG_OPTIMIZE_INLINING Christoph Hellwig
2008-04-27 10:56     ` CONFIG_OPTIMIZE_INLINING Sam Ravnborg
2008-04-27  6:02 ` CONFIG_OPTIMIZE_INLINING Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080427121357.GA9305@elte.hu \
    --to=mingo@elte.hu \
    --cc=airlied@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steve@xemacs.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox