public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: stern@rowland.harvard.edu, gregkh@suse.de,
	Andrew Morton <akpm@osdl.org>,
	kernel list <linux-kernel@vger.kernel.org>
Cc: Oliver Neukum <oliver@neukum.org>
Subject: 2.6.25-rc6: CONFIG_USB_PERSIST forced on
Date: Fri, 6 Jun 2008 11:25:46 +0200	[thread overview]
Message-ID: <20080606092546.GA2596@elf.ucw.cz> (raw)

Hi!

In 2.6.26-rc5, 

-config USB_PERSIST
-       bool "USB device persistence during system suspend (DANGEROUS)"

is now on. Given that it was previously marked "DANGEROUS", that seems
quite a change to me.

-
-               WARNING: This option can be dangerous!
-
-         If a USB device is replaced by another of the same type while
-         the system is asleep, there's a good chance the kernel won't
-         detect the change.  Likewise if the media in a USB storage
-         device is replaced.  When this happens it's almost certain to
-         cause data corruption and maybe even crash your system.
-
-         If you are unsure, say N here.

Besides, it seems to have broken usblp hibernation support, and maybe
other devices that does not have reset_resume() present. (Big thanks
for Oliver for doing investigation).

[Or is it that now USB_PERSIST is conditional on /sys fs setting, so
while setting it on individual device is dangerous, it is still N by
default? Changelog does not tell me...?]

Commit is:

USB: remove CONFIG_USB_PERSIST setting

This patch (as1047) removes the USB_PERSIST Kconfig option, enabling
it permanently.  It also prevents the power/persist attribute from
being created for hub devices; there's no point in having it since
USB-PERSIST is always turned on for hubs.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

								Pavel
---
commit feccc30d90155bcbc937f87643182a43d25873eb
tree 96394e24075a885f1a8bb3e53203f8397e78ea46
parent 5e6effaed6da94e727cd45f945ad2489af8570b3
author Alan Stern <stern@rowland.harvard.edu> Mon, 03 Mar 2008 15:15:59 -0500
committer Greg Kroah-Hartman <gregkh@suse.de> Thu, 24 Apr 2008 21:16:32 -0700



-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

             reply	other threads:[~2008-06-06  9:25 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-06  9:25 Pavel Machek [this message]
2008-06-06 14:39 ` 2.6.25-rc6: CONFIG_USB_PERSIST forced on Alan Stern
2008-06-07 19:52   ` Pavel Machek
2008-06-07 22:26     ` Linus Torvalds
2008-06-09  8:00       ` Pavel Machek
2008-06-09 15:03         ` Alan Stern
2008-06-09 15:12           ` Oliver Neukum
2008-06-09 15:44             ` Alan Stern
2008-06-09 19:50               ` Greg KH
2008-06-09 20:59                 ` Pavel Machek
2008-06-09 21:39                   ` Linus Torvalds
2008-06-09 21:52                     ` Oliver Neukum
2008-06-09 21:56                     ` Pavel Machek
2008-06-09 22:19                       ` Linus Torvalds
2008-06-10  8:55                       ` Oliver Neukum
2008-06-10 14:59                         ` Alan Stern
2008-06-10 15:50                         ` Linus Torvalds
2008-06-10 16:36                           ` Linus Torvalds
2008-06-10 18:59                             ` [PATCH] USB: don't use reset-resume if drivers don't support it Alan Stern
2008-06-10 19:10                               ` Linus Torvalds
2008-06-10 21:30                               ` Greg KH
2008-06-10 21:42                               ` patch usb-don-t-use-reset-resume-if-drivers-don-t-support-it.patch added to gregkh-2.6 tree gregkh
2008-06-09 19:56               ` 2.6.25-rc6: CONFIG_USB_PERSIST forced on Oliver Neukum
2008-06-09 15:35         ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080606092546.GA2596@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=akpm@osdl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oliver@neukum.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox