From: Pavel Machek <pavel@suse.cz>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Greg KH <gregkh@suse.de>, Alan Stern <stern@rowland.harvard.edu>,
Oliver Neukum <oliver@neukum.org>,
Linus Torvalds <torvalds@linuxfoundation.org>,
Andrew Morton <akpm@linuxfoundation.org>,
kernel list <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: 2.6.25-rc6: CONFIG_USB_PERSIST forced on
Date: Mon, 9 Jun 2008 23:56:51 +0200 [thread overview]
Message-ID: <20080609215651.GF21429@elf.ucw.cz> (raw)
In-Reply-To: <alpine.LFD.1.10.0806091435120.3218@woody.linux-foundation.org>
On Mon 2008-06-09 14:39:10, Linus Torvalds wrote:
>
>
> On Mon, 9 Jun 2008, Pavel Machek wrote:
> >
> > I believe we should just revert the "CONFIG_USB_PERSIST force on"
> > patch, and solve this properly in 2.6.27.
>
> Why?
>
> The code would _still_ be buggy with that revert in place. You have to
> enable CONFIG_USB_PERSIST just to get even the _possibility_ of the sane
> behavior.
>
> If there is a problem with usblp, it just needs to be fixed.
With USB_PERSIST on, you have problem on all drivers but usb-storage,
AFAICT... because usb-storage seems to be the only driver implementing
reset_resume.
I guess it is possible to do something like "if reset_resume() is
unavailable, try plain resume()" in usb/driver.c, but I'd really
changes to the suspend/resume callback to go in -rc1 so that they are
tested properly, and not hot-patch it now.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-06-09 21:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 9:25 2.6.25-rc6: CONFIG_USB_PERSIST forced on Pavel Machek
2008-06-06 14:39 ` Alan Stern
2008-06-07 19:52 ` Pavel Machek
2008-06-07 22:26 ` Linus Torvalds
2008-06-09 8:00 ` Pavel Machek
2008-06-09 15:03 ` Alan Stern
2008-06-09 15:12 ` Oliver Neukum
2008-06-09 15:44 ` Alan Stern
2008-06-09 19:50 ` Greg KH
2008-06-09 20:59 ` Pavel Machek
2008-06-09 21:39 ` Linus Torvalds
2008-06-09 21:52 ` Oliver Neukum
2008-06-09 21:56 ` Pavel Machek [this message]
2008-06-09 22:19 ` Linus Torvalds
2008-06-10 8:55 ` Oliver Neukum
2008-06-10 14:59 ` Alan Stern
2008-06-10 15:50 ` Linus Torvalds
2008-06-10 16:36 ` Linus Torvalds
2008-06-10 18:59 ` [PATCH] USB: don't use reset-resume if drivers don't support it Alan Stern
2008-06-10 19:10 ` Linus Torvalds
2008-06-10 21:30 ` Greg KH
2008-06-10 21:42 ` patch usb-don-t-use-reset-resume-if-drivers-don-t-support-it.patch added to gregkh-2.6 tree gregkh
2008-06-09 19:56 ` 2.6.25-rc6: CONFIG_USB_PERSIST forced on Oliver Neukum
2008-06-09 15:35 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080609215651.GF21429@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@linuxfoundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox