From: Greg KH <gregkh@suse.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Oliver Neukum <oliver@neukum.org>, Pavel Machek <pavel@suse.cz>,
Linus Torvalds <torvalds@linux-foundation.org>,
Linus Torvalds <torvalds@linuxfoundation.org>,
Andrew Morton <akpm@linuxfoundation.org>,
kernel list <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: 2.6.25-rc6: CONFIG_USB_PERSIST forced on
Date: Mon, 9 Jun 2008 12:50:15 -0700 [thread overview]
Message-ID: <20080609195015.GA6601@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0806091142390.2943-100000@iolanthe.rowland.org>
On Mon, Jun 09, 2008 at 11:44:21AM -0400, Alan Stern wrote:
> On Mon, 9 Jun 2008, Oliver Neukum wrote:
>
> > Am Montag 09 Juni 2008 17:03:10 schrieb Alan Stern:
> > > On Mon, 9 Jun 2008, Pavel Machek wrote:
> > >
> > > > Besides, it seems to break suspend/resume of printers, and probably
> > > > all the drivers that do not have reset_resume() method. That's
> > > > actually a regression.
> > > >
> > > > https://bugzilla.novell.com/show_bug.cgi?id=394820
> > >
> > > The right way to fix this is to add reset_resume to the printer driver.
> >
> > reset_resume() is supposed to restore all state. The printer driver does
> > not know which state a printer is in, except for the trivial case of the
> > printer not being in use, as it doesn't know the meaning of the data
> > going to the printer.
> >
> > You might argue that you deserve what you get when you hibernate
> > while printing, but then it makes no sense to implement it anyhow,
> > disconnection and reconnection work just as well and are cleaner.
> > The same is true for many devices.
>
> In which case the correct approach is the second one I mentioned (which
> you omitted in your reply): Make usbcore unbind drivers that don't
> support reset_resume.
That sounds reasonable to me. Oliver or Pavel, care to try this out?
thanks,
greg k-h
next prev parent reply other threads:[~2008-06-09 19:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 9:25 2.6.25-rc6: CONFIG_USB_PERSIST forced on Pavel Machek
2008-06-06 14:39 ` Alan Stern
2008-06-07 19:52 ` Pavel Machek
2008-06-07 22:26 ` Linus Torvalds
2008-06-09 8:00 ` Pavel Machek
2008-06-09 15:03 ` Alan Stern
2008-06-09 15:12 ` Oliver Neukum
2008-06-09 15:44 ` Alan Stern
2008-06-09 19:50 ` Greg KH [this message]
2008-06-09 20:59 ` Pavel Machek
2008-06-09 21:39 ` Linus Torvalds
2008-06-09 21:52 ` Oliver Neukum
2008-06-09 21:56 ` Pavel Machek
2008-06-09 22:19 ` Linus Torvalds
2008-06-10 8:55 ` Oliver Neukum
2008-06-10 14:59 ` Alan Stern
2008-06-10 15:50 ` Linus Torvalds
2008-06-10 16:36 ` Linus Torvalds
2008-06-10 18:59 ` [PATCH] USB: don't use reset-resume if drivers don't support it Alan Stern
2008-06-10 19:10 ` Linus Torvalds
2008-06-10 21:30 ` Greg KH
2008-06-10 21:42 ` patch usb-don-t-use-reset-resume-if-drivers-don-t-support-it.patch added to gregkh-2.6 tree gregkh
2008-06-09 19:56 ` 2.6.25-rc6: CONFIG_USB_PERSIST forced on Oliver Neukum
2008-06-09 15:35 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080609195015.GA6601@suse.de \
--to=gregkh@suse.de \
--cc=akpm@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=pavel@suse.cz \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox