From: Pavel Machek <pavel@suse.cz>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Linus Torvalds <torvalds@linuxfoundation.org>,
gregkh@suse.de, Andrew Morton <akpm@linuxfoundation.org>,
kernel list <linux-kernel@vger.kernel.org>,
Oliver Neukum <oliver@neukum.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: 2.6.25-rc6: CONFIG_USB_PERSIST forced on
Date: Mon, 9 Jun 2008 10:00:52 +0200 [thread overview]
Message-ID: <20080609080052.GA27899@elf.ucw.cz> (raw)
In-Reply-To: <alpine.LFD.1.10.0806071525030.3473@woody.linux-foundation.org>
Hi!
On Sat 2008-06-07 15:26:12, Linus Torvalds wrote:
> On Sat, 7 Jun 2008, Pavel Machek wrote:
> > Well, not-usb-persists means we force-unplug disks during suspend,
> > after syncing them. Not _too_ bad.
> >
> > If you unplug disk while hibernated, modify it, and plug it back,
> > youget _silent_ filesystem corruption. I call that bad.
>
> .. and if the USB layer unplugs them unconditionally while the filesystem
> is mounted, you _unconditionally_ get a system that doesn't work.
If your device did not loose power during s2ram, it should just work.
There's a tweak you can set in /sys you can set if your device is not
removable, you can set it for non-removable devices that _do_ loose
power.
Besides, it seems to break suspend/resume of printers, and probably
all the drivers that do not have reset_resume() method. That's
actually a regression.
https://bugzilla.novell.com/show_bug.cgi?id=394820
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2008-06-09 12:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-06 9:25 2.6.25-rc6: CONFIG_USB_PERSIST forced on Pavel Machek
2008-06-06 14:39 ` Alan Stern
2008-06-07 19:52 ` Pavel Machek
2008-06-07 22:26 ` Linus Torvalds
2008-06-09 8:00 ` Pavel Machek [this message]
2008-06-09 15:03 ` Alan Stern
2008-06-09 15:12 ` Oliver Neukum
2008-06-09 15:44 ` Alan Stern
2008-06-09 19:50 ` Greg KH
2008-06-09 20:59 ` Pavel Machek
2008-06-09 21:39 ` Linus Torvalds
2008-06-09 21:52 ` Oliver Neukum
2008-06-09 21:56 ` Pavel Machek
2008-06-09 22:19 ` Linus Torvalds
2008-06-10 8:55 ` Oliver Neukum
2008-06-10 14:59 ` Alan Stern
2008-06-10 15:50 ` Linus Torvalds
2008-06-10 16:36 ` Linus Torvalds
2008-06-10 18:59 ` [PATCH] USB: don't use reset-resume if drivers don't support it Alan Stern
2008-06-10 19:10 ` Linus Torvalds
2008-06-10 21:30 ` Greg KH
2008-06-10 21:42 ` patch usb-don-t-use-reset-resume-if-drivers-don-t-support-it.patch added to gregkh-2.6 tree gregkh
2008-06-09 19:56 ` 2.6.25-rc6: CONFIG_USB_PERSIST forced on Oliver Neukum
2008-06-09 15:35 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080609080052.GA27899@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@linuxfoundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver@neukum.org \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox