public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Alok Kataria <akataria@vmware.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>,
	Daniel Hecht <dhecht@vmware.com>, Tim Mann <mann@vmware.com>,
	Zach Amsden <zach@vmware.com>, Sahil Rihan <srihan@vmware.com>
Subject: Re: [RFC PATCH] x86:Use cpu_khz for loops_per_jiffy calculation
Date: Fri, 20 Jun 2008 13:39:22 +0200	[thread overview]
Message-ID: <20080620113922.GG7439@elte.hu> (raw)
In-Reply-To: <1213924953.27983.52.camel@promb-2n-dhcp368.eng.vmware.com>


* Alok Kataria <akataria@vmware.com> wrote:

>  		loops_per_jiffy = preset_lpj;
> -		printk("Calibrating delay loop (skipped)... "
> -			"%lu.%02lu BogoMIPS preset\n",
> -			loops_per_jiffy/(500000/HZ),
> -			(loops_per_jiffy/(5000/HZ)) % 100);
> +		printk(KERN_DEBUG "Calibrating delay loop skipped, "
> +				"using preset value.. ");

i dont think the message should be eliminated from default logs via 
making it KERN_DEBUG - this message is a common pattern people watch out 
for and it does give an indication about various sorts of 
timing/performance trouble.

also, if you break a line like hat i'd suggest to do it like this:

> +		printk(KERN_DEBUG
> +		  "Calibrating delay loop skipped, using preset value.. ");

so that the string remains on a single line.

	Ingo

  reply	other threads:[~2008-06-20 11:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-04  0:41 [RFC PATCH] x86:Use cpu_khz for loops_per_jiffy calculation Alok Kataria
2008-06-04  1:20 ` Arjan van de Ven
2008-06-04  4:01   ` Alok kataria
2008-06-04 13:16     ` Arjan van de Ven
2008-06-05 18:37       ` Alok Kataria
2008-06-20  1:22       ` Alok Kataria
2008-06-20 11:39         ` Ingo Molnar [this message]
2008-06-20 22:06           ` Alok Kataria
2008-06-23 20:54             ` Ingo Molnar
2008-06-23 23:21             ` Ingo Molnar
2008-06-23 23:34               ` Alok Kataria
2008-06-23 23:47                 ` Ingo Molnar
2008-06-24  1:21                   ` Alok Kataria
2008-06-24 11:54                     ` Ingo Molnar
2008-06-24 17:57             ` Pavel Machek
2008-06-26 17:20               ` Alok Kataria
2008-06-26 17:35                 ` Pavel Machek
2008-06-26 18:10                   ` Alok Kataria
2008-06-26 22:16                     ` Pavel Machek
2008-06-26 23:10                       ` Alok Kataria
2008-06-27  8:12                         ` Pavel Machek
2008-06-04 14:17 ` Pavel Machek
2008-06-09 13:11 ` Ingo Molnar
2008-06-09 17:55   ` Alok Kataria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080620113922.GG7439@elte.hu \
    --to=mingo@elte.hu \
    --cc=akataria@vmware.com \
    --cc=arjan@infradead.org \
    --cc=dhecht@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mann@vmware.com \
    --cc=srihan@vmware.com \
    --cc=tglx@linutronix.de \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox