From: Ingo Molnar <mingo@elte.hu>
To: Alok Kataria <akataria@vmware.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Daniel Hecht <dhecht@vmware.com>, Tim Mann <mann@vmware.com>,
Zach Amsden <zach@vmware.com>, Sahil Rihan <srihan@vmware.com>
Subject: Re: [RFC PATCH] x86:Use cpu_khz for loops_per_jiffy calculation
Date: Tue, 24 Jun 2008 01:47:28 +0200 [thread overview]
Message-ID: <20080623234728.GA17297@elte.hu> (raw)
In-Reply-To: <1214264070.3882.22.camel@promb-2n-dhcp368.eng.vmware.com>
* Alok Kataria <akataria@vmware.com> wrote:
> > but there's another problem as well: why are generic files
> > (init/calibrate.c and include/linux/delay.h) using something that is
> > named in an x86-specific way - lpj_tsc ? (TSC is an x86 concept)
>
> calibrate_delay_direct was using some variables with "tsc" as the
> prefix (tsc_rate_min/max) ...so i thought of using lpj_tsc. And also
> IMO, lpj_tsc explains how is this variable initialized. But thinking
> about it, maybe we should rename it to "lpj_timer" ?
ok. But instead of 'lpj_timer' i'd suggest to use something like
'lpj_fine' - as this really is about finegrained measurements.
I'd suggest a delta patch against tip/master that renames all those
tsc_* variables to fine_*. So tsc_rate_min would become fine_rate_min,
etc.
Ingo
next prev parent reply other threads:[~2008-06-23 23:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-04 0:41 [RFC PATCH] x86:Use cpu_khz for loops_per_jiffy calculation Alok Kataria
2008-06-04 1:20 ` Arjan van de Ven
2008-06-04 4:01 ` Alok kataria
2008-06-04 13:16 ` Arjan van de Ven
2008-06-05 18:37 ` Alok Kataria
2008-06-20 1:22 ` Alok Kataria
2008-06-20 11:39 ` Ingo Molnar
2008-06-20 22:06 ` Alok Kataria
2008-06-23 20:54 ` Ingo Molnar
2008-06-23 23:21 ` Ingo Molnar
2008-06-23 23:34 ` Alok Kataria
2008-06-23 23:47 ` Ingo Molnar [this message]
2008-06-24 1:21 ` Alok Kataria
2008-06-24 11:54 ` Ingo Molnar
2008-06-24 17:57 ` Pavel Machek
2008-06-26 17:20 ` Alok Kataria
2008-06-26 17:35 ` Pavel Machek
2008-06-26 18:10 ` Alok Kataria
2008-06-26 22:16 ` Pavel Machek
2008-06-26 23:10 ` Alok Kataria
2008-06-27 8:12 ` Pavel Machek
2008-06-04 14:17 ` Pavel Machek
2008-06-09 13:11 ` Ingo Molnar
2008-06-09 17:55 ` Alok Kataria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080623234728.GA17297@elte.hu \
--to=mingo@elte.hu \
--cc=akataria@vmware.com \
--cc=arjan@infradead.org \
--cc=dhecht@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mann@vmware.com \
--cc=srihan@vmware.com \
--cc=tglx@linutronix.de \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox