[PATCH] oprofile: Add support for missing Intel core i7 models

[PATCH] oprofile: Add support for missing Intel core i7 models

[Shawn Bohrer]

Added missing core i7 models found in "Intel 64 and IA-32 Architectures
Software Developer's Manual Volume 3B: System Programming Guide",
Table B-1.  Tested with oprofile 0.9.6 on a:

model      : 44
model name : Intel(R) Xeon(R) CPU           X5680  @ 3.33GHz

Signed-off-by: Shawn Bohrer <sbohrer@rgmadvisors.com>
---
 arch/x86/oprofile/nmi_int.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/x86/oprofile/nmi_int.c b/arch/x86/oprofile/nmi_int.c
index e2b7b0c..1523313 100644
--- a/arch/x86/oprofile/nmi_int.c
+++ b/arch/x86/oprofile/nmi_int.c
@@ -678,6 +678,9 @@ static int __init ppro_init(char **cpu_type)
 		break;
 	case 0x1a:
 	case 0x1e:
+	case 0x1f:
+	case 0x25:
+	case 0x2c:
 	case 0x2e:
 		spec = &op_arch_perfmon_spec;
 		*cpu_type = "i386/core_i7";
-- 
1.7.3.4

Re: [PATCH] oprofile: Add support for missing Intel core i7 models

[Robert Richter]

On 13.01.11 17:38:11, Shawn Bohrer wrote:
> Added missing core i7 models found in "Intel 64 and IA-32 Architectures
> Software Developer's Manual Volume 3B: System Programming Guide",
> Table B-1.  Tested with oprofile 0.9.6 on a:
> 
> model      : 44
> model name : Intel(R) Xeon(R) CPU           X5680  @ 3.33GHz
> 
> Signed-off-by: Shawn Bohrer <sbohrer@rgmadvisors.com>

Andi,

please ACK.

Thanks,

-Robert

> ---
>  arch/x86/oprofile/nmi_int.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/oprofile/nmi_int.c b/arch/x86/oprofile/nmi_int.c
> index e2b7b0c..1523313 100644
> --- a/arch/x86/oprofile/nmi_int.c
> +++ b/arch/x86/oprofile/nmi_int.c
> @@ -678,6 +678,9 @@ static int __init ppro_init(char **cpu_type)
>  		break;
>  	case 0x1a:
>  	case 0x1e:
> +	case 0x1f:
> +	case 0x25:
> +	case 0x2c:
>  	case 0x2e:
>  		spec = &op_arch_perfmon_spec;
>  		*cpu_type = "i386/core_i7";
> -- 
> 1.7.3.4
> 
> 

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

Re: [PATCH] oprofile: Add support for missing Intel core i7 models

[Andi Kleen]

On Fri, Jan 14, 2011 at 12:55:03AM +0100, Robert Richter wrote:
> On 13.01.11 17:38:11, Shawn Bohrer wrote:
> > Added missing core i7 models found in "Intel 64 and IA-32 Architectures
> > Software Developer's Manual Volume 3B: System Programming Guide",
> > Table B-1.  Tested with oprofile 0.9.6 on a:
> > 
> > model      : 44
> > model name : Intel(R) Xeon(R) CPU           X5680  @ 3.33GHz
> > 
> > Signed-off-by: Shawn Bohrer <sbohrer@rgmadvisors.com>
> 
> Andi,
> 
> please ACK.

NACK -- first it's wrong because that's a westmere and westmere
has a different event list. And the new way is to fall back to arch-perfmon
and handle the CPUID in user space. This has been already implemented.
So the fix is to upgrade user space.

-Andi

Re: [PATCH] oprofile: Add support for missing Intel core i7 models

[Robert Richter]

On 13.01.11 19:24:35, Andi Kleen wrote:
> On Fri, Jan 14, 2011 at 12:55:03AM +0100, Robert Richter wrote:
> > On 13.01.11 17:38:11, Shawn Bohrer wrote:
> > > Added missing core i7 models found in "Intel 64 and IA-32 Architectures
> > > Software Developer's Manual Volume 3B: System Programming Guide",
> > > Table B-1.  Tested with oprofile 0.9.6 on a:
> > > 
> > > model      : 44
> > > model name : Intel(R) Xeon(R) CPU           X5680  @ 3.33GHz
> > > 
> > > Signed-off-by: Shawn Bohrer <sbohrer@rgmadvisors.com>
> > 
> > Andi,
> > 
> > please ACK.
> 
> NACK -- first it's wrong because that's a westmere and westmere
> has a different event list. And the new way is to fall back to arch-perfmon
> and handle the CPUID in user space. This has been already implemented.
> So the fix is to upgrade user space.

Andi,

thanks for looking at this.

Will it be the general way in the future not to add model detection
for new Intel cpus to kernel code and instead use arch_perfmon? Are
the user land patches for cpu detection already in the oprofile
repository? I assume oprofile 0.9.6 is not up-to-date and needs to be
patched.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

Re: [PATCH] oprofile: Add support for missing Intel core i7 models

[Maynard Johnson]

On 01/13/2011 8:29 PM, Robert Richter wrote:
> On 13.01.11 19:24:35, Andi Kleen wrote:
>> On Fri, Jan 14, 2011 at 12:55:03AM +0100, Robert Richter wrote:
>>> On 13.01.11 17:38:11, Shawn Bohrer wrote:
>>>> Added missing core i7 models found in "Intel 64 and IA-32 Architectures
>>>> Software Developer's Manual Volume 3B: System Programming Guide",
>>>> Table B-1.  Tested with oprofile 0.9.6 on a:
>>>>
>>>> model      : 44
>>>> model name : Intel(R) Xeon(R) CPU           X5680  @ 3.33GHz
>>>>
>>>> Signed-off-by: Shawn Bohrer<sbohrer@rgmadvisors.com>
>>>
>>> Andi,
>>>
>>> please ACK.
>>
>> NACK -- first it's wrong because that's a westmere and westmere
>> has a different event list. And the new way is to fall back to arch-perfmon
>> and handle the CPUID in user space. This has been already implemented.
>> So the fix is to upgrade user space.
>
> Andi,
>
> thanks for looking at this.
>
> Will it be the general way in the future not to add model detection
> for new Intel cpus to kernel code and instead use arch_perfmon? Are
> the user land patches for cpu detection already in the oprofile
> repository? I assume oprofile 0.9.6 is not up-to-date and needs to be
> patched.
Yes, as Andi said above, the processor detection via cpuid has already been 
implemented and accepted to oprofile userspace -- thanks to Will Cohen.

-Maynard
>
> -Robert
>

Re: [PATCH] oprofile: Add support for missing Intel core i7 models

[Andi Kleen]

> Will it be the general way in the future not to add model detection
> for new Intel cpus to kernel code and instead use arch_perfmon? Are

Yes, at least for features that do not need specific new kernel support.
And it looks like most (all?) of the these features will be perf only.

The advantage of the scheme is that it avoids the major problems
we had with updates in the past where userland and kernel had to be
updated in lock-step.

> the user land patches for cpu detection already in the oprofile
> repository? I assume oprofile 0.9.6 is not up-to-date and needs to be
> patched.

It's in CVS.

-Andi

Re: [PATCH] oprofile: Add support for missing Intel core i7 models

[William Cohen]

On 01/14/2011 06:43 PM, Andi Kleen wrote:
>> Will it be the general way in the future not to add model detection
>> for new Intel cpus to kernel code and instead use arch_perfmon? Are
> 
> Yes, at least for features that do not need specific new kernel support.
> And it looks like most (all?) of the these features will be perf only.
> 
> The advantage of the scheme is that it avoids the major problems
> we had with updates in the past where userland and kernel had to be
> updated in lock-step.
> 
>> the user land patches for cpu detection already in the oprofile
>> repository? I assume oprofile 0.9.6 is not up-to-date and needs to be
>> patched.
> 
> It's in CVS.
> 
> -Andi
> 
> ------------------------------------------------------------------------------
> Protect Your Site and Customers from Malware Attacks
> Learn about various malware tactics and how to avoid them. Understand 
> malware threats, the impact they can have on your business, and how you 
> can protect your company and customers by using code signing.
> http://p.sf.net/sfu/oracle-sfdevnl
> _______________________________________________
> oprofile-list mailing list
> oprofile-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/oprofile-list

There are also Fedora 13, Fedora 14 and Fedora rawhide rpms available with this cpuid detection support in them. The Fedora 13 and Fedora 14 versions have bodhi updates, available via "yum update --enablerepo=updates-testing oprofile". Please give feedback on them on the Fedora update pages:

https://admin.fedoraproject.org/updates/oprofile-0.9.6-10.fc13
https://admin.fedoraproject.org/updates/oprofile-0.9.6-10.fc14


-Will