From: Tejun Heo <tj@kernel.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>, NeilBrown <neilb@suse.de>,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>
Subject: Re: [PATCH] floppy: remove floppy-specific O_EXCL handling
Date: Mon, 14 May 2012 14:19:13 -0700 [thread overview]
Message-ID: <20120514211913.GL2366@google.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1205142237590.15448@pobox.suse.cz>
Hello,
On Mon, May 14, 2012 at 10:42:58PM +0200, Jiri Kosina wrote:
> Because since
>
> commit e525fd89d380c4a94c0d63913a1dd1a593ed25e7
> Author: Tejun Heo <tj@kernel.org>
> Date: Sat Nov 13 11:55:17 2010 +0100
>
> block: make blkdev_get/put() handle exclusive access
>
> mount of /dev/fd0 actually causes the fd0 block device be claimed with
> _EXCL. Before this commit, you are able to mount /dev/fd0 and then open()
> it afterward. After this commit you can't any more, because mounting
> /dev/fd0 already passes O_EXCL to floppy_open(), and thus noone else can
> open(/dev/fd0) any more.
>
> My commit brings things back into shape, i.e. you can, equally to other
> block devices, both mount it and open() it afterwards.
Ah, that makes sense. Maybe it's a good idea to note why the change
is necessary in the commit message too?
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2012-05-14 21:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-13 9:02 [PATCH] floppy: remove floppy-specific O_EXCL handling Jiri Kosina
2012-05-14 16:25 ` Tejun Heo
2012-05-14 16:49 ` Joe Perches
2012-05-14 20:42 ` Jiri Kosina
2012-05-14 21:19 ` Tejun Heo [this message]
2012-05-14 21:38 ` Jiri Kosina
2012-05-14 23:22 ` NeilBrown
2012-05-15 6:15 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120514211913.GL2366@google.com \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=jkosina@suse.cz \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox