* [PATCH] mfd: twl4030-power: Support compatible = "ti,twl4030-power" again.
@ 2014-11-08 0:22 NeilBrown
2014-11-08 7:24 ` [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again Dr. H. Nikolaus Schaller
2014-11-10 9:07 ` [PATCH] mfd: twl4030-power: Support compatible = "ti,twl4030-power" again Lee Jones
0 siblings, 2 replies; 5+ messages in thread
From: NeilBrown @ 2014-11-08 0:22 UTC (permalink / raw)
To: Tony Lindgren, Samuel Ortiz, Lee Jones; +Cc: linux-kernel, GTA04 owners
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
mfd: twl4030-power: Add generic reset configuration
claims:
Let's add device tree support and configure things for warm reset
as the default when compatible = "ti,twl4030-power".
and
Documentation/devicetree/bindings/mfd/twl4030-power.txt
claims that "ti,twl4030-power" is still a valid "compatible" setting.
However the current driver fails to probe with that 'compatible'
setting.
Restore the old default.
Signed-off-by: NeilBrown <neilb@suse.de>
diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
index 4d3ff3771491..1a7794f6be15 100644
--- a/drivers/mfd/twl4030-power.c
+++ b/drivers/mfd/twl4030-power.c
@@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
static struct of_device_id twl4030_power_of_match[] = {
{
+ .compatible = "ti,twl4030-power",
+ .data = NULL,
+ },
+ {
.compatible = "ti,twl4030-power-reset",
.data = &omap3_reset,
},
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again.
2014-11-08 0:22 [PATCH] mfd: twl4030-power: Support compatible = "ti,twl4030-power" again NeilBrown
@ 2014-11-08 7:24 ` Dr. H. Nikolaus Schaller
2014-11-10 1:27 ` NeilBrown
2014-11-10 9:07 ` [PATCH] mfd: twl4030-power: Support compatible = "ti,twl4030-power" again Lee Jones
1 sibling, 1 reply; 5+ messages in thread
From: Dr. H. Nikolaus Schaller @ 2014-11-08 7:24 UTC (permalink / raw)
To: NeilBrown
Cc: Tony Lindgren, Samuel Ortiz, Lee Jones, LKML,
List for communicating with real GTA04 owners
Am 08.11.2014 um 01:22 schrieb NeilBrown <neilb@suse.de>:
>
> commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
> mfd: twl4030-power: Add generic reset configuration
>
> claims:
> Let's add device tree support and configure things for warm reset
> as the default when compatible = "ti,twl4030-power".
> and
> Documentation/devicetree/bindings/mfd/twl4030-power.txt
> claims that "ti,twl4030-power" is still a valid "compatible" setting.
>
> However the current driver fails to probe with that 'compatible'
> setting.
> Restore the old default.
I think this is a duplicate to
599a1ca80d1d8269d54fdc4abdec8e65141381fe
(in linux-next)
>
> Signed-off-by: NeilBrown <neilb@suse.de>
>
> diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> index 4d3ff3771491..1a7794f6be15 100644
> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
>
> static struct of_device_id twl4030_power_of_match[] = {
> {
> + .compatible = "ti,twl4030-power",
> + .data = NULL,
> + },
> + {
> .compatible = "ti,twl4030-power-reset",
> .data = &omap3_reset,
> },
> _______________________________________________
> Gta04-owner mailing list
> Gta04-owner@goldelico.com
> http://lists.goldelico.com/mailman/listinfo.cgi/gta04-owner
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again.
2014-11-08 7:24 ` [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again Dr. H. Nikolaus Schaller
@ 2014-11-10 1:27 ` NeilBrown
2014-11-10 9:09 ` Lee Jones
0 siblings, 1 reply; 5+ messages in thread
From: NeilBrown @ 2014-11-10 1:27 UTC (permalink / raw)
To: Dr. H. Nikolaus Schaller
Cc: Tony Lindgren, Samuel Ortiz, Lee Jones, LKML,
List for communicating with real GTA04 owners
[-- Attachment #1: Type: text/plain, Size: 1619 bytes --]
On Sat, 8 Nov 2014 08:24:28 +0100 "Dr. H. Nikolaus Schaller"
<hns@goldelico.com> wrote:
>
> Am 08.11.2014 um 01:22 schrieb NeilBrown <neilb@suse.de>:
>
> >
> > commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
> > mfd: twl4030-power: Add generic reset configuration
> >
> > claims:
> > Let's add device tree support and configure things for warm reset
> > as the default when compatible = "ti,twl4030-power".
> > and
> > Documentation/devicetree/bindings/mfd/twl4030-power.txt
> > claims that "ti,twl4030-power" is still a valid "compatible" setting.
> >
> > However the current driver fails to probe with that 'compatible'
> > setting.
> > Restore the old default.
>
> I think this is a duplicate to
>
> 599a1ca80d1d8269d54fdc4abdec8e65141381fe
>
> (in linux-next)
Ahh, so it is. Thanks.
NeilBrown
>
> >
> > Signed-off-by: NeilBrown <neilb@suse.de>
> >
> > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> > index 4d3ff3771491..1a7794f6be15 100644
> > --- a/drivers/mfd/twl4030-power.c
> > +++ b/drivers/mfd/twl4030-power.c
> > @@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
> >
> > static struct of_device_id twl4030_power_of_match[] = {
> > {
> > + .compatible = "ti,twl4030-power",
> > + .data = NULL,
> > + },
> > + {
> > .compatible = "ti,twl4030-power-reset",
> > .data = &omap3_reset,
> > },
> > _______________________________________________
> > Gta04-owner mailing list
> > Gta04-owner@goldelico.com
> > http://lists.goldelico.com/mailman/listinfo.cgi/gta04-owner
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again.
2014-11-10 1:27 ` NeilBrown
@ 2014-11-10 9:09 ` Lee Jones
0 siblings, 0 replies; 5+ messages in thread
From: Lee Jones @ 2014-11-10 9:09 UTC (permalink / raw)
To: NeilBrown
Cc: Dr. H. Nikolaus Schaller, Tony Lindgren, Samuel Ortiz, LKML,
List for communicating with real GTA04 owners
On Mon, 10 Nov 2014, NeilBrown wrote:
> On Sat, 8 Nov 2014 08:24:28 +0100 "Dr. H. Nikolaus Schaller"
> <hns@goldelico.com> wrote:
>
> >
> > Am 08.11.2014 um 01:22 schrieb NeilBrown <neilb@suse.de>:
> >
> > >
> > > commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
> > > mfd: twl4030-power: Add generic reset configuration
> > >
> > > claims:
> > > Let's add device tree support and configure things for warm reset
> > > as the default when compatible = "ti,twl4030-power".
> > > and
> > > Documentation/devicetree/bindings/mfd/twl4030-power.txt
> > > claims that "ti,twl4030-power" is still a valid "compatible" setting.
> > >
> > > However the current driver fails to probe with that 'compatible'
> > > setting.
> > > Restore the old default.
> >
> > I think this is a duplicate to
> >
> > 599a1ca80d1d8269d54fdc4abdec8e65141381fe
> >
> > (in linux-next)
>
>
> Ahh, so it is. Thanks.
Just read this.
Previous reply withdrawn.
> > > Signed-off-by: NeilBrown <neilb@suse.de>
> > >
> > > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> > > index 4d3ff3771491..1a7794f6be15 100644
> > > --- a/drivers/mfd/twl4030-power.c
> > > +++ b/drivers/mfd/twl4030-power.c
> > > @@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
> > >
> > > static struct of_device_id twl4030_power_of_match[] = {
> > > {
> > > + .compatible = "ti,twl4030-power",
> > > + .data = NULL,
> > > + },
> > > + {
> > > .compatible = "ti,twl4030-power-reset",
> > > .data = &omap3_reset,
> > > },
> > > _______________________________________________
> > > Gta04-owner mailing list
> > > Gta04-owner@goldelico.com
> > > http://lists.goldelico.com/mailman/listinfo.cgi/gta04-owner
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mfd: twl4030-power: Support compatible = "ti,twl4030-power" again.
2014-11-08 0:22 [PATCH] mfd: twl4030-power: Support compatible = "ti,twl4030-power" again NeilBrown
2014-11-08 7:24 ` [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again Dr. H. Nikolaus Schaller
@ 2014-11-10 9:07 ` Lee Jones
1 sibling, 0 replies; 5+ messages in thread
From: Lee Jones @ 2014-11-10 9:07 UTC (permalink / raw)
To: NeilBrown; +Cc: Tony Lindgren, Samuel Ortiz, linux-kernel, GTA04 owners
On Sat, 08 Nov 2014, NeilBrown wrote:
>
> commit e7cd1d1eb16fcdf53001b926187a82f1f3e1a7e6
> mfd: twl4030-power: Add generic reset configuration
>
> claims:
> Let's add device tree support and configure things for warm reset
> as the default when compatible = "ti,twl4030-power".
> and
> Documentation/devicetree/bindings/mfd/twl4030-power.txt
> claims that "ti,twl4030-power" is still a valid "compatible" setting.
>
> However the current driver fails to probe with that 'compatible'
> setting.
> Restore the old default.
>
> Signed-off-by: NeilBrown <neilb@suse.de>
Tony should take a look at this.
> diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> index 4d3ff3771491..1a7794f6be15 100644
> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -776,6 +776,10 @@ static struct twl4030_power_data osc_off_idle = {
>
> static struct of_device_id twl4030_power_of_match[] = {
> {
> + .compatible = "ti,twl4030-power",
> + .data = NULL,
> + },
> + {
> .compatible = "ti,twl4030-power-reset",
> .data = &omap3_reset,
> },
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-10 9:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-08 0:22 [PATCH] mfd: twl4030-power: Support compatible = "ti,twl4030-power" again NeilBrown
2014-11-08 7:24 ` [Gta04-owner] [PATCH] mfd: twl4030-power: Support compatible = "ti, twl4030-power" again Dr. H. Nikolaus Schaller
2014-11-10 1:27 ` NeilBrown
2014-11-10 9:09 ` Lee Jones
2014-11-10 9:07 ` [PATCH] mfd: twl4030-power: Support compatible = "ti,twl4030-power" again Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox