* [PATCH 1/1] mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP
@ 2015-10-01 13:06 Andy Shevchenko
2015-10-01 14:45 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2015-10-01 13:06 UTC (permalink / raw)
To: Lee Jones, linux-kernel; +Cc: Andy Shevchenko
Jim Davis reported the compilation error with a random configuration which
apparently has CONFIG_PM=y and CONFIG_PM_SLEEP=n. With that conditions we have
missed definition of INTEL_LPSS_SLEEP_PM_OPS macro. Add it here.
Reported-by: Jim Davis <jim.epost@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mfd/intel-lpss.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/intel-lpss.h b/drivers/mfd/intel-lpss.h
index f28cb28a..2c7f8d7 100644
--- a/drivers/mfd/intel-lpss.h
+++ b/drivers/mfd/intel-lpss.h
@@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev);
.thaw = intel_lpss_resume, \
.poweroff = intel_lpss_suspend, \
.restore = intel_lpss_resume,
+#else
+#define INTEL_LPSS_SLEEP_PM_OPS
#endif
#define INTEL_LPSS_RUNTIME_PM_OPS \
--
2.5.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP
2015-10-01 13:06 [PATCH 1/1] mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP Andy Shevchenko
@ 2015-10-01 14:45 ` Lee Jones
2015-10-02 12:21 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2015-10-01 14:45 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: linux-kernel
On Thu, 01 Oct 2015, Andy Shevchenko wrote:
> Jim Davis reported the compilation error with a random configuration which
> apparently has CONFIG_PM=y and CONFIG_PM_SLEEP=n. With that conditions we have
> missed definition of INTEL_LPSS_SLEEP_PM_OPS macro. Add it here.
>
> Reported-by: Jim Davis <jim.epost@gmail.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mfd/intel-lpss.h | 2 ++
> 1 file changed, 2 insertions(+)
Why are you using this email address?
Please use ./get_maintainer.pl properly.
> diff --git a/drivers/mfd/intel-lpss.h b/drivers/mfd/intel-lpss.h
> index f28cb28a..2c7f8d7 100644
> --- a/drivers/mfd/intel-lpss.h
> +++ b/drivers/mfd/intel-lpss.h
> @@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev);
> .thaw = intel_lpss_resume, \
> .poweroff = intel_lpss_suspend, \
> .restore = intel_lpss_resume,
> +#else
> +#define INTEL_LPSS_SLEEP_PM_OPS
> #endif
>
> #define INTEL_LPSS_RUNTIME_PM_OPS \
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP
2015-10-01 14:45 ` Lee Jones
@ 2015-10-02 12:21 ` Andy Shevchenko
2015-10-05 8:28 ` Lee Jones
0 siblings, 1 reply; 6+ messages in thread
From: Andy Shevchenko @ 2015-10-02 12:21 UTC (permalink / raw)
To: Lee Jones; +Cc: linux-kernel
On Thu, 2015-10-01 at 15:45 +0100, Lee Jones wrote:
> On Thu, 01 Oct 2015, Andy Shevchenko wrote:
>
> > Jim Davis reported the compilation error with a random
> > configuration which
> > apparently has CONFIG_PM=y and CONFIG_PM_SLEEP=n. With that
> > conditions we have
> > missed definition of INTEL_LPSS_SLEEP_PM_OPS macro. Add it here.
> >
> > Reported-by: Jim Davis <jim.epost@gmail.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/mfd/intel-lpss.h | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Why are you using this email address?
In fact it *had* the proper address [1] and after you confused me [2].
[1] http://www.spinics.net/lists/kernel/msg2073973.html
[2] http://www.spinics.net/lists/linux-fsdevel/msg90269.html
>
> Please use ./get_maintainer.pl properly.
>
> > diff --git a/drivers/mfd/intel-lpss.h b/drivers/mfd/intel-lpss.h
> > index f28cb28a..2c7f8d7 100644
> > --- a/drivers/mfd/intel-lpss.h
> > +++ b/drivers/mfd/intel-lpss.h
> > @@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev);
> > .thaw = intel_lpss_resume, \
> > .poweroff = intel_lpss_suspend, \
> > .restore = intel_lpss_resume,
> > +#else
> > +#define INTEL_LPSS_SLEEP_PM_OPS
> > #endif
> >
> > #define INTEL_LPSS_RUNTIME_PM_OPS \
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP
2015-10-02 12:21 ` Andy Shevchenko
@ 2015-10-05 8:28 ` Lee Jones
2015-10-05 8:52 ` Andy Shevchenko
0 siblings, 1 reply; 6+ messages in thread
From: Lee Jones @ 2015-10-05 8:28 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Lee Jones, linux-kernel
On Fri, 02 Oct 2015, Andy Shevchenko wrote:
> On Thu, 2015-10-01 at 15:45 +0100, Lee Jones wrote:
> > On Thu, 01 Oct 2015, Andy Shevchenko wrote:
> >
> > > Jim Davis reported the compilation error with a random
> > > configuration which
> > > apparently has CONFIG_PM=y and CONFIG_PM_SLEEP=n. With that
> > > conditions we have
> > > missed definition of INTEL_LPSS_SLEEP_PM_OPS macro. Add it here.
> > >
> > > Reported-by: Jim Davis <jim.epost@gmail.com>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > > drivers/mfd/intel-lpss.h | 2 ++
> > > 1 file changed, 2 insertions(+)
> >
> > Why are you using this email address?
>
> In fact it *had* the proper address [1] and after you confused me [2].
>
> [1] http://www.spinics.net/lists/kernel/msg2073973.html
This was the original patch submission, which was correct.
https://lkml.org/lkml/2015/10/1/484
However this email you sent to the wrong address.
> [2] http://www.spinics.net/lists/linux-fsdevel/msg90269.html
Then you followed up with a patch, also to the wrong address.
BTW: This patch has already been applied to my -fixes branch and will
be sent to Mainline in a week or so.
> > Please use ./get_maintainer.pl properly.
> >
> > > diff --git a/drivers/mfd/intel-lpss.h b/drivers/mfd/intel-lpss.h
> > > index f28cb28a..2c7f8d7 100644
> > > --- a/drivers/mfd/intel-lpss.h
> > > +++ b/drivers/mfd/intel-lpss.h
> > > @@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev);
> > > .thaw = intel_lpss_resume, \
> > > .poweroff = intel_lpss_suspend, \
> > > .restore = intel_lpss_resume,
> > > +#else
> > > +#define INTEL_LPSS_SLEEP_PM_OPS
> > > #endif
> > >
> > > #define INTEL_LPSS_RUNTIME_PM_OPS \
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP
2015-10-05 8:28 ` Lee Jones
@ 2015-10-05 8:52 ` Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2015-10-05 8:52 UTC (permalink / raw)
To: Lee Jones; +Cc: Lee Jones, linux-kernel
On Mon, 2015-10-05 at 09:28 +0100, Lee Jones wrote:
> >
> BTW: This patch has already been applied to my -fixes branch and will
> be sent to Mainline in a week or so.
Thanks!
P.S. I have got a message from kbuild bot that the bug is still there,
though I noticed that the patch made at least linux-next tree.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP
@ 2015-07-30 10:46 Andy Shevchenko
0 siblings, 0 replies; 6+ messages in thread
From: Andy Shevchenko @ 2015-07-30 10:46 UTC (permalink / raw)
To: Lee Jones, Jim Davis, Stephen Rothwell, linux-next, linux-kernel
Cc: Andy Shevchenko
Jim Davis reported the compilation error with a random configuration which
apparently has CONFIG_PM=y and CONFIG_PM_SLEEP=n. With that conditions we have
missed definition of INTEL_LPSS_SLEEP_PM_OPS macro. Add it here.
Reported-by: Jim Davis <jim.epost@gmail.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/mfd/intel-lpss.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/intel-lpss.h b/drivers/mfd/intel-lpss.h
index f28cb28a..2c7f8d7 100644
--- a/drivers/mfd/intel-lpss.h
+++ b/drivers/mfd/intel-lpss.h
@@ -42,6 +42,8 @@ int intel_lpss_resume(struct device *dev);
.thaw = intel_lpss_resume, \
.poweroff = intel_lpss_suspend, \
.restore = intel_lpss_resume,
+#else
+#define INTEL_LPSS_SLEEP_PM_OPS
#endif
#define INTEL_LPSS_RUNTIME_PM_OPS \
--
2.4.6
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-05 8:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-01 13:06 [PATCH 1/1] mfd: intel-lpss: fix build error when !CONFIG_PM_SLEEP Andy Shevchenko
2015-10-01 14:45 ` Lee Jones
2015-10-02 12:21 ` Andy Shevchenko
2015-10-05 8:28 ` Lee Jones
2015-10-05 8:52 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2015-07-30 10:46 Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox