* [patch] char/pcmcia: add some error checking in scr24x_read()
@ 2016-11-24 10:46 Dan Carpenter
2016-11-24 10:48 ` Lubomir Rintel
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-11-24 10:46 UTC (permalink / raw)
To: Lubomir Rintel; +Cc: linux-kernel, kernel-janitors, Greg Kroah-Hartman
The "ret = " assignment seems to have accidentally been left off.
Fixes: f2ed287bcc90 ("char/pcmcia: add scr24x_cs chip card interface driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/char/pcmcia/scr24x_cs.c b/drivers/char/pcmcia/scr24x_cs.c
index 4f215ce..8523ec5 100644
--- a/drivers/char/pcmcia/scr24x_cs.c
+++ b/drivers/char/pcmcia/scr24x_cs.c
@@ -157,7 +157,7 @@ static ssize_t scr24x_read(struct file *filp, char __user *buf, size_t count,
ret = -EIO;
goto out;
}
- read_chunk(dev, CCID_HEADER_SIZE, len);
+ ret = read_chunk(dev, CCID_HEADER_SIZE, len);
if (ret < 0)
goto out;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] char/pcmcia: add some error checking in scr24x_read()
2016-11-24 10:46 [patch] char/pcmcia: add some error checking in scr24x_read() Dan Carpenter
@ 2016-11-24 10:48 ` Lubomir Rintel
0 siblings, 0 replies; 2+ messages in thread
From: Lubomir Rintel @ 2016-11-24 10:48 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-kernel, kernel-janitors, Greg Kroah-Hartman
On Thu, 2016-11-24 at 13:46 +0300, Dan Carpenter wrote:
> The "ret = " assignment seems to have accidentally been left off.
>
> Fixes: f2ed287bcc90 ("char/pcmcia: add scr24x_cs chip card interface
> driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/char/pcmcia/scr24x_cs.c
> b/drivers/char/pcmcia/scr24x_cs.c
> index 4f215ce..8523ec5 100644
> --- a/drivers/char/pcmcia/scr24x_cs.c
> +++ b/drivers/char/pcmcia/scr24x_cs.c
> @@ -157,7 +157,7 @@ static ssize_t scr24x_read(struct file *filp,
> char __user *buf, size_t count,
> ret = -EIO;
> goto out;
> }
> - read_chunk(dev, CCID_HEADER_SIZE, len);
> + ret = read_chunk(dev, CCID_HEADER_SIZE, len);
> if (ret < 0)
> goto out;
Acked-by: Lubomir Rintel <lkundrak@v3.sk>
Thank you,
Lubo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-24 10:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-24 10:46 [patch] char/pcmcia: add some error checking in scr24x_read() Dan Carpenter
2016-11-24 10:48 ` Lubomir Rintel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox