* [PATCH] cpuidle: fix broadcast control when broadcast can not be entered
@ 2017-09-01 4:29 Nicholas Piggin
2017-09-01 7:44 ` Thomas Gleixner
0 siblings, 1 reply; 3+ messages in thread
From: Nicholas Piggin @ 2017-09-01 4:29 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano
Cc: Nicholas Piggin, linux-pm, linux-kernel, Thomas Gleixner
When failing to enter broadcast timer mode for an idle state that
requires it, a new state is selected that does not require broadcast,
but the broadcast variable remains set. This causes
tick_broadcast_exit to be called despite not having entered broadcast
mode.
This causes the WARN_ON_ONCE(!irqs_disabled()) to trigger in some
cases. It does not appear to cause problems for code today, but seems
to violate the interface so should be fixed.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
drivers/cpuidle/cpuidle.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
index 60bb64f4329d..4453e27f855e 100644
--- a/drivers/cpuidle/cpuidle.c
+++ b/drivers/cpuidle/cpuidle.c
@@ -208,6 +208,7 @@ int cpuidle_enter_state(struct cpuidle_device *dev, struct cpuidle_driver *drv,
return -EBUSY;
}
target_state = &drv->states[index];
+ broadcast = false;
}
/* Take note of the planned idle state. */
--
2.13.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpuidle: fix broadcast control when broadcast can not be entered
2017-09-01 4:29 [PATCH] cpuidle: fix broadcast control when broadcast can not be entered Nicholas Piggin
@ 2017-09-01 7:44 ` Thomas Gleixner
2017-10-03 0:31 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Gleixner @ 2017-09-01 7:44 UTC (permalink / raw)
To: Nicholas Piggin; +Cc: Rafael J. Wysocki, Daniel Lezcano, linux-pm, linux-kernel
On Fri, 1 Sep 2017, Nicholas Piggin wrote:
> When failing to enter broadcast timer mode for an idle state that
> requires it, a new state is selected that does not require broadcast,
> but the broadcast variable remains set. This causes
> tick_broadcast_exit to be called despite not having entered broadcast
> mode.
>
> This causes the WARN_ON_ONCE(!irqs_disabled()) to trigger in some
> cases. It does not appear to cause problems for code today, but seems
> to violate the interface so should be fixed.
>
> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> drivers/cpuidle/cpuidle.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index 60bb64f4329d..4453e27f855e 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -208,6 +208,7 @@ int cpuidle_enter_state(struct cpuidle_device *dev, struct cpuidle_driver *drv,
> return -EBUSY;
> }
> target_state = &drv->states[index];
> + broadcast = false;
> }
>
> /* Take note of the planned idle state. */
> --
> 2.13.3
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpuidle: fix broadcast control when broadcast can not be entered
2017-09-01 7:44 ` Thomas Gleixner
@ 2017-10-03 0:31 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2017-10-03 0:31 UTC (permalink / raw)
To: Thomas Gleixner, Nicholas Piggin
Cc: Rafael J. Wysocki, Daniel Lezcano, Linux PM,
Linux Kernel Mailing List
On Fri, Sep 1, 2017 at 9:44 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
> On Fri, 1 Sep 2017, Nicholas Piggin wrote:
>
>> When failing to enter broadcast timer mode for an idle state that
>> requires it, a new state is selected that does not require broadcast,
>> but the broadcast variable remains set. This causes
>> tick_broadcast_exit to be called despite not having entered broadcast
>> mode.
>>
>> This causes the WARN_ON_ONCE(!irqs_disabled()) to trigger in some
>> cases. It does not appear to cause problems for code today, but seems
>> to violate the interface so should be fixed.
>>
>> Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
>
> Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-10-03 0:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-01 4:29 [PATCH] cpuidle: fix broadcast control when broadcast can not be entered Nicholas Piggin
2017-09-01 7:44 ` Thomas Gleixner
2017-10-03 0:31 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox