* [PATCH] drivers/staging/rtl8188eu: cleanup crc32_init logic
@ 2017-09-07 4:50 Pushkar Jambhlekar
2017-09-07 9:33 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Pushkar Jambhlekar @ 2017-09-07 4:50 UTC (permalink / raw)
To: Greg Kroah-Hartman, Georgiana Rodica Chelu, William Blough,
Ivan Safonov, Yamanappagouda Patil, Pushkar Jambhlekar
Cc: devel, linux-kernel
crc32_init is using unnecessary else condition. Cleaningup this function
Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
---
drivers/staging/rtl8188eu/core/rtw_security.c | 42 +++++++++++++--------------
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
index b283a490..9d17204 100644
--- a/drivers/staging/rtl8188eu/core/rtw_security.c
+++ b/drivers/staging/rtl8188eu/core/rtw_security.c
@@ -94,29 +94,29 @@ static u8 crc32_reverseBit(u8 data)
static void crc32_init(void)
{
- if (bcrc32initialized == 1) {
+ if (bcrc32initialized == 1)
return;
- } else {
- int i, j;
- u32 c;
- u8 *p = (u8 *)&c, *p1;
- u8 k;
-
- c = 0x12340000;
-
- for (i = 0; i < 256; ++i) {
- k = crc32_reverseBit((u8)i);
- for (c = ((u32)k) << 24, j = 8; j > 0; --j)
- c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
- p1 = (u8 *)&crc32_table[i];
-
- p1[0] = crc32_reverseBit(p[3]);
- p1[1] = crc32_reverseBit(p[2]);
- p1[2] = crc32_reverseBit(p[1]);
- p1[3] = crc32_reverseBit(p[0]);
- }
- bcrc32initialized = 1;
+
+ int i, j;
+ u32 c;
+ u8 *p = (u8 *)&c, *p1;
+ u8 k;
+
+ c = 0x12340000;
+
+ for (i = 0; i < 256; ++i) {
+ k = crc32_reverseBit((u8)i);
+ for (c = ((u32)k) << 24, j = 8; j > 0; --j)
+ c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
+ p1 = (u8 *)&crc32_table[i];
+
+ p1[0] = crc32_reverseBit(p[3]);
+ p1[1] = crc32_reverseBit(p[2]);
+ p1[2] = crc32_reverseBit(p[1]);
+ p1[3] = crc32_reverseBit(p[0]);
}
+
+ bcrc32initialized = 1;
}
static __le32 getcrc32(u8 *buf, int len)
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drivers/staging/rtl8188eu: cleanup crc32_init logic
2017-09-07 4:50 [PATCH] drivers/staging/rtl8188eu: cleanup crc32_init logic Pushkar Jambhlekar
@ 2017-09-07 9:33 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2017-09-07 9:33 UTC (permalink / raw)
To: Pushkar Jambhlekar
Cc: Georgiana Rodica Chelu, William Blough, Ivan Safonov,
Yamanappagouda Patil, devel, linux-kernel
On Thu, Sep 07, 2017 at 10:20:52AM +0530, Pushkar Jambhlekar wrote:
> crc32_init is using unnecessary else condition. Cleaningup this function
>
> Signed-off-by: Pushkar Jambhlekar <pushkar.iit@gmail.com>
> ---
> drivers/staging/rtl8188eu/core/rtw_security.c | 42 +++++++++++++--------------
> 1 file changed, 21 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_security.c b/drivers/staging/rtl8188eu/core/rtw_security.c
> index b283a490..9d17204 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_security.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_security.c
> @@ -94,29 +94,29 @@ static u8 crc32_reverseBit(u8 data)
>
> static void crc32_init(void)
> {
> - if (bcrc32initialized == 1) {
> + if (bcrc32initialized == 1)
> return;
> - } else {
> - int i, j;
> - u32 c;
> - u8 *p = (u8 *)&c, *p1;
> - u8 k;
> -
> - c = 0x12340000;
> -
> - for (i = 0; i < 256; ++i) {
> - k = crc32_reverseBit((u8)i);
> - for (c = ((u32)k) << 24, j = 8; j > 0; --j)
> - c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
> - p1 = (u8 *)&crc32_table[i];
> -
> - p1[0] = crc32_reverseBit(p[3]);
> - p1[1] = crc32_reverseBit(p[2]);
> - p1[2] = crc32_reverseBit(p[1]);
> - p1[3] = crc32_reverseBit(p[0]);
> - }
> - bcrc32initialized = 1;
> +
> + int i, j;
> + u32 c;
> + u8 *p = (u8 *)&c, *p1;
> + u8 k;
> +
> + c = 0x12340000;
> +
> + for (i = 0; i < 256; ++i) {
> + k = crc32_reverseBit((u8)i);
> + for (c = ((u32)k) << 24, j = 8; j > 0; --j)
> + c = c & 0x80000000 ? (c << 1) ^ CRC32_POLY : (c << 1);
> + p1 = (u8 *)&crc32_table[i];
> +
> + p1[0] = crc32_reverseBit(p[3]);
> + p1[1] = crc32_reverseBit(p[2]);
> + p1[2] = crc32_reverseBit(p[1]);
> + p1[3] = crc32_reverseBit(p[0]);
> }
> +
> + bcrc32initialized = 1;
> }
>
> static __le32 getcrc32(u8 *buf, int len)
Always test build your code and ensure that you did not add any new
build warnings or errors :(
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-07 9:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-07 4:50 [PATCH] drivers/staging/rtl8188eu: cleanup crc32_init logic Pushkar Jambhlekar
2017-09-07 9:33 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox