* [PATCH] IB: INFINIBAND should depend on HAS_DMA
@ 2017-11-19 18:58 Geert Uytterhoeven
2017-11-21 6:06 ` Leon Romanovsky
2017-12-02 0:01 ` Jason Gunthorpe
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2017-11-19 18:58 UTC (permalink / raw)
To: Yuval Shaia, Doug Ledford, Jason Gunthorpe
Cc: linux-rdma, linux-kernel, Geert Uytterhoeven
If NO_DMA=y:
ERROR: "bad_dma_ops" [net/sunrpc/xprtrdma/rpcrdma.ko] undefined!
ERROR: "bad_dma_ops" [net/smc/smc.ko] undefined!
ERROR: "bad_dma_ops" [net/rds/rds_rdma.ko] undefined!
ERROR: "bad_dma_ops" [net/9p/9pnet_rdma.ko] undefined!
ERROR: "bad_dma_ops" [drivers/nvme/target/nvmet-rdma.ko] undefined!
ERROR: "bad_dma_ops" [drivers/nvme/host/nvme-rdma.ko] undefined!
ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srpt/ib_srpt.ko] undefined!
ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srp/ib_srp.ko] undefined!
ERROR: "bad_dma_ops" [drivers/infiniband/ulp/isert/ib_isert.ko] undefined!
ERROR: "bad_dma_ops" [drivers/infiniband/ulp/iser/ib_iser.ko] undefined!
ERROR: "bad_dma_ops" [drivers/infiniband/ulp/ipoib/ib_ipoib.ko] undefined!
ERROR: "bad_dma_ops" [drivers/infiniband/core/ib_core.ko] undefined!
Before, this was handled implicitly by the dependency on PCI.
Add an explicit dependency on HAS_DMA to fix this.
Fixes: 931bc0d91639f8fb ("IB: Move PCI dependency from root KConfig to HW's KConfigs")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/infiniband/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
index 98ac46ed7214f574..cbf186522016f97f 100644
--- a/drivers/infiniband/Kconfig
+++ b/drivers/infiniband/Kconfig
@@ -1,6 +1,6 @@
menuconfig INFINIBAND
tristate "InfiniBand support"
- depends on HAS_IOMEM
+ depends on HAS_IOMEM && HAS_DMA
depends on NET
depends on INET
depends on m || IPV6 != m
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] IB: INFINIBAND should depend on HAS_DMA
2017-11-19 18:58 [PATCH] IB: INFINIBAND should depend on HAS_DMA Geert Uytterhoeven
@ 2017-11-21 6:06 ` Leon Romanovsky
2017-12-02 0:01 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2017-11-21 6:06 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Yuval Shaia, Doug Ledford, Jason Gunthorpe, linux-rdma,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1372 bytes --]
On Sun, Nov 19, 2017 at 07:58:30PM +0100, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> ERROR: "bad_dma_ops" [net/sunrpc/xprtrdma/rpcrdma.ko] undefined!
> ERROR: "bad_dma_ops" [net/smc/smc.ko] undefined!
> ERROR: "bad_dma_ops" [net/rds/rds_rdma.ko] undefined!
> ERROR: "bad_dma_ops" [net/9p/9pnet_rdma.ko] undefined!
> ERROR: "bad_dma_ops" [drivers/nvme/target/nvmet-rdma.ko] undefined!
> ERROR: "bad_dma_ops" [drivers/nvme/host/nvme-rdma.ko] undefined!
> ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srpt/ib_srpt.ko] undefined!
> ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srp/ib_srp.ko] undefined!
> ERROR: "bad_dma_ops" [drivers/infiniband/ulp/isert/ib_isert.ko] undefined!
> ERROR: "bad_dma_ops" [drivers/infiniband/ulp/iser/ib_iser.ko] undefined!
> ERROR: "bad_dma_ops" [drivers/infiniband/ulp/ipoib/ib_ipoib.ko] undefined!
> ERROR: "bad_dma_ops" [drivers/infiniband/core/ib_core.ko] undefined!
>
> Before, this was handled implicitly by the dependency on PCI.
> Add an explicit dependency on HAS_DMA to fix this.
>
> Fixes: 931bc0d91639f8fb ("IB: Move PCI dependency from root KConfig to HW's KConfigs")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/infiniband/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: IB: INFINIBAND should depend on HAS_DMA
2017-11-19 18:58 [PATCH] IB: INFINIBAND should depend on HAS_DMA Geert Uytterhoeven
2017-11-21 6:06 ` Leon Romanovsky
@ 2017-12-02 0:01 ` Jason Gunthorpe
1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2017-12-02 0:01 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Yuval Shaia, Doug Ledford, linux-rdma, linux-kernel
On Sun, Nov 19, 2017 at 07:58:30PM +0100, Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> ERROR: "bad_dma_ops" [net/sunrpc/xprtrdma/rpcrdma.ko] undefined!
> ERROR: "bad_dma_ops" [net/smc/smc.ko] undefined!
> ERROR: "bad_dma_ops" [net/rds/rds_rdma.ko] undefined!
> ERROR: "bad_dma_ops" [net/9p/9pnet_rdma.ko] undefined!
> ERROR: "bad_dma_ops" [drivers/nvme/target/nvmet-rdma.ko] undefined!
> ERROR: "bad_dma_ops" [drivers/nvme/host/nvme-rdma.ko] undefined!
> ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srpt/ib_srpt.ko] undefined!
> ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srp/ib_srp.ko] undefined!
> ERROR: "bad_dma_ops" [drivers/infiniband/ulp/isert/ib_isert.ko] undefined!
> ERROR: "bad_dma_ops" [drivers/infiniband/ulp/iser/ib_iser.ko] undefined!
> ERROR: "bad_dma_ops" [drivers/infiniband/ulp/ipoib/ib_ipoib.ko] undefined!
> ERROR: "bad_dma_ops" [drivers/infiniband/core/ib_core.ko] undefined!
>
> Before, this was handled implicitly by the dependency on PCI.
> Add an explicit dependency on HAS_DMA to fix this.
>
> Fixes: 931bc0d91639f8fb ("IB: Move PCI dependency from root KConfig to HW's KConfigs")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
> drivers/infiniband/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-rc, thanks
Jason
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-12-02 0:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-19 18:58 [PATCH] IB: INFINIBAND should depend on HAS_DMA Geert Uytterhoeven
2017-11-21 6:06 ` Leon Romanovsky
2017-12-02 0:01 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox