* Re: + proc-fix-proc-net-after-setns2-checkpatch-fixes.patch added to -mm tree
[not found] <20190107223609.Z6BC6rJ1M%akpm@linux-foundation.org>
@ 2019-01-07 23:37 ` Alexey Dobriyan
2019-01-07 23:45 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2019-01-07 23:37 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel
On Mon, Jan 07, 2019 at 02:36:09PM -0800, akpm@linux-foundation.org wrote:
> Subject: proc-fix-proc-net-after-setns2-checkpatch-fixes
>
> WARNING: Block comments use * on subsequent lines
> #56: FILE: fs/proc/proc_net.c:44:
> + // /proc/net/* can be changed under us by setns(CLONE_NEWNET)
> + pde->proc_dops = &simple_dentry_operations;
I did it on purpose! Otherwise default vim colouring marks "/*" in red
because it is comment without "*/"
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: + proc-fix-proc-net-after-setns2-checkpatch-fixes.patch added to -mm tree
2019-01-07 23:37 ` + proc-fix-proc-net-after-setns2-checkpatch-fixes.patch added to -mm tree Alexey Dobriyan
@ 2019-01-07 23:45 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2019-01-07 23:45 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: linux-kernel
On Tue, 8 Jan 2019 02:37:20 +0300 Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Mon, Jan 07, 2019 at 02:36:09PM -0800, akpm@linux-foundation.org wrote:
> > Subject: proc-fix-proc-net-after-setns2-checkpatch-fixes
> >
> > WARNING: Block comments use * on subsequent lines
> > #56: FILE: fs/proc/proc_net.c:44:
> > + // /proc/net/* can be changed under us by setns(CLONE_NEWNET)
> > + pde->proc_dops = &simple_dentry_operations;
>
> I did it on purpose! Otherwise default vim colouring marks "/*" in red
> because it is comment without "*/"
There's always a way ;)
--- a/fs/proc/proc_net.c~proc-fix-proc-net-after-setns2-checkpatch-fixes-fix
+++ a/fs/proc/proc_net.c
@@ -40,7 +40,7 @@ static struct net *get_proc_net(const st
static void pde_force_lookup(struct proc_dir_entry *pde)
{
- /* /proc/net/* can be changed under us by setns(CLONE_NEWNET) */
+ /* /proc/net/ entries can be changed under us by setns(CLONE_NEWNET) */
pde->proc_dops = &simple_dentry_operations;
}
_
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-07 23:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20190107223609.Z6BC6rJ1M%akpm@linux-foundation.org>
2019-01-07 23:37 ` + proc-fix-proc-net-after-setns2-checkpatch-fixes.patch added to -mm tree Alexey Dobriyan
2019-01-07 23:45 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox