* [PATCH] PHY: Ingenic: compile phy-ingenic-usb only if it was enabled
@ 2021-01-23 15:01 Qiujun Huang
2021-01-24 8:36 ` Paul Cercueil
0 siblings, 1 reply; 2+ messages in thread
From: Qiujun Huang @ 2021-01-23 15:01 UTC (permalink / raw)
To: kishon, vkoul, zhouyanjie, aric.pzqi, paul, linux-kernel; +Cc: Qiujun Huang
We should compile this driver only if we opened PHY_INGENIC_USB.
Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
---
drivers/phy/ingenic/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/ingenic/Makefile b/drivers/phy/ingenic/Makefile
index 65d5ea00fc9d..a00306651423 100644
--- a/drivers/phy/ingenic/Makefile
+++ b/drivers/phy/ingenic/Makefile
@@ -1,2 +1,2 @@
# SPDX-License-Identifier: GPL-2.0
-obj-y += phy-ingenic-usb.o
+obj-$(PHY_INGENIC_USB) += phy-ingenic-usb.o
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PHY: Ingenic: compile phy-ingenic-usb only if it was enabled
2021-01-23 15:01 [PATCH] PHY: Ingenic: compile phy-ingenic-usb only if it was enabled Qiujun Huang
@ 2021-01-24 8:36 ` Paul Cercueil
0 siblings, 0 replies; 2+ messages in thread
From: Paul Cercueil @ 2021-01-24 8:36 UTC (permalink / raw)
To: Qiujun Huang; +Cc: kishon, vkoul, zhouyanjie, aric.pzqi, linux-kernel
Hi, thank you for your patch.
Le sam. 23 janv. 2021 à 23:01, Qiujun Huang <hqjagain@gmail.com> a
écrit :
> We should compile this driver only if we opened PHY_INGENIC_USB.
'opened' -> 'enable'.
> Signed-off-by: Qiujun Huang <hqjagain@gmail.com>
You will need to add a Fixes: tag and Cc linux-stable, since the
problem is already in 5.10.
Cheers,
-Paul
> ---
> drivers/phy/ingenic/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/phy/ingenic/Makefile
> b/drivers/phy/ingenic/Makefile
> index 65d5ea00fc9d..a00306651423 100644
> --- a/drivers/phy/ingenic/Makefile
> +++ b/drivers/phy/ingenic/Makefile
> @@ -1,2 +1,2 @@
> # SPDX-License-Identifier: GPL-2.0
> -obj-y += phy-ingenic-usb.o
> +obj-$(PHY_INGENIC_USB) += phy-ingenic-usb.o
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-01-24 8:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-23 15:01 [PATCH] PHY: Ingenic: compile phy-ingenic-usb only if it was enabled Qiujun Huang
2021-01-24 8:36 ` Paul Cercueil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox