* [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency
@ 2023-12-06 12:38 Arnd Bergmann
2023-12-06 17:22 ` Randy Dunlap
2023-12-07 11:53 ` Heikki Krogerus
0 siblings, 2 replies; 11+ messages in thread
From: Arnd Bergmann @ 2023-12-06 12:38 UTC (permalink / raw)
To: Heikki Krogerus, Greg Kroah-Hartman, Dmitry Baryshkov
Cc: Arnd Bergmann, Neil Armstrong, Bjorn Andersson, linux-usb,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
DRM_AUX_BRIDGE depends on CONFIG_OF, so the same dependency is needed
here to avoid a build failure:
WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE
Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
Selected by [y]:
- TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]
x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_register':
aux-bridge.c:(.text+0x13b): undefined reference to `auxiliary_device_init'
x86_64-linux-ld: aux-bridge.c:(.text+0x14d): undefined reference to `__auxiliary_device_add'
x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_init':
aux-bridge.c:(.init.text+0x15): undefined reference to `__auxiliary_driver_register'
x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_exit':
aux-bridge.c:(.exit.text+0x9): undefined reference to `auxiliary_driver_unregister'
Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/usb/typec/mux/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig
index 5120942f309d..818624f59120 100644
--- a/drivers/usb/typec/mux/Kconfig
+++ b/drivers/usb/typec/mux/Kconfig
@@ -40,6 +40,7 @@ config TYPEC_MUX_NB7VPQ904M
tristate "On Semiconductor NB7VPQ904M Type-C redriver driver"
depends on I2C
depends on DRM || DRM=n
+ depends on OF
select DRM_AUX_BRIDGE if DRM_BRIDGE
select REGMAP_I2C
help
--
2.39.2
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency
2023-12-06 12:38 [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency Arnd Bergmann
@ 2023-12-06 17:22 ` Randy Dunlap
2023-12-07 11:53 ` Heikki Krogerus
1 sibling, 0 replies; 11+ messages in thread
From: Randy Dunlap @ 2023-12-06 17:22 UTC (permalink / raw)
To: Arnd Bergmann, Heikki Krogerus, Greg Kroah-Hartman,
Dmitry Baryshkov
Cc: Arnd Bergmann, Neil Armstrong, Bjorn Andersson, linux-usb,
linux-kernel
On 12/6/23 04:38, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> DRM_AUX_BRIDGE depends on CONFIG_OF, so the same dependency is needed
> here to avoid a build failure:
>
> WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE
> Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
> Selected by [y]:
> - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]
> x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_register':
> aux-bridge.c:(.text+0x13b): undefined reference to `auxiliary_device_init'
> x86_64-linux-ld: aux-bridge.c:(.text+0x14d): undefined reference to `__auxiliary_device_add'
> x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_init':
> aux-bridge.c:(.init.text+0x15): undefined reference to `__auxiliary_driver_register'
> x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_exit':
> aux-bridge.c:(.exit.text+0x9): undefined reference to `auxiliary_driver_unregister'
>
> Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
> ---
> drivers/usb/typec/mux/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig
> index 5120942f309d..818624f59120 100644
> --- a/drivers/usb/typec/mux/Kconfig
> +++ b/drivers/usb/typec/mux/Kconfig
> @@ -40,6 +40,7 @@ config TYPEC_MUX_NB7VPQ904M
> tristate "On Semiconductor NB7VPQ904M Type-C redriver driver"
> depends on I2C
> depends on DRM || DRM=n
> + depends on OF
> select DRM_AUX_BRIDGE if DRM_BRIDGE
> select REGMAP_I2C
> help
--
~Randy
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency
2023-12-06 12:38 [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency Arnd Bergmann
2023-12-06 17:22 ` Randy Dunlap
@ 2023-12-07 11:53 ` Heikki Krogerus
2023-12-07 11:55 ` Dmitry Baryshkov
1 sibling, 1 reply; 11+ messages in thread
From: Heikki Krogerus @ 2023-12-07 11:53 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Greg Kroah-Hartman, Dmitry Baryshkov, Arnd Bergmann,
Neil Armstrong, Bjorn Andersson, linux-usb, linux-kernel
On Wed, Dec 06, 2023 at 01:38:14PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> DRM_AUX_BRIDGE depends on CONFIG_OF, so the same dependency is needed
> here to avoid a build failure:
>
> WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE
> Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
> Selected by [y]:
> - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]
> x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_register':
> aux-bridge.c:(.text+0x13b): undefined reference to `auxiliary_device_init'
> x86_64-linux-ld: aux-bridge.c:(.text+0x14d): undefined reference to `__auxiliary_device_add'
> x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_init':
> aux-bridge.c:(.init.text+0x15): undefined reference to `__auxiliary_driver_register'
> x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_exit':
> aux-bridge.c:(.exit.text+0x9): undefined reference to `auxiliary_driver_unregister'
>
> Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/usb/typec/mux/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig
> index 5120942f309d..818624f59120 100644
> --- a/drivers/usb/typec/mux/Kconfig
> +++ b/drivers/usb/typec/mux/Kconfig
> @@ -40,6 +40,7 @@ config TYPEC_MUX_NB7VPQ904M
> tristate "On Semiconductor NB7VPQ904M Type-C redriver driver"
> depends on I2C
> depends on DRM || DRM=n
> + depends on OF
> select DRM_AUX_BRIDGE if DRM_BRIDGE
> select REGMAP_I2C
> help
Shouldn't DRM_BRIDGE depend on OF instead?
thanks,
--
heikki
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency
2023-12-07 11:53 ` Heikki Krogerus
@ 2023-12-07 11:55 ` Dmitry Baryshkov
2023-12-07 11:57 ` Heikki Krogerus
0 siblings, 1 reply; 11+ messages in thread
From: Dmitry Baryshkov @ 2023-12-07 11:55 UTC (permalink / raw)
To: Heikki Krogerus
Cc: Arnd Bergmann, Greg Kroah-Hartman, Arnd Bergmann, Neil Armstrong,
Bjorn Andersson, linux-usb, linux-kernel
On Thu, 7 Dec 2023 at 13:53, Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> On Wed, Dec 06, 2023 at 01:38:14PM +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > DRM_AUX_BRIDGE depends on CONFIG_OF, so the same dependency is needed
> > here to avoid a build failure:
> >
> > WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE
> > Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
> > Selected by [y]:
> > - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]
> > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_register':
> > aux-bridge.c:(.text+0x13b): undefined reference to `auxiliary_device_init'
> > x86_64-linux-ld: aux-bridge.c:(.text+0x14d): undefined reference to `__auxiliary_device_add'
> > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_init':
> > aux-bridge.c:(.init.text+0x15): undefined reference to `__auxiliary_driver_register'
> > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_exit':
> > aux-bridge.c:(.exit.text+0x9): undefined reference to `auxiliary_driver_unregister'
> >
> > Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > drivers/usb/typec/mux/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig
> > index 5120942f309d..818624f59120 100644
> > --- a/drivers/usb/typec/mux/Kconfig
> > +++ b/drivers/usb/typec/mux/Kconfig
> > @@ -40,6 +40,7 @@ config TYPEC_MUX_NB7VPQ904M
> > tristate "On Semiconductor NB7VPQ904M Type-C redriver driver"
> > depends on I2C
> > depends on DRM || DRM=n
> > + depends on OF
> > select DRM_AUX_BRIDGE if DRM_BRIDGE
> > select REGMAP_I2C
> > help
>
> Shouldn't DRM_BRIDGE depend on OF instead?
No. DRM_AUX_BRIDGE depends on OF, DRM_BRIDGE framework doesn't.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency
2023-12-07 11:55 ` Dmitry Baryshkov
@ 2023-12-07 11:57 ` Heikki Krogerus
2023-12-07 11:58 ` Dmitry Baryshkov
2023-12-07 11:59 ` Arnd Bergmann
0 siblings, 2 replies; 11+ messages in thread
From: Heikki Krogerus @ 2023-12-07 11:57 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Arnd Bergmann, Greg Kroah-Hartman, Arnd Bergmann, Neil Armstrong,
Bjorn Andersson, linux-usb, linux-kernel
On Thu, Dec 07, 2023 at 01:55:06PM +0200, Dmitry Baryshkov wrote:
> On Thu, 7 Dec 2023 at 13:53, Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
> >
> > On Wed, Dec 06, 2023 at 01:38:14PM +0100, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@arndb.de>
> > >
> > > DRM_AUX_BRIDGE depends on CONFIG_OF, so the same dependency is needed
> > > here to avoid a build failure:
> > >
> > > WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE
> > > Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
> > > Selected by [y]:
> > > - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]
> > > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_register':
> > > aux-bridge.c:(.text+0x13b): undefined reference to `auxiliary_device_init'
> > > x86_64-linux-ld: aux-bridge.c:(.text+0x14d): undefined reference to `__auxiliary_device_add'
> > > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_init':
> > > aux-bridge.c:(.init.text+0x15): undefined reference to `__auxiliary_driver_register'
> > > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_exit':
> > > aux-bridge.c:(.exit.text+0x9): undefined reference to `auxiliary_driver_unregister'
> > >
> > > Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE")
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > ---
> > > drivers/usb/typec/mux/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig
> > > index 5120942f309d..818624f59120 100644
> > > --- a/drivers/usb/typec/mux/Kconfig
> > > +++ b/drivers/usb/typec/mux/Kconfig
> > > @@ -40,6 +40,7 @@ config TYPEC_MUX_NB7VPQ904M
> > > tristate "On Semiconductor NB7VPQ904M Type-C redriver driver"
> > > depends on I2C
> > > depends on DRM || DRM=n
> > > + depends on OF
> > > select DRM_AUX_BRIDGE if DRM_BRIDGE
> > > select REGMAP_I2C
> > > help
> >
> > Shouldn't DRM_BRIDGE depend on OF instead?
>
> No. DRM_AUX_BRIDGE depends on OF, DRM_BRIDGE framework doesn't.
Okay, so this probable should also be
select DRM_AUX_BRIDGE if DRM_BRIDGE and OF
No?
thanks,
--
heikki
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency
2023-12-07 11:57 ` Heikki Krogerus
@ 2023-12-07 11:58 ` Dmitry Baryshkov
2023-12-07 12:01 ` Heikki Krogerus
2023-12-07 11:59 ` Arnd Bergmann
1 sibling, 1 reply; 11+ messages in thread
From: Dmitry Baryshkov @ 2023-12-07 11:58 UTC (permalink / raw)
To: Heikki Krogerus
Cc: Arnd Bergmann, Greg Kroah-Hartman, Arnd Bergmann, Neil Armstrong,
Bjorn Andersson, linux-usb, linux-kernel
On Thu, 7 Dec 2023 at 13:57, Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> On Thu, Dec 07, 2023 at 01:55:06PM +0200, Dmitry Baryshkov wrote:
> > On Thu, 7 Dec 2023 at 13:53, Heikki Krogerus
> > <heikki.krogerus@linux.intel.com> wrote:
> > >
> > > On Wed, Dec 06, 2023 at 01:38:14PM +0100, Arnd Bergmann wrote:
> > > > From: Arnd Bergmann <arnd@arndb.de>
> > > >
> > > > DRM_AUX_BRIDGE depends on CONFIG_OF, so the same dependency is needed
> > > > here to avoid a build failure:
> > > >
> > > > WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE
> > > > Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
> > > > Selected by [y]:
> > > > - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]
> > > > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_register':
> > > > aux-bridge.c:(.text+0x13b): undefined reference to `auxiliary_device_init'
> > > > x86_64-linux-ld: aux-bridge.c:(.text+0x14d): undefined reference to `__auxiliary_device_add'
> > > > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_init':
> > > > aux-bridge.c:(.init.text+0x15): undefined reference to `__auxiliary_driver_register'
> > > > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_exit':
> > > > aux-bridge.c:(.exit.text+0x9): undefined reference to `auxiliary_driver_unregister'
> > > >
> > > > Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE")
> > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > > ---
> > > > drivers/usb/typec/mux/Kconfig | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig
> > > > index 5120942f309d..818624f59120 100644
> > > > --- a/drivers/usb/typec/mux/Kconfig
> > > > +++ b/drivers/usb/typec/mux/Kconfig
> > > > @@ -40,6 +40,7 @@ config TYPEC_MUX_NB7VPQ904M
> > > > tristate "On Semiconductor NB7VPQ904M Type-C redriver driver"
> > > > depends on I2C
> > > > depends on DRM || DRM=n
> > > > + depends on OF
> > > > select DRM_AUX_BRIDGE if DRM_BRIDGE
> > > > select REGMAP_I2C
> > > > help
> > >
> > > Shouldn't DRM_BRIDGE depend on OF instead?
> >
> > No. DRM_AUX_BRIDGE depends on OF, DRM_BRIDGE framework doesn't.
>
> Okay, so this probable should also be
>
> select DRM_AUX_BRIDGE if DRM_BRIDGE and OF
Yes, this is what a patch from Nathan does:
https://patchwork.freedesktop.org/patch/570638/?series=127385&rev=1
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency
2023-12-07 11:57 ` Heikki Krogerus
2023-12-07 11:58 ` Dmitry Baryshkov
@ 2023-12-07 11:59 ` Arnd Bergmann
2023-12-07 12:12 ` Dmitry Baryshkov
1 sibling, 1 reply; 11+ messages in thread
From: Arnd Bergmann @ 2023-12-07 11:59 UTC (permalink / raw)
To: Heikki Krogerus, Dmitry Baryshkov
Cc: Arnd Bergmann, Greg Kroah-Hartman, Neil Armstrong,
Bjorn Andersson, linux-usb, linux-kernel
On Thu, Dec 7, 2023, at 12:57, Heikki Krogerus wrote:
> On Thu, Dec 07, 2023 at 01:55:06PM +0200, Dmitry Baryshkov wrote:
> Okay, so this probable should also be
>
> select DRM_AUX_BRIDGE if DRM_BRIDGE and OF
>
> No?
I think that fails if CONFIG_OF is disabled and
CONFIG_DRM_AUX_BRIDGE, since drm_aux_bridge_register()
will still be called from a built-in driver in that
case but can't be linked against.
Arnd
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency
2023-12-07 11:58 ` Dmitry Baryshkov
@ 2023-12-07 12:01 ` Heikki Krogerus
0 siblings, 0 replies; 11+ messages in thread
From: Heikki Krogerus @ 2023-12-07 12:01 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Arnd Bergmann, Greg Kroah-Hartman, Arnd Bergmann, Neil Armstrong,
Bjorn Andersson, linux-usb, linux-kernel
On Thu, Dec 07, 2023 at 01:58:31PM +0200, Dmitry Baryshkov wrote:
> On Thu, 7 Dec 2023 at 13:57, Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
> >
> > On Thu, Dec 07, 2023 at 01:55:06PM +0200, Dmitry Baryshkov wrote:
> > > On Thu, 7 Dec 2023 at 13:53, Heikki Krogerus
> > > <heikki.krogerus@linux.intel.com> wrote:
> > > >
> > > > On Wed, Dec 06, 2023 at 01:38:14PM +0100, Arnd Bergmann wrote:
> > > > > From: Arnd Bergmann <arnd@arndb.de>
> > > > >
> > > > > DRM_AUX_BRIDGE depends on CONFIG_OF, so the same dependency is needed
> > > > > here to avoid a build failure:
> > > > >
> > > > > WARNING: unmet direct dependencies detected for DRM_AUX_BRIDGE
> > > > > Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n]
> > > > > Selected by [y]:
> > > > > - TYPEC_MUX_NB7VPQ904M [=y] && USB_SUPPORT [=y] && TYPEC [=y] && I2C [=y] && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y]
> > > > > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_register':
> > > > > aux-bridge.c:(.text+0x13b): undefined reference to `auxiliary_device_init'
> > > > > x86_64-linux-ld: aux-bridge.c:(.text+0x14d): undefined reference to `__auxiliary_device_add'
> > > > > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_init':
> > > > > aux-bridge.c:(.init.text+0x15): undefined reference to `__auxiliary_driver_register'
> > > > > x86_64-linux-ld: drivers/gpu/drm/bridge/aux-bridge.o: in function `drm_aux_bridge_drv_exit':
> > > > > aux-bridge.c:(.exit.text+0x9): undefined reference to `auxiliary_driver_unregister'
> > > > >
> > > > > Fixes: c5d296bad640 ("usb: typec: nb7vpq904m: switch to DRM_AUX_BRIDGE")
> > > > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > > > ---
> > > > > drivers/usb/typec/mux/Kconfig | 1 +
> > > > > 1 file changed, 1 insertion(+)
> > > > >
> > > > > diff --git a/drivers/usb/typec/mux/Kconfig b/drivers/usb/typec/mux/Kconfig
> > > > > index 5120942f309d..818624f59120 100644
> > > > > --- a/drivers/usb/typec/mux/Kconfig
> > > > > +++ b/drivers/usb/typec/mux/Kconfig
> > > > > @@ -40,6 +40,7 @@ config TYPEC_MUX_NB7VPQ904M
> > > > > tristate "On Semiconductor NB7VPQ904M Type-C redriver driver"
> > > > > depends on I2C
> > > > > depends on DRM || DRM=n
> > > > > + depends on OF
> > > > > select DRM_AUX_BRIDGE if DRM_BRIDGE
> > > > > select REGMAP_I2C
> > > > > help
> > > >
> > > > Shouldn't DRM_BRIDGE depend on OF instead?
> > >
> > > No. DRM_AUX_BRIDGE depends on OF, DRM_BRIDGE framework doesn't.
> >
> > Okay, so this probable should also be
> >
> > select DRM_AUX_BRIDGE if DRM_BRIDGE and OF
>
> Yes, this is what a patch from Nathan does:
> https://patchwork.freedesktop.org/patch/570638/?series=127385&rev=1
Ah, sorry about the noise.
thanks,
--
heikki
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency
2023-12-07 11:59 ` Arnd Bergmann
@ 2023-12-07 12:12 ` Dmitry Baryshkov
2023-12-07 12:17 ` Arnd Bergmann
0 siblings, 1 reply; 11+ messages in thread
From: Dmitry Baryshkov @ 2023-12-07 12:12 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Heikki Krogerus, Arnd Bergmann, Greg Kroah-Hartman,
Neil Armstrong, Bjorn Andersson, linux-usb, linux-kernel
On Thu, 7 Dec 2023 at 14:00, Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Thu, Dec 7, 2023, at 12:57, Heikki Krogerus wrote:
> > On Thu, Dec 07, 2023 at 01:55:06PM +0200, Dmitry Baryshkov wrote:
>
> > Okay, so this probable should also be
> >
> > select DRM_AUX_BRIDGE if DRM_BRIDGE and OF
> >
> > No?
>
> I think that fails if CONFIG_OF is disabled and
> CONFIG_DRM_AUX_BRIDGE, since drm_aux_bridge_register()
> will still be called from a built-in driver in that
> case but can't be linked against.
If DRM_AUX_BRIDGE is not enabled, then the stubs from
include/drm/bridge/aux-bridge will be used instead.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency
2023-12-07 12:12 ` Dmitry Baryshkov
@ 2023-12-07 12:17 ` Arnd Bergmann
2023-12-07 12:20 ` Dmitry Baryshkov
0 siblings, 1 reply; 11+ messages in thread
From: Arnd Bergmann @ 2023-12-07 12:17 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Heikki Krogerus, Arnd Bergmann, Greg Kroah-Hartman,
Neil Armstrong, Bjorn Andersson, linux-usb, linux-kernel
On Thu, Dec 7, 2023, at 13:12, Dmitry Baryshkov wrote:
> On Thu, 7 Dec 2023 at 14:00, Arnd Bergmann <arnd@arndb.de> wrote:
>>
>> On Thu, Dec 7, 2023, at 12:57, Heikki Krogerus wrote:
>> > On Thu, Dec 07, 2023 at 01:55:06PM +0200, Dmitry Baryshkov wrote:
>>
>> > Okay, so this probable should also be
>> >
>> > select DRM_AUX_BRIDGE if DRM_BRIDGE and OF
>> >
>> > No?
>>
>> I think that fails if CONFIG_OF is disabled and
>> CONFIG_DRM_AUX_BRIDGE, since drm_aux_bridge_register()
>> will still be called from a built-in driver in that
>> case but can't be linked against.
>
> If DRM_AUX_BRIDGE is not enabled, then the stubs from
> include/drm/bridge/aux-bridge will be used instead.
Sorry, I meant to write CONFIG_DRM_AUX_BRIDGE=m here.
Arnd
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency
2023-12-07 12:17 ` Arnd Bergmann
@ 2023-12-07 12:20 ` Dmitry Baryshkov
0 siblings, 0 replies; 11+ messages in thread
From: Dmitry Baryshkov @ 2023-12-07 12:20 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Heikki Krogerus, Arnd Bergmann, Greg Kroah-Hartman,
Neil Armstrong, Bjorn Andersson, linux-usb, linux-kernel
On Thu, 7 Dec 2023 at 14:17, Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Thu, Dec 7, 2023, at 13:12, Dmitry Baryshkov wrote:
> > On Thu, 7 Dec 2023 at 14:00, Arnd Bergmann <arnd@arndb.de> wrote:
> >>
> >> On Thu, Dec 7, 2023, at 12:57, Heikki Krogerus wrote:
> >> > On Thu, Dec 07, 2023 at 01:55:06PM +0200, Dmitry Baryshkov wrote:
> >>
> >> > Okay, so this probable should also be
> >> >
> >> > select DRM_AUX_BRIDGE if DRM_BRIDGE and OF
> >> >
> >> > No?
> >>
> >> I think that fails if CONFIG_OF is disabled and
> >> CONFIG_DRM_AUX_BRIDGE, since drm_aux_bridge_register()
> >> will still be called from a built-in driver in that
> >> case but can't be linked against.
> >
> > If DRM_AUX_BRIDGE is not enabled, then the stubs from
> > include/drm/bridge/aux-bridge will be used instead.
>
> Sorry, I meant to write CONFIG_DRM_AUX_BRIDGE=m here.
Like having NB7VPQ904M=y, OF=n and DRM_AUX_BRIDGE=m? And the select
will not work, since the condition is not fulfilled. Good question.
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2023-12-07 12:21 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-06 12:38 [PATCH] usb: typec: nb7vpq904m: add CONFIG_OF dependency Arnd Bergmann
2023-12-06 17:22 ` Randy Dunlap
2023-12-07 11:53 ` Heikki Krogerus
2023-12-07 11:55 ` Dmitry Baryshkov
2023-12-07 11:57 ` Heikki Krogerus
2023-12-07 11:58 ` Dmitry Baryshkov
2023-12-07 12:01 ` Heikki Krogerus
2023-12-07 11:59 ` Arnd Bergmann
2023-12-07 12:12 ` Dmitry Baryshkov
2023-12-07 12:17 ` Arnd Bergmann
2023-12-07 12:20 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox