[PATCH v1 1/1] media: i2c: ds90ub9x3: Remove unneeded of_gpio_n_cells assignment

[PATCH v1 1/1] media: i2c: ds90ub9x3: Remove unneeded of_gpio_n_cells assignment

[Andy Shevchenko]

The default for of_gpio_n_cells is 2, no need to assign the same
in the user.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/media/i2c/ds90ub913.c | 1 -
 drivers/media/i2c/ds90ub953.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/drivers/media/i2c/ds90ub913.c b/drivers/media/i2c/ds90ub913.c
index fd2d2d5272bf..834df8d508e6 100644
--- a/drivers/media/i2c/ds90ub913.c
+++ b/drivers/media/i2c/ds90ub913.c
@@ -216,7 +216,6 @@ static int ub913_gpiochip_probe(struct ub913_data *priv)
 	gc->direction_output = ub913_gpio_direction_out;
 	gc->set = ub913_gpio_set;
 	gc->of_xlate = ub913_gpio_of_xlate;
-	gc->of_gpio_n_cells = 2;
 
 	ret = gpiochip_add_data(gc, priv);
 	if (ret) {
diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c
index 46569381b332..1cd5ac7157e4 100644
--- a/drivers/media/i2c/ds90ub953.c
+++ b/drivers/media/i2c/ds90ub953.c
@@ -420,7 +420,6 @@ static int ub953_gpiochip_probe(struct ub953_data *priv)
 	gc->get = ub953_gpio_get;
 	gc->set = ub953_gpio_set;
 	gc->of_xlate = ub953_gpio_of_xlate;
-	gc->of_gpio_n_cells = 2;
 
 	ret = gpiochip_add_data(gc, priv);
 	if (ret) {
-- 
2.47.2

Re: [PATCH v1 1/1] media: i2c: ds90ub9x3: Remove unneeded of_gpio_n_cells assignment

[Tomi Valkeinen]

Hi,

On 31/03/2025 10:02, Andy Shevchenko wrote:
> The default for of_gpio_n_cells is 2, no need to assign the same
> in the user.

Where is this documented? I'm also having trouble finding the 
implementation.

  Tomi

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>   drivers/media/i2c/ds90ub913.c | 1 -
>   drivers/media/i2c/ds90ub953.c | 1 -
>   2 files changed, 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/ds90ub913.c b/drivers/media/i2c/ds90ub913.c
> index fd2d2d5272bf..834df8d508e6 100644
> --- a/drivers/media/i2c/ds90ub913.c
> +++ b/drivers/media/i2c/ds90ub913.c
> @@ -216,7 +216,6 @@ static int ub913_gpiochip_probe(struct ub913_data *priv)
>   	gc->direction_output = ub913_gpio_direction_out;
>   	gc->set = ub913_gpio_set;
>   	gc->of_xlate = ub913_gpio_of_xlate;
> -	gc->of_gpio_n_cells = 2;
>   
>   	ret = gpiochip_add_data(gc, priv);
>   	if (ret) {
> diff --git a/drivers/media/i2c/ds90ub953.c b/drivers/media/i2c/ds90ub953.c
> index 46569381b332..1cd5ac7157e4 100644
> --- a/drivers/media/i2c/ds90ub953.c
> +++ b/drivers/media/i2c/ds90ub953.c
> @@ -420,7 +420,6 @@ static int ub953_gpiochip_probe(struct ub953_data *priv)
>   	gc->get = ub953_gpio_get;
>   	gc->set = ub953_gpio_set;
>   	gc->of_xlate = ub953_gpio_of_xlate;
> -	gc->of_gpio_n_cells = 2;
>   
>   	ret = gpiochip_add_data(gc, priv);
>   	if (ret) {

Re: [PATCH v1 1/1] media: i2c: ds90ub9x3: Remove unneeded of_gpio_n_cells assignment

[Andy Shevchenko]

On Thu, Apr 03, 2025 at 11:07:40AM +0300, Tomi Valkeinen wrote:
> On 31/03/2025 10:02, Andy Shevchenko wrote:
> > The default for of_gpio_n_cells is 2, no need to assign the same
> > in the user.
> 
> Where is this documented? I'm also having trouble finding the
> implementation.

The idea was introduced back in 391c970c0dd1 ("of/gpio: add default of_xlate
function if device has a node pointer"). But now I realised that it was never
assumed that default is 2 for the cases when the ->of_xlate() explicitly
provided. So, this is wrong patch, thanks for the review!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] media: i2c: ds90ub9x3: Remove unneeded of_gpio_n_cells assignment

[Sakari Ailus]

Hi Andy, Tomi,

On Thu, Apr 03, 2025 at 01:58:10PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 03, 2025 at 11:07:40AM +0300, Tomi Valkeinen wrote:
> > On 31/03/2025 10:02, Andy Shevchenko wrote:
> > > The default for of_gpio_n_cells is 2, no need to assign the same
> > > in the user.
> > 
> > Where is this documented? I'm also having trouble finding the
> > implementation.
> 
> The idea was introduced back in 391c970c0dd1 ("of/gpio: add default of_xlate
> function if device has a node pointer"). But now I realised that it was never
> assumed that default is 2 for the cases when the ->of_xlate() explicitly
> provided. So, this is wrong patch, thanks for the review!

Does the same conclusion apply to the similar max96717 patch as well?

-- 
Sakari Ailus

Re: [PATCH v1 1/1] media: i2c: ds90ub9x3: Remove unneeded of_gpio_n_cells assignment

[Andy Shevchenko]

On Mon, May 05, 2025 at 08:17:47AM +0000, Sakari Ailus wrote:
> On Thu, Apr 03, 2025 at 01:58:10PM +0300, Andy Shevchenko wrote:
> > On Thu, Apr 03, 2025 at 11:07:40AM +0300, Tomi Valkeinen wrote:
> > > On 31/03/2025 10:02, Andy Shevchenko wrote:
> > > > The default for of_gpio_n_cells is 2, no need to assign the same
> > > > in the user.
> > > 
> > > Where is this documented? I'm also having trouble finding the
> > > implementation.
> > 
> > The idea was introduced back in 391c970c0dd1 ("of/gpio: add default of_xlate
> > function if device has a node pointer"). But now I realised that it was never
> > assumed that default is 2 for the cases when the ->of_xlate() explicitly
> > provided. So, this is wrong patch, thanks for the review!
> 
> Does the same conclusion apply to the similar max96717 patch as well?

If you are referring to
20250331070152.3985520-1-andriy.shevchenko@linux.intel.com
(and why not replying there?), then no, that change is correct.

-- 
With Best Regards,
Andy Shevchenko