* [PATCH] drm/bridge: analogix_dp: Extract error pointer from correct variable
@ 2026-04-29 3:08 Ethan Tidmore
2026-04-29 11:29 ` Luca Ceresoli
2026-05-04 7:02 ` Luca Ceresoli
0 siblings, 2 replies; 4+ messages in thread
From: Ethan Tidmore @ 2026-04-29 3:08 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Damon Ding
Cc: Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Luca Ceresoli, Dmitry Baryshkov, Heiko Stuebner,
Marek Szyprowski, dri-devel, linux-kernel, Ethan Tidmore
In devm_drm_panel_bridge_add() error path the pointer error should be
extracted from dp->plat_data->next_bridge but instead it is extracted
from bridge, which is a valid pointer and not part of this error path.
Extract error pointer from correct variable.
Detected by Smatch:
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1489 analogix_dp_bind()
warn: passing a valid pointer to 'PTR_ERR'
Fixes: 1b86a69b61df4 ("drm/bridge: analogix_dp: Apply panel_bridge helper")
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
---
drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
index 460729fdcecd..3e46350170d4 100644
--- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
+++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
@@ -1486,7 +1486,7 @@ int analogix_dp_bind(struct analogix_dp_device *dp, struct drm_device *drm_dev)
dp->plat_data->next_bridge = devm_drm_panel_bridge_add(dp->dev,
dp->plat_data->panel);
if (IS_ERR(dp->plat_data->next_bridge)) {
- ret = PTR_ERR(bridge);
+ ret = PTR_ERR(dp->plat_data->next_bridge);
goto err_unregister_aux;
}
}
--
2.54.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/bridge: analogix_dp: Extract error pointer from correct variable
2026-04-29 3:08 [PATCH] drm/bridge: analogix_dp: Extract error pointer from correct variable Ethan Tidmore
@ 2026-04-29 11:29 ` Luca Ceresoli
2026-04-30 1:08 ` Damon Ding
2026-05-04 7:02 ` Luca Ceresoli
1 sibling, 1 reply; 4+ messages in thread
From: Luca Ceresoli @ 2026-04-29 11:29 UTC (permalink / raw)
To: Ethan Tidmore, Andrzej Hajda, Neil Armstrong, Robert Foss,
Damon Ding
Cc: Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Dmitry Baryshkov, Heiko Stuebner, Marek Szyprowski,
dri-devel, linux-kernel
On Wed Apr 29, 2026 at 5:08 AM CEST, Ethan Tidmore wrote:
> In devm_drm_panel_bridge_add() error path the pointer error should be
> extracted from dp->plat_data->next_bridge but instead it is extracted
> from bridge, which is a valid pointer and not part of this error path.
>
> Extract error pointer from correct variable.
>
> Detected by Smatch:
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1489 analogix_dp_bind()
> warn: passing a valid pointer to 'PTR_ERR'
>
> Fixes: 1b86a69b61df4 ("drm/bridge: analogix_dp: Apply panel_bridge helper")
> Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/bridge: analogix_dp: Extract error pointer from correct variable
2026-04-29 11:29 ` Luca Ceresoli
@ 2026-04-30 1:08 ` Damon Ding
0 siblings, 0 replies; 4+ messages in thread
From: Damon Ding @ 2026-04-30 1:08 UTC (permalink / raw)
To: Luca Ceresoli, Ethan Tidmore, Andrzej Hajda, Neil Armstrong,
Robert Foss
Cc: Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Dmitry Baryshkov, Heiko Stuebner, Marek Szyprowski,
dri-devel, linux-kernel
On 4/29/2026 7:29 PM, Luca Ceresoli wrote:
> On Wed Apr 29, 2026 at 5:08 AM CEST, Ethan Tidmore wrote:
>> In devm_drm_panel_bridge_add() error path the pointer error should be
>> extracted from dp->plat_data->next_bridge but instead it is extracted
>> from bridge, which is a valid pointer and not part of this error path.
>>
>> Extract error pointer from correct variable.
>>
>> Detected by Smatch:
>> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1489 analogix_dp_bind()
>> warn: passing a valid pointer to 'PTR_ERR'
>>
>> Fixes: 1b86a69b61df4 ("drm/bridge: analogix_dp: Apply panel_bridge helper")
>> Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
>
Reviewed-by: Damon Ding <damon.ding@rock-chips.com>
Best regards,
Damon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: analogix_dp: Extract error pointer from correct variable
2026-04-29 3:08 [PATCH] drm/bridge: analogix_dp: Extract error pointer from correct variable Ethan Tidmore
2026-04-29 11:29 ` Luca Ceresoli
@ 2026-05-04 7:02 ` Luca Ceresoli
1 sibling, 0 replies; 4+ messages in thread
From: Luca Ceresoli @ 2026-05-04 7:02 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Damon Ding,
Ethan Tidmore
Cc: Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Simona Vetter, Dmitry Baryshkov, Heiko Stuebner, Marek Szyprowski,
dri-devel, linux-kernel
On Tue, 28 Apr 2026 22:08:40 -0500, Ethan Tidmore wrote:
> In devm_drm_panel_bridge_add() error path the pointer error should be
> extracted from dp->plat_data->next_bridge but instead it is extracted
> from bridge, which is a valid pointer and not part of this error path.
>
> Extract error pointer from correct variable.
>
> Detected by Smatch:
> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1489 analogix_dp_bind()
> warn: passing a valid pointer to 'PTR_ERR'
>
> [...]
Applied, thanks!
[1/1] drm/bridge: analogix_dp: Extract error pointer from correct variable
commit: 002ef4dc52dcc1dd0eb1556cffa8f02e2e7edd51
Best regards,
--
Luca Ceresoli <luca.ceresoli@bootlin.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-05-04 7:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-29 3:08 [PATCH] drm/bridge: analogix_dp: Extract error pointer from correct variable Ethan Tidmore
2026-04-29 11:29 ` Luca Ceresoli
2026-04-30 1:08 ` Damon Ding
2026-05-04 7:02 ` Luca Ceresoli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox