The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
	"Vlastimil Babka (SUSE)" <vbabka@kernel.org>,
	Lorenzo Stoakes <ljs@kernel.org>, Nico Pache <npache@redhat.com>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org, liam@infradead.org, mhocko@suse.com,
	rppt@kernel.org, vbabka@suse.cz, willy@infradead.org
Subject: Re: Process (was Re: [PATCH mm-hotfixes-unstable v18 00/14] khugepaged: add mTHP) collapse support
Date: Tue,  2 Jun 2026 18:48:40 -0700	[thread overview]
Message-ID: <20260603014841.90322-1-sj@kernel.org> (raw)
In-Reply-To: <58b45d62-37b3-4006-b738-08992f502b58@kernel.org>

On Tue, 2 Jun 2026 15:16:27 +0200 "David Hildenbrand (Arm)" <david@kernel.org> wrote:

> On 6/2/26 15:08, Vlastimil Babka (SUSE) wrote:
> > On 6/2/26 14:58, David Hildenbrand (Arm) wrote:
> >> On 6/2/26 14:47, Vlastimil Babka (SUSE) wrote:
> >>>
> >>> The problem is that the patches would not be applied on top of the
> >>> integration tree, so it doesn't make sense to base them on it in the first
> >>> place. Unless they target the next cycle, where the integration tree would
> >>> first become part of rc1, which would be the new base for all the
> >>> submaintainer trees.
> >> Why does that matter?
> > 
> > Well, as longs as there are no conflicts, it probably doesn't.
> 
> Yes.
> 
> > 
> >> For example, the slab-next tree gets merged into the mm-next tree. Submitter
> >> will send against mm-next.
> >>
> >> The slab maintainer will cherry-pick the patches on top of slab-next. From where
> >> they end up in mm-next.
> > 
> > Note slab-next itself might be a collection of topic branches and it might
> > be more flexible to create another topic branch (based on rc1) and merge it,
> > than apply stuff on top of a product of merging.
> 
> Right, and I assume that the maintainer would then either try to fix it up
> himself, or ask the submitter to base against a specific branch. (e.g., against
> another topic branch etc).

So I understand we agree we will allow peoplee to base their patches on
whatever makes sense.  I like this flexibility.  The slight difference I show
is that David suggests to use mm-next as the default baseline, and later rebase
on subcomponent tree if needed.  Meanwhile, some subcomponent maintainers think
the opposite direction make sense.  Submitter use the appropriate subcomponent
maintainer-suggested tree as the default, and the submaintainers handle merge
conflicts of their for-mm-next branch.

I think both could work, and we will learn from trying.

But from a subcomponent maintainer's persepctive, I was thnking our process
will be more like the second approach.  And I still slightly feeling that will
be simpler for at least a subcomponent maintainer.  Why I feel so is like
below.

In the first approach, as Vlastimil and David described already, there are
chances of conflicts at picking mm-next based submitter's patch on subcomponent
tree.  How frequenct and complex the conflicts will be is questionable.  But it
feels like I will have to deal it with submitters.  E.g., asking rebase to
submitters, like David mentioned.  I think some of submitters might not very
familiar with git and the mm process, so I feel it might be not very simple
always.

In the second appraoch, I expect less chances of conflicts when picking
submitter patches on subcomponent trees.  The subcomponent maintainer will
still get conflicts with mm-next and have to fix it.  But in this case, the
subcomponent maintainer will be able to do that nearly alone.  Or, they will
work with the mm-next maintainer and/or other subcomponent maintainers.  I
pretty suree the other maintainers will be familiar with git and the process.
So I expect less headaches.  Also, this kind of conflict resolving between
subcomponent maintainer and mm-next trees is samely required for the first
approach, anyway.

mm-next maintainer's perspective might see many different things, though.  I
will be more than glad to be learn what I'm missing and get enlightened.

Anyway I think both approaches may work, and we can learn from others and
trying on our own.  I will be happy to help when there is something that I can
help. :)


Thanks,
SJ

[...]

  reply	other threads:[~2026-06-03  1:48 UTC|newest]

Thread overview: 111+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22 14:59 [PATCH mm-hotfixes-unstable v18 00/14] khugepaged: add mTHP collapse support Nico Pache
2026-05-22 14:59 ` [PATCH mm-unstable v18 01/14] mm/khugepaged: generalize hugepage_vma_revalidate for mTHP support Nico Pache
2026-05-22 14:59 ` [PATCH mm-unstable v18 02/14] mm/khugepaged: generalize alloc_charge_folio() Nico Pache
2026-05-22 14:59 ` [PATCH mm-unstable v18 03/14] mm/khugepaged: rework max_ptes_* handling with helper functions Nico Pache
2026-05-22 21:16   ` David Hildenbrand (Arm)
2026-06-01 13:26   ` Lorenzo Stoakes
2026-05-22 14:59 ` [PATCH mm-unstable v18 04/14] mm/khugepaged: generalize __collapse_huge_page_* for mTHP support Nico Pache
2026-05-22 21:24   ` David Hildenbrand (Arm)
2026-05-26 14:39   ` Nico Pache
2026-06-01 14:04   ` Lorenzo Stoakes
2026-05-22 15:00 ` [PATCH mm-unstable v18 05/14] mm/khugepaged: require collapse_huge_page to enter/exit with the lock dropped Nico Pache
2026-06-01 14:07   ` Lorenzo Stoakes
2026-06-02 10:26     ` Nico Pache
2026-05-22 15:00 ` [PATCH mm-unstable v18 06/14] mm/khugepaged: generalize collapse_huge_page for mTHP collapse Nico Pache
2026-05-22 21:47   ` David Hildenbrand (Arm)
2026-05-26 14:42   ` Nico Pache
2026-05-31  9:39   ` Lance Yang
2026-05-31 20:00     ` David Hildenbrand (Arm)
2026-06-01  3:28       ` Lance Yang
2026-06-01  6:54         ` David Hildenbrand (Arm)
2026-06-01  7:49           ` Lance Yang
2026-06-01  8:15             ` David Hildenbrand (Arm)
2026-06-01  8:44               ` Lance Yang
2026-06-01 10:09                 ` David Hildenbrand (Arm)
2026-06-01  9:08           ` Lance Yang
2026-06-01 10:23             ` David Hildenbrand (Arm)
2026-06-01 10:47               ` Lance Yang
2026-06-01 11:13                 ` David Hildenbrand (Arm)
2026-06-01 15:00                   ` Nico Pache
2026-06-01 15:05                     ` David Hildenbrand (Arm)
2026-06-01 16:07                       ` Lance Yang
2026-06-02 15:30                 ` Nico Pache
2026-06-02 16:34                   ` Lance Yang
2026-05-22 15:00 ` [PATCH mm-unstable v18 07/14] mm/khugepaged: skip collapsing mTHP to smaller orders Nico Pache
2026-05-22 21:51   ` David Hildenbrand (Arm)
2026-05-22 15:00 ` [PATCH mm-unstable v18 08/14] mm/khugepaged: add per-order mTHP collapse failure statistics Nico Pache
2026-05-31 20:09   ` David Hildenbrand (Arm)
2026-06-01 14:13   ` Lorenzo Stoakes
2026-05-22 15:00 ` [PATCH mm-unstable v18 09/14] mm/khugepaged: improve tracepoints for mTHP orders Nico Pache
2026-05-22 15:00 ` [PATCH mm-unstable v18 10/14] mm/khugepaged: introduce collapse_allowable_orders helper function Nico Pache
2026-05-31 20:18   ` David Hildenbrand (Arm)
2026-06-01 14:35     ` Lorenzo Stoakes
2026-06-01 14:40       ` David Hildenbrand (Arm)
2026-05-22 15:00 ` [PATCH mm-unstable v18 11/14] mm/khugepaged: Introduce mTHP collapse support Nico Pache
2026-05-25 14:15   ` Nico Pache
2026-05-25 19:10     ` Andrew Morton
2026-05-26  6:57       ` Wei Yang
2026-05-26 12:07         ` Nico Pache
2026-05-28  8:42           ` Wei Yang
2026-05-28 17:11             ` Nico Pache
2026-05-31  7:18   ` Lance Yang
2026-05-31  8:48     ` Lance Yang
2026-06-01 12:01       ` Nico Pache
2026-06-01 12:06         ` David Hildenbrand (Arm)
2026-06-02 10:58     ` Nico Pache
2026-06-02 15:44       ` Lance Yang
2026-06-01  8:11   ` David Hildenbrand (Arm)
2026-06-01 12:40     ` Nico Pache
2026-06-01 13:15       ` David Hildenbrand (Arm)
2026-06-02 17:23         ` Nico Pache
2026-06-02 17:26           ` Nico Pache
2026-05-22 15:00 ` [PATCH mm-unstable v18 12/14] mm/khugepaged: avoid unnecessary mTHP collapse attempts Nico Pache
2026-05-31  7:31   ` Lance Yang
2026-05-31 20:02     ` David Hildenbrand (Arm)
2026-06-01  1:53       ` Lance Yang
2026-05-22 15:00 ` [PATCH mm-unstable v18 13/14] mm/khugepaged: run khugepaged for all orders Nico Pache
2026-05-22 15:00 ` [PATCH mm-unstable v18 14/14] Documentation: mm: update the admin guide for mTHP collapse Nico Pache
2026-05-22 21:58   ` David Hildenbrand (Arm)
2026-05-26 12:00     ` Nico Pache
2026-05-26 14:45   ` Nico Pache
2026-05-22 15:07 ` [PATCH mm-hotfixes-unstable v18 00/14] khugepaged: add mTHP collapse support Nico Pache
2026-05-22 15:13   ` Vlastimil Babka (SUSE)
2026-05-22 16:11     ` Nico Pache
2026-05-22 21:13       ` David Hildenbrand (Arm)
2026-05-26  8:33         ` Process (was Re: [PATCH mm-hotfixes-unstable v18 00/14] khugepaged: add mTHP) " Lorenzo Stoakes
2026-05-26 19:09           ` Andrew Morton
2026-05-26 20:42           ` Vlastimil Babka (SUSE)
2026-05-31 19:49             ` David Hildenbrand (Arm)
2026-06-01 15:41               ` Lorenzo Stoakes
2026-06-01 15:45                 ` David Hildenbrand (Arm)
2026-06-01 16:16                   ` Lorenzo Stoakes
2026-06-02 11:20                     ` David Hildenbrand (Arm)
2026-06-02 11:31                       ` David Hildenbrand (Arm)
2026-06-02 12:47                         ` Lorenzo Stoakes
2026-06-02 12:55                         ` Vlastimil Babka (SUSE)
2026-06-02 13:01                           ` David Hildenbrand (Arm)
2026-06-02 17:31                           ` Mike Rapoport
2026-06-03  6:48                             ` Lorenzo Stoakes
2026-06-02 12:40                       ` Lorenzo Stoakes
2026-06-02 12:49                         ` David Hildenbrand (Arm)
2026-06-02 12:47                       ` Vlastimil Babka (SUSE)
2026-06-02 12:58                         ` David Hildenbrand (Arm)
2026-06-02 13:08                           ` Vlastimil Babka (SUSE)
2026-06-02 13:16                             ` David Hildenbrand (Arm)
2026-06-03  1:48                               ` SeongJae Park [this message]
2026-06-01 15:37             ` Lorenzo Stoakes
2026-06-01 15:43               ` David Hildenbrand (Arm)
2026-06-01 15:47                 ` Lorenzo Stoakes
2026-06-01 16:00                   ` David Hildenbrand (Arm)
2026-05-22 15:16   ` [PATCH mm-hotfixes-unstable v18 00/14] khugepaged: add mTHP " Lorenzo Stoakes
2026-05-22 16:08     ` Nico Pache
2026-05-22 16:19       ` Lorenzo Stoakes
2026-05-22 16:31         ` Nico Pache
2026-05-22 17:12           ` Lorenzo Stoakes
2026-05-26  8:14             ` Lorenzo Stoakes
2026-05-22 15:13 ` Lorenzo Stoakes
2026-05-22 20:47 ` Andrew Morton
2026-06-01 15:58   ` Alexander Gordeev
2026-06-01 17:05     ` Nico Pache
2026-06-01 17:08     ` Lorenzo Stoakes
2026-06-02  1:53       ` Lance Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260603014841.90322-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=npache@redhat.com \
    --cc=rppt@kernel.org \
    --cc=vbabka@kernel.org \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox