The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Lorenzo Stoakes <ljs@kernel.org>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>,
	 Nico Pache <npache@redhat.com>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	 linux-mm@kvack.org, liam@infradead.org, mhocko@suse.com,
	rppt@kernel.org,  vbabka@suse.cz, willy@infradead.org
Subject: Re: Process (was Re: [PATCH mm-hotfixes-unstable v18 00/14] khugepaged: add mTHP) collapse support
Date: Mon, 1 Jun 2026 17:16:00 +0100	[thread overview]
Message-ID: <ah2uDhs3a0bFcRNG@lucifer> (raw)
In-Reply-To: <506fed6b-8954-40fa-8b5e-c8bd8c0d004b@kernel.org>

On Mon, Jun 01, 2026 at 05:45:30PM +0200, David Hildenbrand (Arm) wrote:
> On 6/1/26 17:41, Lorenzo Stoakes wrote:
> > On Sun, May 31, 2026 at 09:49:02PM +0200, David Hildenbrand (Arm) wrote:
> >>>
> >>>
> >>> This I'm not so sure how it would work. Assuming we have submaintainers with
> >>> their trees and branches, the final "stable branch" is merged from those.
> >>> But it's not a good base for work targeting the same merge window, as that
> >>> work would likely go to one of those submaintainer trees. But then it can't
> >>> be based on the result of merge of all submaintainer trees. That could only
> >>> work for patches targetting the next cycle (after the stable branch becomes
> >>> part of rc1).
> >>>
> >>> So either patches can be based on rc1 and applied as topic branches in a
> >>> submaintainer tree and then merged, or if they really depend on something
> >>> already in a submaintainer tree, then based on the respective topic branch
> >>> that's part of it.
> >>
> >> Right, most patches can be sent against the "stable branch", but cherry-picked
> >> on a submaintainers branch / topic tree.
> >
> > I think life will be easier with submaintainer separate trees for this honestly
> > :) or it could become a horrible mess in one tree I think.
>
> Requiring contributors to submit stuff targeted at some random trees is madness :)

Err what? The 'random' tree is the MAINTAINERS entry you are targeting, it's
based on the mm-next stable branch and only diverges in the work that's been
done specific to the subtree, what's crazy exactly?

I mean, is there any meaning to separate 'trees' at all if we just have one tree
with topic branches in?

Or are we going to have several parallel stable branches in one tree, and a
bunch of maintainers with write access stepping on each other's toes?

That sounds a lot more crazy to me, and I just don't think it's workable.
>
> >
> > I think the simplest is what I suggested in reply to Vlasta, where each
> > submaintainer tree has their own set of changes against mm-next/mm-stable and
> > then we merge each week.
>
> Throw in hotfixes and it already starts being crazy.

Again I really don't understand this?

Hotfixes are a completely separate topic for one, I'm talking about ordinary
development, but surely they're simpler aren't they?

Everything's based on Linus's tree (so no confusion as to which tree), there
shouldn't (hopefully) be a huge amount of them, and submaintainers can just
potentially find a way to send them direct to mm-next anyway?

>
> >
> > But am open to learning about what other subsystems in the kernel do...
>
> The TIP tree has a pretty elaborate model of dealing with topic branches, and
> don't require things to be sent against specific topic branches.
>
> I'll try to understand that model.

OK well, interested to hear about that.

But also we should adapt what others do (which I think is very important to
learn from obviously) against how mm works in practice.

High review load with many overlapping changes might favour a different approach
to a subsystem that looks different from that.

>
> --
> Cheers,
>
> David

Thanks, Lorenzo

  reply	other threads:[~2026-06-01 16:16 UTC|newest]

Thread overview: 89+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22 14:59 [PATCH mm-hotfixes-unstable v18 00/14] khugepaged: add mTHP collapse support Nico Pache
2026-05-22 14:59 ` [PATCH mm-unstable v18 01/14] mm/khugepaged: generalize hugepage_vma_revalidate for mTHP support Nico Pache
2026-05-22 14:59 ` [PATCH mm-unstable v18 02/14] mm/khugepaged: generalize alloc_charge_folio() Nico Pache
2026-05-22 14:59 ` [PATCH mm-unstable v18 03/14] mm/khugepaged: rework max_ptes_* handling with helper functions Nico Pache
2026-05-22 21:16   ` David Hildenbrand (Arm)
2026-06-01 13:26   ` Lorenzo Stoakes
2026-05-22 14:59 ` [PATCH mm-unstable v18 04/14] mm/khugepaged: generalize __collapse_huge_page_* for mTHP support Nico Pache
2026-05-22 21:24   ` David Hildenbrand (Arm)
2026-05-26 14:39   ` Nico Pache
2026-06-01 14:04   ` Lorenzo Stoakes
2026-05-22 15:00 ` [PATCH mm-unstable v18 05/14] mm/khugepaged: require collapse_huge_page to enter/exit with the lock dropped Nico Pache
2026-06-01 14:07   ` Lorenzo Stoakes
2026-05-22 15:00 ` [PATCH mm-unstable v18 06/14] mm/khugepaged: generalize collapse_huge_page for mTHP collapse Nico Pache
2026-05-22 21:47   ` David Hildenbrand (Arm)
2026-05-26 14:42   ` Nico Pache
2026-05-31  9:39   ` Lance Yang
2026-05-31 20:00     ` David Hildenbrand (Arm)
2026-06-01  3:28       ` Lance Yang
2026-06-01  6:54         ` David Hildenbrand (Arm)
2026-06-01  7:49           ` Lance Yang
2026-06-01  8:15             ` David Hildenbrand (Arm)
2026-06-01  8:44               ` Lance Yang
2026-06-01 10:09                 ` David Hildenbrand (Arm)
2026-06-01  9:08           ` Lance Yang
2026-06-01 10:23             ` David Hildenbrand (Arm)
2026-06-01 10:47               ` Lance Yang
2026-06-01 11:13                 ` David Hildenbrand (Arm)
2026-06-01 15:00                   ` Nico Pache
2026-06-01 15:05                     ` David Hildenbrand (Arm)
2026-06-01 16:07                       ` Lance Yang
2026-05-22 15:00 ` [PATCH mm-unstable v18 07/14] mm/khugepaged: skip collapsing mTHP to smaller orders Nico Pache
2026-05-22 21:51   ` David Hildenbrand (Arm)
2026-05-22 15:00 ` [PATCH mm-unstable v18 08/14] mm/khugepaged: add per-order mTHP collapse failure statistics Nico Pache
2026-05-31 20:09   ` David Hildenbrand (Arm)
2026-06-01 14:13   ` Lorenzo Stoakes
2026-05-22 15:00 ` [PATCH mm-unstable v18 09/14] mm/khugepaged: improve tracepoints for mTHP orders Nico Pache
2026-05-22 15:00 ` [PATCH mm-unstable v18 10/14] mm/khugepaged: introduce collapse_allowable_orders helper function Nico Pache
2026-05-31 20:18   ` David Hildenbrand (Arm)
2026-06-01 14:35     ` Lorenzo Stoakes
2026-06-01 14:40       ` David Hildenbrand (Arm)
2026-05-22 15:00 ` [PATCH mm-unstable v18 11/14] mm/khugepaged: Introduce mTHP collapse support Nico Pache
2026-05-25 14:15   ` Nico Pache
2026-05-25 19:10     ` Andrew Morton
2026-05-26  6:57       ` Wei Yang
2026-05-26 12:07         ` Nico Pache
2026-05-28  8:42           ` Wei Yang
2026-05-28 17:11             ` Nico Pache
2026-05-31  7:18   ` Lance Yang
2026-05-31  8:48     ` Lance Yang
2026-06-01 12:01       ` Nico Pache
2026-06-01 12:06         ` David Hildenbrand (Arm)
2026-06-01  8:11   ` David Hildenbrand (Arm)
2026-06-01 12:40     ` Nico Pache
2026-06-01 13:15       ` David Hildenbrand (Arm)
2026-05-22 15:00 ` [PATCH mm-unstable v18 12/14] mm/khugepaged: avoid unnecessary mTHP collapse attempts Nico Pache
2026-05-31  7:31   ` Lance Yang
2026-05-31 20:02     ` David Hildenbrand (Arm)
2026-06-01  1:53       ` Lance Yang
2026-05-22 15:00 ` [PATCH mm-unstable v18 13/14] mm/khugepaged: run khugepaged for all orders Nico Pache
2026-05-22 15:00 ` [PATCH mm-unstable v18 14/14] Documentation: mm: update the admin guide for mTHP collapse Nico Pache
2026-05-22 21:58   ` David Hildenbrand (Arm)
2026-05-26 12:00     ` Nico Pache
2026-05-26 14:45   ` Nico Pache
2026-05-22 15:07 ` [PATCH mm-hotfixes-unstable v18 00/14] khugepaged: add mTHP collapse support Nico Pache
2026-05-22 15:13   ` Vlastimil Babka (SUSE)
2026-05-22 16:11     ` Nico Pache
2026-05-22 21:13       ` David Hildenbrand (Arm)
2026-05-26  8:33         ` Process (was Re: [PATCH mm-hotfixes-unstable v18 00/14] khugepaged: add mTHP) " Lorenzo Stoakes
2026-05-26 19:09           ` Andrew Morton
2026-05-26 20:42           ` Vlastimil Babka (SUSE)
2026-05-31 19:49             ` David Hildenbrand (Arm)
2026-06-01 15:41               ` Lorenzo Stoakes
2026-06-01 15:45                 ` David Hildenbrand (Arm)
2026-06-01 16:16                   ` Lorenzo Stoakes [this message]
2026-06-01 15:37             ` Lorenzo Stoakes
2026-06-01 15:43               ` David Hildenbrand (Arm)
2026-06-01 15:47                 ` Lorenzo Stoakes
2026-06-01 16:00                   ` David Hildenbrand (Arm)
2026-05-22 15:16   ` [PATCH mm-hotfixes-unstable v18 00/14] khugepaged: add mTHP " Lorenzo Stoakes
2026-05-22 16:08     ` Nico Pache
2026-05-22 16:19       ` Lorenzo Stoakes
2026-05-22 16:31         ` Nico Pache
2026-05-22 17:12           ` Lorenzo Stoakes
2026-05-26  8:14             ` Lorenzo Stoakes
2026-05-22 15:13 ` Lorenzo Stoakes
2026-05-22 20:47 ` Andrew Morton
2026-06-01 15:58   ` Alexander Gordeev
2026-06-01 17:05     ` Nico Pache
2026-06-01 17:08     ` Lorenzo Stoakes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ah2uDhs3a0bFcRNG@lucifer \
    --to=ljs@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=david@kernel.org \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=npache@redhat.com \
    --cc=rppt@kernel.org \
    --cc=vbabka@kernel.org \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox