From: Christoph Hellwig <hch@lst.de>
To: guzebing <guzebing1612@gmail.com>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
axboe@kernel.dk, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
Guzebing <guzebing@bytedance.com>
Subject: Re: [PATCH] nvme: make firmware activation poll interval configurable
Date: Mon, 13 Jul 2026 08:45:01 +0200 [thread overview]
Message-ID: <20260713064501.GF29416@lst.de> (raw)
In-Reply-To: <12726bc4-33ce-4602-b2a9-46885f2af1fe@gmail.com>
On Fri, Jul 10, 2026 at 05:20:56PM +0800, guzebing wrote:
> > nvme_wait_ready() has a similar polling loop on the csts register, but
> > it does a udelay_range for 1-2 msecs no matter what the ready timeout
> > is. Maybe just do the same for consistency?
>
> Keith, using the same 1-2 ms sleep range as nvme_wait_ready() looks
> simpler to me as well.
Let's go for that then.
prev parent reply other threads:[~2026-07-13 6:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-27 1:06 [PATCH] nvme: make firmware activation poll interval configurable guzebing
2026-07-06 6:33 ` guzebing
2026-07-09 6:42 ` Christoph Hellwig
2026-07-09 9:06 ` guzebing
2026-07-09 15:07 ` Keith Busch
2026-07-10 9:20 ` guzebing
2026-07-13 6:45 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713064501.GF29416@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=guzebing1612@gmail.com \
--cc=guzebing@bytedance.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox