From: Thomas Huth <thuth@redhat.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
Giovanni Cabiddu <giovanni.cabiddu@intel.com>,
qat-linux@intel.com
Cc: Eric Biggers <ebiggers@kernel.org>
Subject: [PATCH v3 08/10] crypto: qat - zeroize crypto_aes_ctx with __cleanup(aes_zeroize_ctx)
Date: Wed, 5 Aug 2026 13:57:46 +0200 [thread overview]
Message-ID: <20260805115749.392672-9-thuth@redhat.com> (raw)
In-Reply-To: <20260805115749.392672-1-thuth@redhat.com>
From: Thomas Huth <thuth@redhat.com>
A recent patch by Giovanni Cabiddu already added a memzero_explicit()
for the crypto_aes_ctx in the qat_alg_xts_reverse_key() function,
but since we introduced __cleanup(aes_zeroize_ctx) markers in previous
commits in many spots of the code already, let's use it here now, too,
to have the same code pattern everywhere.
Cc: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
drivers/crypto/intel/qat/qat_common/qat_algs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/crypto/intel/qat/qat_common/qat_algs.c b/drivers/crypto/intel/qat/qat_common/qat_algs.c
index 91663805d9e60..cb669fb661625 100644
--- a/drivers/crypto/intel/qat/qat_common/qat_algs.c
+++ b/drivers/crypto/intel/qat/qat_common/qat_algs.c
@@ -388,7 +388,7 @@ static void qat_alg_skcipher_init_enc(struct qat_alg_skcipher_ctx *ctx,
static void qat_alg_xts_reverse_key(const u8 *key_forward, unsigned int keylen,
u8 *key_reverse)
{
- struct crypto_aes_ctx aes_expanded;
+ struct crypto_aes_ctx aes_expanded __cleanup(aes_zeroize_ctx);
int nrounds;
u8 *key;
@@ -405,7 +405,6 @@ static void qat_alg_xts_reverse_key(const u8 *key_forward, unsigned int keylen,
memcpy(key_reverse + AES_BLOCK_SIZE, key - AES_BLOCK_SIZE,
AES_BLOCK_SIZE);
}
- memzero_explicit(&aes_expanded, sizeof(aes_expanded));
}
static void qat_alg_skcipher_init_dec(struct qat_alg_skcipher_ctx *ctx,
--
2.55.0
next prev parent reply other threads:[~2026-08-05 11:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 11:57 [PATCH v3 00/10] crypto: Provide a function for zeroizing crypto_aes_ctx Thomas Huth
2026-08-05 11:57 ` [PATCH v3 01/10] crypto: Provide a wrapper " Thomas Huth
2026-08-05 11:57 ` [PATCH v3 02/10] crypto: aspeed - clear the crypto_aes_ctx when done Thomas Huth
2026-08-05 11:57 ` [PATCH v3 03/10] crypto: inside-secure/eip93 " Thomas Huth
2026-08-05 11:57 ` [PATCH v3 04/10] crypto: padlock-aes " Thomas Huth
2026-08-05 11:57 ` [PATCH v3 05/10] crypto: sa2ul " Thomas Huth
2026-08-05 11:57 ` [PATCH v3 06/10] crypto: arm/aes-neonbs " Thomas Huth
2026-08-05 11:57 ` [PATCH v3 07/10] crypto: arm64/aes-neonbs " Thomas Huth
2026-08-05 11:57 ` Thomas Huth [this message]
2026-08-05 11:57 ` [PATCH v3 09/10] crypto: safexcel - Rework cleanup of sensitive structs in safexcel_aead_setkey Thomas Huth
2026-08-06 8:10 ` Antoine Tenart
2026-08-06 8:18 ` Thomas Huth
2026-08-06 12:37 ` Antoine Tenart
2026-08-05 11:57 ` [PATCH v3 10/10] crypto: safexcel - zeroize crypto_aes_ctx with __cleanup(aes_zeroize_ctx) Thomas Huth
2026-08-06 8:17 ` Antoine Tenart
2026-08-05 20:22 ` [PATCH v3 00/10] crypto: Provide a function for zeroizing crypto_aes_ctx Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260805115749.392672-9-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=davem@davemloft.net \
--cc=ebiggers@kernel.org \
--cc=giovanni.cabiddu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qat-linux@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox