* [PATCH v18 0/3] Add i2c-mux and eeprom devices for Meta Yosemite4
@ 2024-09-09 10:54 Delphine CC Chiu
2024-09-09 10:54 ` [PATCH v18 1/3] ARM: dts: aspeed: yosemite4: Revise i2c-mux devices Delphine CC Chiu
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Delphine CC Chiu @ 2024-09-09 10:54 UTC (permalink / raw)
To: patrick
Cc: Ricky CX Wu, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel
From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
Changelog:
- v18
- Fix warnings for reg_format reporting by dts checking tool.
- v17
- Add SoB for the patches.
- v16
- Reorganized the patches.
- Add i2c-mux and resolve the dt-validate errors.
- Revise Yosemite 4 devicetree for devices behind i2c-mux.
- Add mctp config and sensors for NIC after i2c-mux on bus 15.
- Add fan led config for BMC to control according the status of fan.
- v15
- Add ISL28022 support
- v14
- Add SQ52205 support
- Add GPIO I6 pin
- v13
- Add RTQ6056-support-on-bus-11
- v12
- Fix GPIO linename typo and add missing GPIO pin initial state.
- v11
- Revise all GPIO line name with bottom line
- v10
- adjust mgm cpld ioexp bus
- add GPIOO7 name
- remove mctp driver
- v9
- add XDP710 support
- add RTQ6056 support
- add MP5990 support
- v8
- add fan led config
- v7
- Revise pca9506 i2c address
- v6
- Revise i2c duty-cycle for meeting 400khz spec
- v5
- Support medusa board adc sensors
- support NIC eeprom
- v4
- Re-format gpio linename
- Revise i2c device node names
- Split patches by logic changes
- v3
- Correct patch for revising gpio name
- v2
- Revise mx31790 fan tach config
- Add mctp config for NIC
- Support mux to cpld
- Revise gpio name
- v1
- Add gpio and eeprom behind i2c-mux
- Remove redundant idle-state setting for i2c-mux
- Enable adc 15, wdt2,spi gpio for yosemite4 use
- Revise quad mode to dual mode to avoid WP pin influnece the SPI
- Revise power sensor adm1281 for yosemite4 schematic change
- Add gpio pca9506 I/O expander for yosemite4 use
- remove space for adm1272 compatible
- enable interrupt setting for pca9555
- add eeprom for yosemite4 medusa board/BSM use
- remove temperature sensor for yosemite4 schematic change
- add power sensor for power module reading
- Revise adc128d818 adc mode for yosemite4 schematic change
- Revise ina233 for yosemite4 schematic change
- Remove idle state setting for yosemite4 NIC connection
- Initialize bmc gpio state
- Revise mx31790 fan tach config
- Add mctp config for NIC
- Support mux to cpld
- Revise gpio name
Ricky CX Wu (3):
ARM: dts: aspeed: yosemite4: Revise i2c-mux devices
ARM: dts: aspeed: yosemite4: add mctp config and sensors for NIC
ARM: dts: aspeed: yosemite4: add fan led config
.../aspeed/aspeed-bmc-facebook-yosemite4.dts | 706 ++++++++++++++++--
1 file changed, 660 insertions(+), 46 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v18 1/3] ARM: dts: aspeed: yosemite4: Revise i2c-mux devices
2024-09-09 10:54 [PATCH v18 0/3] Add i2c-mux and eeprom devices for Meta Yosemite4 Delphine CC Chiu
@ 2024-09-09 10:54 ` Delphine CC Chiu
2024-09-09 10:54 ` [PATCH v18 2/3] ARM: dts: aspeed: yosemite4: add mctp config and sensors for NIC Delphine CC Chiu
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Delphine CC Chiu @ 2024-09-09 10:54 UTC (permalink / raw)
To: patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery
Cc: Ricky CX Wu, Delphine CC Chiu, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel
From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
Revise Yosemite 4 devicetree for devices behind i2c-mux
- Add gpio and eeprom behind i2c-mux
- Remove redundant idle-state setting for i2c-mux
- Revise address of max31790 devices after i2c-mux.
- Fix warnings reporting by dts checking tool.
Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
---
.../aspeed/aspeed-bmc-facebook-yosemite4.dts | 480 ++++++++++++++++--
1 file changed, 437 insertions(+), 43 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
index 98477792aa00..bed6bf695496 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
@@ -17,6 +17,29 @@ aliases {
serial6 = &uart7;
serial7 = &uart8;
serial8 = &uart9;
+
+ i2c16 = &imux16;
+ i2c17 = &imux17;
+ i2c18 = &imux18;
+ i2c19 = &imux19;
+ i2c20 = &imux20;
+ i2c21 = &imux21;
+ i2c22 = &imux22;
+ i2c23 = &imux23;
+ i2c24 = &imux24;
+ i2c25 = &imux25;
+ i2c26 = &imux26;
+ i2c27 = &imux27;
+ i2c28 = &imux28;
+ i2c29 = &imux29;
+ i2c30 = &imux30;
+ i2c31 = &imux31;
+ i2c32 = &imux32;
+ i2c33 = &imux33;
+ i2c34 = &imux34;
+ i2c35 = &imux35;
+ i2c36 = &imux36;
+ i2c37 = &imux37;
};
chosen {
@@ -255,41 +278,328 @@ power-sensor@40 {
};
&i2c8 {
+ #address-cells = <1>;
+ #size-cells = <0>;
status = "okay";
bus-frequency = <400000>;
i2c-mux@70 {
compatible = "nxp,pca9544";
- idle-state = <0>;
- i2c-mux-idle-disconnect;
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0x70>;
+ i2c-mux-idle-disconnect;
+
+ imux16: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+
+ gpio@49 {
+ compatible = "nxp,pca9537";
+ reg = <0x49>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ eeprom@50 {
+ compatible = "atmel,24c128";
+ reg = <0x50>;
+ };
+
+ eeprom@51 {
+ compatible = "atmel,24c128";
+ reg = <0x51>;
+ };
+
+ eeprom@54 {
+ compatible = "atmel,24c128";
+ reg = <0x54>;
+ };
+ };
+
+ imux17: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ gpio@49 {
+ compatible = "nxp,pca9537";
+ reg = <0x49>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ eeprom@50 {
+ compatible = "atmel,24c128";
+ reg = <0x50>;
+ };
+
+ eeprom@51 {
+ compatible = "atmel,24c128";
+ reg = <0x51>;
+ };
+
+ eeprom@54 {
+ compatible = "atmel,24c128";
+ reg = <0x54>;
+ };
+ };
+
+ imux18: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ gpio@49 {
+ compatible = "nxp,pca9537";
+ reg = <0x49>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ eeprom@50 {
+ compatible = "atmel,24c128";
+ reg = <0x50>;
+ };
+
+ eeprom@51 {
+ compatible = "atmel,24c128";
+ reg = <0x51>;
+ };
+
+ eeprom@54 {
+ compatible = "atmel,24c128";
+ reg = <0x54>;
+ };
+ };
+
+ imux19: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ gpio@49 {
+ compatible = "nxp,pca9537";
+ reg = <0x49>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ eeprom@50 {
+ compatible = "atmel,24c128";
+ reg = <0x50>;
+ };
+
+ eeprom@51 {
+ compatible = "atmel,24c128";
+ reg = <0x51>;
+ };
+
+ eeprom@54 {
+ compatible = "atmel,24c128";
+ reg = <0x54>;
+ };
+ };
};
};
&i2c9 {
+ #address-cells = <1>;
+ #size-cells = <0>;
status = "okay";
bus-frequency = <400000>;
i2c-mux@71 {
compatible = "nxp,pca9544";
- idle-state = <0>;
- i2c-mux-idle-disconnect;
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0x71>;
+ i2c-mux-idle-disconnect;
+
+ imux20: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ gpio@49 {
+ compatible = "nxp,pca9537";
+ reg = <0x49>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ eeprom@50 {
+ compatible = "atmel,24c128";
+ reg = <0x50>;
+ };
+
+ eeprom@51 {
+ compatible = "atmel,24c128";
+ reg = <0x51>;
+ };
+
+ eeprom@54 {
+ compatible = "atmel,24c128";
+ reg = <0x54>;
+ };
+ };
+
+ imux21: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ gpio@49 {
+ compatible = "nxp,pca9537";
+ reg = <0x49>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ eeprom@50 {
+ compatible = "atmel,24c128";
+ reg = <0x50>;
+ };
+
+ eeprom@51 {
+ compatible = "atmel,24c128";
+ reg = <0x51>;
+ };
+
+ eeprom@54 {
+ compatible = "atmel,24c128";
+ reg = <0x54>;
+ };
+ };
+
+ imux22: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ gpio@49 {
+ compatible = "nxp,pca9537";
+ reg = <0x49>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ eeprom@50 {
+ compatible = "atmel,24c128";
+ reg = <0x50>;
+ };
+
+ eeprom@51 {
+ compatible = "atmel,24c128";
+ reg = <0x51>;
+ };
+
+ eeprom@54 {
+ compatible = "atmel,24c128";
+ reg = <0x54>;
+ };
+ };
+
+ imux23: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+
+ gpio@49 {
+ compatible = "nxp,pca9537";
+ reg = <0x49>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ eeprom@50 {
+ compatible = "atmel,24c128";
+ reg = <0x50>;
+ };
+
+ eeprom@51 {
+ compatible = "atmel,24c128";
+ reg = <0x51>;
+ };
+
+ eeprom@54 {
+ compatible = "atmel,24c128";
+ reg = <0x54>;
+ };
+ };
};
};
&i2c10 {
+ #address-cells = <1>;
+ #size-cells = <0>;
status = "okay";
bus-frequency = <400000>;
+ i2c-mux@74 {
+ compatible = "nxp,pca9544";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x74>;
+ i2c-mux-idle-disconnect;
+
+ imux28: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+
+ gpio@20 {
+ compatible = "nxp,pca9506";
+ reg = <0x20>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ gpio@21 {
+ compatible = "nxp,pca9506";
+ reg = <0x21>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ gpio@22 {
+ compatible = "nxp,pca9506";
+ reg = <0x22>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ gpio@23 {
+ compatible = "nxp,pca9506";
+ reg = <0x23>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
+ gpio@24 {
+ compatible = "nxp,pca9506";
+ reg = <0x24>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ gpio-line-names =
+ "","","","",
+ "NIC0_MAIN_PWR_EN","NIC1_MAIN_PWR_EN",
+ "NIC2_MAIN_PWR_EN","NIC3_MAIN_PWR_EN",
+ "","","","","","","","",
+ "","","","","","","","",
+ "","","","","","","","";
+ };
+ };
+
+ imux29: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+ };
};
&i2c11 {
status = "okay";
power-sensor@10 {
- compatible = "adi, adm1272";
+ compatible = "adi,adm1272";
reg = <0x10>;
};
power-sensor@12 {
- compatible = "adi, adm1272";
+ compatible = "adi,adm1272";
reg = <0x12>;
};
@@ -348,22 +658,61 @@ eeprom@54 {
};
&i2c12 {
+ #address-cells = <1>;
+ #size-cells = <0>;
status = "okay";
bus-frequency = <400000>;
- temperature-sensor@48 {
- compatible = "ti,tmp75";
- reg = <0x48>;
- };
+ i2c-mux@70 {
+ compatible = "nxp,pca9544";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0x70>;
+ i2c-mux-idle-disconnect;
- eeprom@50 {
- compatible = "atmel,24c128";
- reg = <0x50>;
- };
+ imux34: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
- rtc@6f {
- compatible = "nuvoton,nct3018y";
- reg = <0x6f>;
+ temperature-sensor@48 {
+ compatible = "ti,tmp75";
+ reg = <0x48>;
+ };
+
+ eeprom@50 {
+ compatible = "atmel,24c128";
+ reg = <0x50>;
+ };
+
+ eeprom@54 {
+ compatible = "atmel,24c64";
+ reg = <0x54>;
+ };
+
+ rtc@6f {
+ compatible = "nuvoton,nct3018y";
+ reg = <0x6f>;
+ };
+ };
+
+ imux35: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ };
+
+ imux36: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ };
+
+ imux37: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ };
};
};
@@ -380,6 +729,8 @@ ipmb@10 {
};
&i2c14 {
+ #address-cells = <1>;
+ #size-cells = <0>;
status = "okay";
bus-frequency = <400000>;
adc@1d {
@@ -440,16 +791,14 @@ eeprom@51 {
reg = <0x51>;
};
- i2c-mux@71 {
- compatible = "nxp,pca9846";
+ i2c-mux@74 {
+ compatible = "nxp,pca9546";
#address-cells = <1>;
#size-cells = <0>;
-
- idle-state = <0>;
i2c-mux-idle-disconnect;
- reg = <0x71>;
+ reg = <0x74>;
- i2c@0 {
+ imux30: i2c@0 {
#address-cells = <1>;
#size-cells = <0>;
reg = <0>;
@@ -457,11 +806,11 @@ i2c@0 {
adc@1f {
compatible = "ti,adc128d818";
reg = <0x1f>;
- ti,mode = /bits/ 8 <2>;
+ ti,mode = /bits/ 8 <1>;
};
pwm@20{
- compatible = "max31790";
+ compatible = "maxim,max31790";
reg = <0x20>;
#address-cells = <1>;
#size-cells = <0>;
@@ -470,11 +819,13 @@ pwm@20{
gpio@22{
compatible = "ti,tca6424";
reg = <0x22>;
+ gpio-controller;
+ #gpio-cells = <2>;
};
- pwm@23{
- compatible = "max31790";
- reg = <0x23>;
+ pwm@2f{
+ compatible = "maxim,max31790";
+ reg = <0x2f>;
#address-cells = <1>;
#size-cells = <0>;
};
@@ -499,19 +850,19 @@ gpio@61 {
};
};
- i2c@1 {
+ imux31: i2c@1 {
#address-cells = <1>;
#size-cells = <0>;
- reg = <0>;
+ reg = <1>;
adc@1f {
compatible = "ti,adc128d818";
reg = <0x1f>;
- ti,mode = /bits/ 8 <2>;
+ ti,mode = /bits/ 8 <1>;
};
pwm@20{
- compatible = "max31790";
+ compatible = "maxim,max31790";
reg = <0x20>;
#address-cells = <1>;
#size-cells = <0>;
@@ -520,11 +871,13 @@ pwm@20{
gpio@22{
compatible = "ti,tca6424";
reg = <0x22>;
+ gpio-controller;
+ #gpio-cells = <2>;
};
- pwm@23{
- compatible = "max31790";
- reg = <0x23>;
+ pwm@2f{
+ compatible = "maxim,max31790";
+ reg = <0x2f>;
#address-cells = <1>;
#size-cells = <0>;
};
@@ -554,12 +907,10 @@ i2c-mux@73 {
compatible = "nxp,pca9544";
#address-cells = <1>;
#size-cells = <0>;
-
- idle-state = <0>;
- i2c-mux-idle-disconnect;
reg = <0x73>;
+ i2c-mux-idle-disconnect;
- i2c@0 {
+ imux32: i2c@0 {
#address-cells = <1>;
#size-cells = <0>;
reg = <0>;
@@ -570,10 +921,10 @@ adc@35 {
};
};
- i2c@1 {
+ imux33: i2c@1 {
#address-cells = <1>;
#size-cells = <0>;
- reg = <0>;
+ reg = <1>;
adc@35 {
compatible = "maxim,max11617";
@@ -584,6 +935,8 @@ adc@35 {
};
&i2c15 {
+ #address-cells = <1>;
+ #size-cells = <0>;
status = "okay";
mctp-controller;
multi-master;
@@ -596,9 +949,50 @@ mctp@10 {
i2c-mux@72 {
compatible = "nxp,pca9544";
- idle-state = <0>;
- i2c-mux-idle-disconnect;
+ #address-cells = <1>;
+ #size-cells = <0>;
reg = <0x72>;
+ i2c-mux-idle-disconnect;
+
+ imux24: i2c@0 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <0>;
+ temperature-sensor@1f {
+ compatible = "ti,tmp421";
+ reg = <0x1f>;
+ };
+ };
+
+ imux25: i2c@1 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <1>;
+ temperature-sensor@1f {
+ compatible = "ti,tmp421";
+ reg = <0x1f>;
+ };
+ };
+
+ imux26: i2c@2 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <2>;
+ temperature-sensor@1f {
+ compatible = "ti,tmp421";
+ reg = <0x1f>;
+ };
+ };
+
+ imux27: i2c@3 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ reg = <3>;
+ temperature-sensor@1f {
+ compatible = "ti,tmp421";
+ reg = <0x1f>;
+ };
+ };
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v18 2/3] ARM: dts: aspeed: yosemite4: add mctp config and sensors for NIC
2024-09-09 10:54 [PATCH v18 0/3] Add i2c-mux and eeprom devices for Meta Yosemite4 Delphine CC Chiu
2024-09-09 10:54 ` [PATCH v18 1/3] ARM: dts: aspeed: yosemite4: Revise i2c-mux devices Delphine CC Chiu
@ 2024-09-09 10:54 ` Delphine CC Chiu
2024-09-09 10:54 ` [PATCH v18 3/3] ARM: dts: aspeed: yosemite4: add fan led config Delphine CC Chiu
2024-09-09 15:45 ` [PATCH v18 0/3] Add i2c-mux and eeprom devices for Meta Yosemite4 Rob Herring (Arm)
3 siblings, 0 replies; 7+ messages in thread
From: Delphine CC Chiu @ 2024-09-09 10:54 UTC (permalink / raw)
To: patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery
Cc: Ricky CX Wu, Delphine CC Chiu, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel
From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
- Add MCTP config for NIC and remove the unnecessary MCTP config on bus
15.
- Add 2nd source temperature sensors EMC1403 for NIC.
- Add eeprom for NIC.
Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
---
.../aspeed/aspeed-bmc-facebook-yosemite4.dts | 49 ++++++++++++++++++-
1 file changed, 48 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
index bed6bf695496..7898c4c94b9f 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
@@ -938,7 +938,6 @@ &i2c15 {
#address-cells = <1>;
#size-cells = <0>;
status = "okay";
- mctp-controller;
multi-master;
bus-frequency = <400000>;
@@ -958,40 +957,88 @@ imux24: i2c@0 {
#address-cells = <1>;
#size-cells = <0>;
reg = <0>;
+ mctp-controller;
+
temperature-sensor@1f {
compatible = "ti,tmp421";
reg = <0x1f>;
};
+
+ temperature-sensor@3c {
+ compatible = "smsc,emc1403";
+ reg = <0x3c>;
+ };
+
+ eeprom@50 {
+ compatible = "atmel,24c64";
+ reg = <0x50>;
+ };
};
imux25: i2c@1 {
#address-cells = <1>;
#size-cells = <0>;
reg = <1>;
+ mctp-controller;
+
temperature-sensor@1f {
compatible = "ti,tmp421";
reg = <0x1f>;
};
+
+ temperature-sensor@3c {
+ compatible = "smsc,emc1403";
+ reg = <0x3c>;
+ };
+
+ eeprom@50 {
+ compatible = "atmel,24c64";
+ reg = <0x50>;
+ };
};
imux26: i2c@2 {
#address-cells = <1>;
#size-cells = <0>;
reg = <2>;
+ mctp-controller;
+
temperature-sensor@1f {
compatible = "ti,tmp421";
reg = <0x1f>;
};
+
+ temperature-sensor@3c {
+ compatible = "smsc,emc1403";
+ reg = <0x3c>;
+ };
+
+ eeprom@50 {
+ compatible = "atmel,24c64";
+ reg = <0x50>;
+ };
};
imux27: i2c@3 {
#address-cells = <1>;
#size-cells = <0>;
reg = <3>;
+ mctp-controller;
+
temperature-sensor@1f {
compatible = "ti,tmp421";
reg = <0x1f>;
};
+
+ temperature-sensor@3c {
+ compatible = "smsc,emc1403";
+ reg = <0x3c>;
+ };
+
+ eeprom@50 {
+ compatible = "atmel,24c64";
+ reg = <0x50>;
+ };
};
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v18 3/3] ARM: dts: aspeed: yosemite4: add fan led config
2024-09-09 10:54 [PATCH v18 0/3] Add i2c-mux and eeprom devices for Meta Yosemite4 Delphine CC Chiu
2024-09-09 10:54 ` [PATCH v18 1/3] ARM: dts: aspeed: yosemite4: Revise i2c-mux devices Delphine CC Chiu
2024-09-09 10:54 ` [PATCH v18 2/3] ARM: dts: aspeed: yosemite4: add mctp config and sensors for NIC Delphine CC Chiu
@ 2024-09-09 10:54 ` Delphine CC Chiu
2024-09-09 15:45 ` [PATCH v18 0/3] Add i2c-mux and eeprom devices for Meta Yosemite4 Rob Herring (Arm)
3 siblings, 0 replies; 7+ messages in thread
From: Delphine CC Chiu @ 2024-09-09 10:54 UTC (permalink / raw)
To: patrick, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Joel Stanley, Andrew Jeffery
Cc: Ricky CX Wu, Delphine CC Chiu, devicetree, linux-arm-kernel,
linux-aspeed, linux-kernel
From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
Set fan led config in yosemite4 DTS so that BMC could set different
color LED according to the status of the Fan.
Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
---
.../aspeed/aspeed-bmc-facebook-yosemite4.dts | 177 +++++++++++++++++-
1 file changed, 175 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
index 7898c4c94b9f..5399fe22e3ae 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
@@ -4,6 +4,7 @@
/dts-v1/;
#include "aspeed-g6.dtsi"
#include <dt-bindings/gpio/aspeed-gpio.h>
+#include <dt-bindings/leds/common.h>
#include <dt-bindings/leds/leds-pca955x.h>
#include <dt-bindings/i2c/i2c.h>
@@ -57,6 +58,178 @@ iio-hwmon {
<&adc0 4>, <&adc0 5>, <&adc0 6>, <&adc0 7>,
<&adc1 0>, <&adc1 1>;
};
+
+ leds {
+ compatible = "gpio-leds";
+
+ led-fan0-blue {
+ color = <LED_COLOR_ID_BLUE>;
+ retain-state-shutdown;
+ default-state = "on";
+ gpios = <&led_gpio0 4 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan0-amber {
+ color = <LED_COLOR_ID_AMBER>;
+ retain-state-shutdown;
+ default-state = "off";
+ gpios = <&led_gpio0 5 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan1-blue {
+ color = <LED_COLOR_ID_BLUE>;
+ retain-state-shutdown;
+ default-state = "on";
+ gpios = <&led_gpio0 10 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan1-amber {
+ color = <LED_COLOR_ID_AMBER>;
+ retain-state-shutdown;
+ default-state = "off";
+ gpios = <&led_gpio0 11 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan2-blue {
+ color = <LED_COLOR_ID_BLUE>;
+ retain-state-shutdown;
+ default-state = "on";
+ gpios = <&led_gpio1 4 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan2-amber {
+ color = <LED_COLOR_ID_AMBER>;
+ retain-state-shutdown;
+ default-state = "off";
+ gpios = <&led_gpio1 5 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan3-blue {
+ color = <LED_COLOR_ID_BLUE>;
+ retain-state-shutdown;
+ default-state = "on";
+ gpios = <&led_gpio1 10 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan3-amber {
+ color = <LED_COLOR_ID_AMBER>;
+ retain-state-shutdown;
+ default-state = "off";
+ gpios = <&led_gpio1 11 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan4-blue {
+ color = <LED_COLOR_ID_BLUE>;
+ retain-state-shutdown;
+ default-state = "on";
+ gpios = <&led_gpio0 2 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan4-amber {
+ color = <LED_COLOR_ID_AMBER>;
+ retain-state-shutdown;
+ default-state = "off";
+ gpios = <&led_gpio0 3 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan5-blue {
+ color = <LED_COLOR_ID_BLUE>;
+ retain-state-shutdown;
+ default-state = "on";
+ gpios = <&led_gpio0 8 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan5-amber {
+ color = <LED_COLOR_ID_AMBER>;
+ retain-state-shutdown;
+ default-state = "off";
+ gpios = <&led_gpio0 9 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan6-blue {
+ color = <LED_COLOR_ID_BLUE>;
+ retain-state-shutdown;
+ default-state = "on";
+ gpios = <&led_gpio1 2 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan6-amber {
+ color = <LED_COLOR_ID_AMBER>;
+ retain-state-shutdown;
+ default-state = "off";
+ gpios = <&led_gpio1 3 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan7-blue {
+ color = <LED_COLOR_ID_BLUE>;
+ retain-state-shutdown;
+ default-state = "on";
+ gpios = <&led_gpio1 8 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan7-amber {
+ color = <LED_COLOR_ID_AMBER>;
+ retain-state-shutdown;
+ default-state = "off";
+ gpios = <&led_gpio1 9 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan8-blue {
+ color = <LED_COLOR_ID_BLUE>;
+ retain-state-shutdown;
+ default-state = "on";
+ gpios = <&led_gpio0 0 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan8-amber {
+ color = <LED_COLOR_ID_AMBER>;
+ retain-state-shutdown;
+ default-state = "off";
+ gpios = <&led_gpio0 1 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan9-blue {
+ color = <LED_COLOR_ID_BLUE>;
+ retain-state-shutdown;
+ default-state = "on";
+ gpios = <&led_gpio0 6 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan9-amber {
+ color = <LED_COLOR_ID_AMBER>;
+ retain-state-shutdown;
+ default-state = "off";
+ gpios = <&led_gpio0 7 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan10-blue {
+ color = <LED_COLOR_ID_BLUE>;
+ retain-state-shutdown;
+ default-state = "on";
+ gpios = <&led_gpio1 0 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan10-amber {
+ color = <LED_COLOR_ID_AMBER>;
+ retain-state-shutdown;
+ default-state = "off";
+ gpios = <&led_gpio1 1 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan11-blue {
+ color = <LED_COLOR_ID_BLUE>;
+ retain-state-shutdown;
+ default-state = "on";
+ gpios = <&led_gpio1 6 GPIO_ACTIVE_HIGH>;
+ };
+
+ led-fan11-amber {
+ color = <LED_COLOR_ID_AMBER>;
+ retain-state-shutdown;
+ default-state = "off";
+ gpios = <&led_gpio1 7 GPIO_ACTIVE_HIGH>;
+ };
+ };
};
&uart1 {
@@ -840,7 +1013,7 @@ eeprom@52 {
reg = <0x52>;
};
- gpio@61 {
+ led_gpio1: gpio@61 {
compatible = "nxp,pca9552";
reg = <0x61>;
#address-cells = <1>;
@@ -892,7 +1065,7 @@ eeprom@52 {
reg = <0x52>;
};
- gpio@61 {
+ led_gpio0: gpio@61 {
compatible = "nxp,pca9552";
reg = <0x61>;
#address-cells = <1>;
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH v18 0/3] Add i2c-mux and eeprom devices for Meta Yosemite4
2024-09-09 10:54 [PATCH v18 0/3] Add i2c-mux and eeprom devices for Meta Yosemite4 Delphine CC Chiu
` (2 preceding siblings ...)
2024-09-09 10:54 ` [PATCH v18 3/3] ARM: dts: aspeed: yosemite4: add fan led config Delphine CC Chiu
@ 2024-09-09 15:45 ` Rob Herring (Arm)
2024-09-12 2:34 ` Andrew Jeffery
3 siblings, 1 reply; 7+ messages in thread
From: Rob Herring (Arm) @ 2024-09-09 15:45 UTC (permalink / raw)
To: Delphine CC Chiu
Cc: Ricky CX Wu, devicetree, Joel Stanley, Conor Dooley,
Krzysztof Kozlowski, Andrew Jeffery, linux-aspeed,
linux-arm-kernel, patrick, linux-kernel
On Mon, 09 Sep 2024 18:54:15 +0800, Delphine CC Chiu wrote:
> From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
>
> Changelog:
> - v18
> - Fix warnings for reg_format reporting by dts checking tool.
> - v17
> - Add SoB for the patches.
> - v16
> - Reorganized the patches.
> - Add i2c-mux and resolve the dt-validate errors.
> - Revise Yosemite 4 devicetree for devices behind i2c-mux.
> - Add mctp config and sensors for NIC after i2c-mux on bus 15.
> - Add fan led config for BMC to control according the status of fan.
> - v15
> - Add ISL28022 support
> - v14
> - Add SQ52205 support
> - Add GPIO I6 pin
> - v13
> - Add RTQ6056-support-on-bus-11
> - v12
> - Fix GPIO linename typo and add missing GPIO pin initial state.
> - v11
> - Revise all GPIO line name with bottom line
> - v10
> - adjust mgm cpld ioexp bus
> - add GPIOO7 name
> - remove mctp driver
> - v9
> - add XDP710 support
> - add RTQ6056 support
> - add MP5990 support
> - v8
> - add fan led config
> - v7
> - Revise pca9506 i2c address
> - v6
> - Revise i2c duty-cycle for meeting 400khz spec
> - v5
> - Support medusa board adc sensors
> - support NIC eeprom
> - v4
> - Re-format gpio linename
> - Revise i2c device node names
> - Split patches by logic changes
> - v3
> - Correct patch for revising gpio name
> - v2
> - Revise mx31790 fan tach config
> - Add mctp config for NIC
> - Support mux to cpld
> - Revise gpio name
> - v1
> - Add gpio and eeprom behind i2c-mux
> - Remove redundant idle-state setting for i2c-mux
> - Enable adc 15, wdt2,spi gpio for yosemite4 use
> - Revise quad mode to dual mode to avoid WP pin influnece the SPI
> - Revise power sensor adm1281 for yosemite4 schematic change
> - Add gpio pca9506 I/O expander for yosemite4 use
> - remove space for adm1272 compatible
> - enable interrupt setting for pca9555
> - add eeprom for yosemite4 medusa board/BSM use
> - remove temperature sensor for yosemite4 schematic change
> - add power sensor for power module reading
> - Revise adc128d818 adc mode for yosemite4 schematic change
> - Revise ina233 for yosemite4 schematic change
> - Remove idle state setting for yosemite4 NIC connection
> - Initialize bmc gpio state
> - Revise mx31790 fan tach config
> - Add mctp config for NIC
> - Support mux to cpld
> - Revise gpio name
>
> Ricky CX Wu (3):
> ARM: dts: aspeed: yosemite4: Revise i2c-mux devices
> ARM: dts: aspeed: yosemite4: add mctp config and sensors for NIC
> ARM: dts: aspeed: yosemite4: add fan led config
>
> .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 706 ++++++++++++++++--
> 1 file changed, 660 insertions(+), 46 deletions(-)
>
> --
> 2.25.1
>
>
>
My bot found new DTB warnings on the .dts files added or changed in this
series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-facebook-yosemite4.dtb' for 20240909105420.441607-1-Delphine_CC_Chiu@wiwynn.com:
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: pwm@20: '#address-cells', '#size-cells' do not match any of the regexes: '^fan-[0-9]+$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: pwm@2f: '#address-cells', '#size-cells' do not match any of the regexes: '^fan-[0-9]+$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@780/i2c-mux@74/i2c@0/gpio@61: failed to match any schema with compatible: ['nxp,pca9552']
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: pwm@20: '#address-cells', '#size-cells' do not match any of the regexes: '^fan-[0-9]+$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: pwm@2f: '#address-cells', '#size-cells' do not match any of the regexes: '^fan-[0-9]+$', 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@780/i2c-mux@74/i2c@1/gpio@61: failed to match any schema with compatible: ['nxp,pca9552']
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@800/i2c-mux@72/i2c@0/temperature-sensor@3c: failed to match any schema with compatible: ['smsc,emc1403']
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@800/i2c-mux@72/i2c@1/temperature-sensor@3c: failed to match any schema with compatible: ['smsc,emc1403']
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@800/i2c-mux@72/i2c@2/temperature-sensor@3c: failed to match any schema with compatible: ['smsc,emc1403']
arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@800/i2c-mux@72/i2c@3/temperature-sensor@3c: failed to match any schema with compatible: ['smsc,emc1403']
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v18 0/3] Add i2c-mux and eeprom devices for Meta Yosemite4
2024-09-09 15:45 ` [PATCH v18 0/3] Add i2c-mux and eeprom devices for Meta Yosemite4 Rob Herring (Arm)
@ 2024-09-12 2:34 ` Andrew Jeffery
2024-09-20 6:38 ` Delphine_CC_Chiu/WYHQ/Wiwynn
0 siblings, 1 reply; 7+ messages in thread
From: Andrew Jeffery @ 2024-09-12 2:34 UTC (permalink / raw)
To: Delphine CC Chiu, Ricky CX Wu
Cc: Rob Herring (Arm), devicetree, Joel Stanley, Conor Dooley,
Krzysztof Kozlowski, linux-aspeed, linux-arm-kernel, patrick,
linux-kernel
Hi Ricky,
On Mon, 2024-09-09 at 10:45 -0500, Rob Herring (Arm) wrote:
> On Mon, 09 Sep 2024 18:54:15 +0800, Delphine CC Chiu wrote:
> > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> >
...
> >
> > Ricky CX Wu (3):
> > ARM: dts: aspeed: yosemite4: Revise i2c-mux devices
> > ARM: dts: aspeed: yosemite4: add mctp config and sensors for NIC
> > ARM: dts: aspeed: yosemite4: add fan led config
> >
> > .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 706 ++++++++++++++++--
> > 1 file changed, 660 insertions(+), 46 deletions(-)
> >
> > --
> > 2.25.1
>
>
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
> pip3 install dtschema --upgrade
>
>
> New warnings running 'make CHECK_DTBS=y aspeed/aspeed-bmc-facebook-yosemite4.dtb' for 20240909105420.441607-1-Delphine_CC_Chiu@wiwynn.com:
>
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: pwm@20: '#address-cells', '#size-cells' do not match any of the regexes: '^fan-[0-9]+$', 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: pwm@2f: '#address-cells', '#size-cells' do not match any of the regexes: '^fan-[0-9]+$', 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@780/i2c-mux@74/i2c@0/gpio@61: failed to match any schema with compatible: ['nxp,pca9552']
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: pwm@20: '#address-cells', '#size-cells' do not match any of the regexes: '^fan-[0-9]+$', 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: pwm@2f: '#address-cells', '#size-cells' do not match any of the regexes: '^fan-[0-9]+$', 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/hwmon/maxim,max31790.yaml
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@780/i2c-mux@74/i2c@1/gpio@61: failed to match any schema with compatible: ['nxp,pca9552']
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@800/i2c-mux@72/i2c@0/temperature-sensor@3c: failed to match any schema with compatible: ['smsc,emc1403']
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@800/i2c-mux@72/i2c@1/temperature-sensor@3c: failed to match any schema with compatible: ['smsc,emc1403']
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@800/i2c-mux@72/i2c@2/temperature-sensor@3c: failed to match any schema with compatible: ['smsc,emc1403']
> arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: /ahb/apb/bus@1e78a000/i2c@800/i2c-mux@72/i2c@3/temperature-sensor@3c: failed to match any schema with compatible: ['smsc,emc1403']
>
Please either:
1. Remove the offending nodes from your series so we don't add yet more
warnings, or
2. Write appropriate bindings and send them as part of the series
Regarding 1, you can always update the devicetree to add the nodes
after someone else has got the bindings merged. However, if you must
have the nodes, then you need to do 2.
Thanks,
Andrew
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v18 0/3] Add i2c-mux and eeprom devices for Meta Yosemite4
2024-09-12 2:34 ` Andrew Jeffery
@ 2024-09-20 6:38 ` Delphine_CC_Chiu/WYHQ/Wiwynn
0 siblings, 0 replies; 7+ messages in thread
From: Delphine_CC_Chiu/WYHQ/Wiwynn @ 2024-09-20 6:38 UTC (permalink / raw)
To: Andrew Jeffery, Delphine_CC_Chiu/WYHQ/Wiwynn, Ricky CX Wu
Cc: Rob Herring (Arm), devicetree@vger.kernel.org, Joel Stanley,
Conor Dooley, Krzysztof Kozlowski, linux-aspeed@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org, patrick@stwcx.xyz,
linux-kernel@vger.kernel.org
> -----Original Message-----
> From: Andrew Jeffery <andrew@codeconstruct.com.au>
> Sent: Thursday, September 12, 2024 10:34 AM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> Cc: Rob Herring (Arm) <robh@kernel.org>; devicetree@vger.kernel.org; Joel
> Stanley <joel@jms.id.au>; Conor Dooley <conor+dt@kernel.org>; Krzysztof
> Kozlowski <krzk+dt@kernel.org>; linux-aspeed@lists.ozlabs.org;
> linux-arm-kernel@lists.infradead.org; patrick@stwcx.xyz;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v18 0/3] Add i2c-mux and eeprom devices for Meta
> Yosemite4
>
> [External Sender]
>
> [External Sender]
>
> Hi Ricky,
>
> On Mon, 2024-09-09 at 10:45 -0500, Rob Herring (Arm) wrote:
> > On Mon, 09 Sep 2024 18:54:15 +0800, Delphine CC Chiu wrote:
> > > From: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>
> > >
> ...
> > >
> > > Ricky CX Wu (3):
> > > ARM: dts: aspeed: yosemite4: Revise i2c-mux devices
> > > ARM: dts: aspeed: yosemite4: add mctp config and sensors for NIC
> > > ARM: dts: aspeed: yosemite4: add fan led config
> > >
> > > .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 706
> > > ++++++++++++++++--
> > > 1 file changed, 660 insertions(+), 46 deletions(-)
> > >
> > > --
> > > 2.25.1
> >
> >
> > My bot found new DTB warnings on the .dts files added or changed in
> > this series.
> >
> > Some warnings may be from an existing SoC .dtsi. Or perhaps the
> > warnings are fixed by another series. Ultimately, it is up to the
> > platform maintainer whether these warnings are acceptable or not. No
> > need to reply unless the platform maintainer has comments.
> >
> > If you already ran DT checks and didn't see these error(s), then make
> > sure dt-schema is up to date:
> >
> > pip3 install dtschema --upgrade
> >
> >
> > New warnings running 'make CHECK_DTBS=y
> aspeed/aspeed-bmc-facebook-yosemite4.dtb' for
> 20240909105420.441607-1-Delphine_CC_Chiu@wiwynn.com:
> >
> > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: pwm@20:
> '#address-cells', '#size-cells' do not match any of the regexes: '^fan-[0-9]+$',
> 'pinctrl-[0-9]+'
> > from schema $id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/hwmon/maxim,
> >
> max31790.yaml__;!!J63qqgXj!KOrUCIgHJyjBrccMiU8ZIIKD844Aq_AqQeUZF9qer
> Ys
> > j9rqtQAcRSSRFaVck8tuE0xWFPVt0pTCb8ZptOGMzhLQCCiY$
> > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: pwm@2f:
> '#address-cells', '#size-cells' do not match any of the regexes: '^fan-[0-9]+$',
> 'pinctrl-[0-9]+'
> > from schema $id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/hwmon/maxim,
> >
> max31790.yaml__;!!J63qqgXj!KOrUCIgHJyjBrccMiU8ZIIKD844Aq_AqQeUZF9qer
> Ys
> > j9rqtQAcRSSRFaVck8tuE0xWFPVt0pTCb8ZptOGMzhLQCCiY$
> > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb:
> > /ahb/apb/bus@1e78a000/i2c@780/i2c-mux@74/i2c@0/gpio@61: failed to
> > match any schema with compatible: ['nxp,pca9552']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: pwm@20:
> '#address-cells', '#size-cells' do not match any of the regexes: '^fan-[0-9]+$',
> 'pinctrl-[0-9]+'
> > from schema $id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/hwmon/maxim,
> >
> max31790.yaml__;!!J63qqgXj!KOrUCIgHJyjBrccMiU8ZIIKD844Aq_AqQeUZF9qer
> Ys
> > j9rqtQAcRSSRFaVck8tuE0xWFPVt0pTCb8ZptOGMzhLQCCiY$
> > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb: pwm@2f:
> '#address-cells', '#size-cells' do not match any of the regexes: '^fan-[0-9]+$',
> 'pinctrl-[0-9]+'
> > from schema $id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/hwmon/maxim,
> >
> max31790.yaml__;!!J63qqgXj!KOrUCIgHJyjBrccMiU8ZIIKD844Aq_AqQeUZF9qer
> Ys
> > j9rqtQAcRSSRFaVck8tuE0xWFPVt0pTCb8ZptOGMzhLQCCiY$
> > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb:
> > /ahb/apb/bus@1e78a000/i2c@780/i2c-mux@74/i2c@1/gpio@61: failed to
> > match any schema with compatible: ['nxp,pca9552']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb:
> >
> /ahb/apb/bus@1e78a000/i2c@800/i2c-mux@72/i2c@0/temperature-sensor@
> 3c:
> > failed to match any schema with compatible: ['smsc,emc1403']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb:
> >
> /ahb/apb/bus@1e78a000/i2c@800/i2c-mux@72/i2c@1/temperature-sensor@
> 3c:
> > failed to match any schema with compatible: ['smsc,emc1403']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb:
> >
> /ahb/apb/bus@1e78a000/i2c@800/i2c-mux@72/i2c@2/temperature-sensor@
> 3c:
> > failed to match any schema with compatible: ['smsc,emc1403']
> > arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dtb:
> >
> /ahb/apb/bus@1e78a000/i2c@800/i2c-mux@72/i2c@3/temperature-sensor@
> 3c:
> > failed to match any schema with compatible: ['smsc,emc1403']
> >
>
> Please either:
>
> 1. Remove the offending nodes from your series so we don't add yet more
> warnings, or 2. Write appropriate bindings and send them as part of the series
>
> Regarding 1, you can always update the devicetree to add the nodes after
> someone else has got the bindings merged. However, if you must have the
> nodes, then you need to do 2.
>
> Thanks,
>
> Andrew
Hi Andrew,
I'll remove the offending nodes first and update bindings in other patches.
Once the bindings are applied, I will update the nodes again.
Thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-09-20 6:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-09 10:54 [PATCH v18 0/3] Add i2c-mux and eeprom devices for Meta Yosemite4 Delphine CC Chiu
2024-09-09 10:54 ` [PATCH v18 1/3] ARM: dts: aspeed: yosemite4: Revise i2c-mux devices Delphine CC Chiu
2024-09-09 10:54 ` [PATCH v18 2/3] ARM: dts: aspeed: yosemite4: add mctp config and sensors for NIC Delphine CC Chiu
2024-09-09 10:54 ` [PATCH v18 3/3] ARM: dts: aspeed: yosemite4: add fan led config Delphine CC Chiu
2024-09-09 15:45 ` [PATCH v18 0/3] Add i2c-mux and eeprom devices for Meta Yosemite4 Rob Herring (Arm)
2024-09-12 2:34 ` Andrew Jeffery
2024-09-20 6:38 ` Delphine_CC_Chiu/WYHQ/Wiwynn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox