The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Shrikanth Hegde <sshegde@linux.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, mingo@kernel.org,
	juri.lelli@redhat.com, vincent.guittot@linaro.org,
	yury.norov@gmail.com, kprateek.nayak@amd.com, iii@linux.ibm.com,
	tglx@kernel.org, gregkh@linuxfoundation.org, pbonzini@redhat.com,
	seanjc@google.com, vschneid@redhat.com, huschle@linux.ibm.com,
	rostedt@goodmis.org, dietmar.eggemann@arm.com, mgorman@suse.de,
	bsegall@google.com, maddy@linux.ibm.com, srikar@linux.ibm.com,
	hdanton@sina.com, chleroy@kernel.org, vineeth@bitbyteword.org,
	frederic@kernel.org, arighi@nvidia.com, pauld@redhat.com,
	christian.loehle@arm.com, tj@kernel.org,
	tommaso.cucinotta@gmail.com, maz@kernel.org, rafael@kernel.org
Subject: Re: [PATCH v3 09/20] sched/rt: Select a preferred CPU for wakeup and pulling rt task
Date: Wed, 10 Jun 2026 22:43:24 +0530	[thread overview]
Message-ID: <476fa19d-d5fb-4ac5-8363-607bdc02da86@linux.ibm.com> (raw)
In-Reply-To: <d2f93248-37ba-4f36-b8d7-3b20d4a15b43@linux.ibm.com>

Hi Peter.

On 6/9/26 5:00 PM, Shrikanth Hegde wrote:
> Hi Peter. Thanks for taking a look at the patches.
> 
> On 6/9/26 4:55 PM, Peter Zijlstra wrote:
>> On Thu, May 14, 2026 at 08:51:53PM +0530, Shrikanth Hegde wrote:
>>> For RT class,
>>> - During wakeup choose a preferred CPU.
>>> - For push_rt framework, limit pushing to preferred CPUs
>>> - Pull the rt task only if CPU is preferred.
>>
>> So this one might have the potential to break things. Preferring a
>> preferred cpu, sure, but to the exclusion of active, perhaps not.
>>
> 
> I don't think we are excluding active.
> 

I thought a bit more.
On most common workloads, rt is likely not dominant/significant in VM environments.

I am thinking to drop rt changes in the next version. If we see a need for it,
then that support could be added. I reverted these changes and ran real
life workload (daytrader) mentioned in the cover-letter and I don't see its
impact.

>> Also, where are the DL changes?
> 
> DL changes are not there. The reason being on such systems running DL 
> tasks will not make sense as timelines are subjected to vCPU preemption 
> and there is no easy way to force run a vCPU.
> 
> RT is not a primary use case too. But have seen a few workload spawn RT 
> tasks today. So it is there.
> 

So, initial support will be for FAIR only. Other class support could be brought
based on the use-case. Does that make sense?

  reply	other threads:[~2026-06-10 17:14 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14 15:21 [PATCH v3 00/20] sched: Introduce cpu_preferred_mask and steal-driven vCPU backoff Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 01/20] sched/debug: Remove unused schedstats Shrikanth Hegde
2026-06-04  4:01   ` K Prateek Nayak
2026-05-14 15:21 ` [PATCH v3 02/20] sched/docs: Document cpu_preferred_mask and Preferred CPU concept Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 03/20] kconfig: Provide PREFERRED_CPU option Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 04/20] cpumask: Introduce cpu_preferred_mask Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 05/20] sysfs: Add preferred CPU file Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 06/20] sched/core: allow only preferred CPUs in is_cpu_allowed Shrikanth Hegde
2026-06-04  5:06   ` K Prateek Nayak
2026-06-04  5:54     ` Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 07/20] sched/fair: Select preferred CPU at wakeup when possible Shrikanth Hegde
2026-06-04  5:14   ` K Prateek Nayak
2026-06-04  5:48     ` Shrikanth Hegde
2026-06-08 16:39     ` Ilya Leoshkevich
2026-06-09  4:42       ` Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 08/20] sched/fair: load balance only among preferred CPUs Shrikanth Hegde
2026-06-04  5:20   ` K Prateek Nayak
2026-06-04  5:45     ` Shrikanth Hegde
2026-06-04  6:09       ` K Prateek Nayak
2026-06-04 13:07         ` Shrikanth Hegde
2026-06-09 11:22           ` Peter Zijlstra
2026-06-09 11:33             ` Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 09/20] sched/rt: Select a preferred CPU for wakeup and pulling rt task Shrikanth Hegde
2026-06-09 11:25   ` Peter Zijlstra
2026-06-09 11:30     ` Shrikanth Hegde
2026-06-10 17:13       ` Shrikanth Hegde [this message]
2026-05-14 15:21 ` [PATCH v3 10/20] sched/core: Keep tick on non-preferred CPUs until tasks are out Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 11/20] sched/core: Push current task from non preferred CPU Shrikanth Hegde
2026-06-04  6:58   ` K Prateek Nayak
2026-06-04  9:43     ` Shrikanth Hegde
2026-06-04  9:56       ` K Prateek Nayak
2026-06-04 12:16         ` Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 12/20] sched/debug: Add migration stats due to non preferred CPUs Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 13/20] sched/debug: Create debugfs folder steal_monitor Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 14/20] sched/debug: Provide debugfs to enable/disable steal monitor Shrikanth Hegde
2026-06-08 17:37   ` Ilya Leoshkevich
2026-06-09  4:48     ` Shrikanth Hegde
2026-06-08 18:28   ` Ilya Leoshkevich
2026-06-09  5:04     ` Shrikanth Hegde
2026-05-14 15:21 ` [PATCH v3 15/20] sched/core: Introduce a simple " Shrikanth Hegde
2026-06-08 16:25   ` Ilya Leoshkevich
2026-06-09  5:54     ` Shrikanth Hegde
2026-05-14 15:22 ` [PATCH v3 16/20] sched/core: Compute steal values at regular intervals Shrikanth Hegde
2026-05-14 15:22 ` [PATCH v3 17/20] sched/core: Introduce default arch handling code for inc/dec preferred CPUs Shrikanth Hegde
2026-06-08 16:22   ` Ilya Leoshkevich
2026-06-09  5:14     ` Shrikanth Hegde
2026-06-08 18:40   ` Ilya Leoshkevich
2026-06-09  6:42     ` Shrikanth Hegde
2026-05-14 15:22 ` [PATCH v3 18/20] sched/core: Handle steal values and mark CPUs as preferred Shrikanth Hegde
2026-05-14 15:22 ` [PATCH v3 19/20] sched/core: Mark the direction of steal values to avoid oscillations Shrikanth Hegde
2026-05-14 15:22 ` [PATCH v3 20/20] sched/debug: Add debug knobs for steal monitor Shrikanth Hegde
2026-06-04  3:17 ` [PATCH v3 00/20] sched: Introduce cpu_preferred_mask and steal-driven vCPU backoff Shrikanth Hegde
2026-06-09 19:51 ` Shrikanth Hegde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=476fa19d-d5fb-4ac5-8363-607bdc02da86@linux.ibm.com \
    --to=sshegde@linux.ibm.com \
    --cc=arighi@nvidia.com \
    --cc=bsegall@google.com \
    --cc=chleroy@kernel.org \
    --cc=christian.loehle@arm.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=frederic@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdanton@sina.com \
    --cc=huschle@linux.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maddy@linux.ibm.com \
    --cc=maz@kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@kernel.org \
    --cc=pauld@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rafael@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=seanjc@google.com \
    --cc=srikar@linux.ibm.com \
    --cc=tglx@kernel.org \
    --cc=tj@kernel.org \
    --cc=tommaso.cucinotta@gmail.com \
    --cc=vincent.guittot@linaro.org \
    --cc=vineeth@bitbyteword.org \
    --cc=vschneid@redhat.com \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox