[PATCH] regulator: tps62360: Fix build error due to missing semicolon

[PATCH] regulator: tps62360: Fix build error due to missing semicolon

[Axel Lin]

Fix below build error:
  CC [M]  drivers/regulator/tps62360-regulator.o
drivers/regulator/tps62360-regulator.c:351:1: error: expected ',' or ';' before 'extern'
make[2]: *** [drivers/regulator/tps62360-regulator.o] Error 1
make[1]: *** [drivers/regulator] Error 2
make: *** [drivers] Error 2

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/regulator/tps62360-regulator.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/regulator/tps62360-regulator.c b/drivers/regulator/tps62360-regulator.c
index 60765cc..82cd763 100644
--- a/drivers/regulator/tps62360-regulator.c
+++ b/drivers/regulator/tps62360-regulator.c
@@ -347,7 +347,7 @@ static const struct of_device_id tps62360_of_match[] = {
 	 { .compatible = "ti,tps62362", .data = (void *)TPS62362},
 	 { .compatible = "ti,tps62363", .data = (void *)TPS62363},
 	{},
-}
+};
 MODULE_DEVICE_TABLE(of, tps62360_of_match);
 #endif
 
-- 
1.7.5.4

Re: [PATCH] regulator: tps62360: Fix build error due to missing semicolon

[Laxman Dewangan]

On Monday 14 May 2012 09:28 PM, Axel Lin wrote:
> Fix below build error:
>    CC [M]  drivers/regulator/tps62360-regulator.o
> drivers/regulator/tps62360-regulator.c:351:1: error: expected ',' or ';' before 'extern'
> make[2]: *** [drivers/regulator/tps62360-regulator.o] Error 1
> make[1]: *** [drivers/regulator] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Axel Lin<axel.lin@gmail.com>
> ---
>   drivers/regulator/tps62360-regulator.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/tps62360-regulator.c b/drivers/regulator/tps62360-regulator.c
> index 60765cc..82cd763 100644
> --- a/drivers/regulator/tps62360-regulator.c
> +++ b/drivers/regulator/tps62360-regulator.c
> @@ -347,7 +347,7 @@ static const struct of_device_id tps62360_of_match[] = {
>   	 { .compatible = "ti,tps62362", .data = (void *)TPS62362},
>   	 { .compatible = "ti,tps62363", .data = (void *)TPS62363},
>   	{},
> -}
> +};
>   MODULE_DEVICE_TABLE(of, tps62360_of_match);
>   #endif
>
Really strange!! I am not getting this compilation error in my build.

Acked-by: Laxman Dewangan <ldewangan@nvidia.com>

Re: [PATCH] regulator: tps62360: Fix build error due to missing semicolon

[Laxman Dewangan]

On Monday 14 May 2012 09:41 PM, Laxman Dewangan wrote:
> On Monday 14 May 2012 09:28 PM, Axel Lin wrote:
>> Fix below build error:
>>     CC [M]  drivers/regulator/tps62360-regulator.o
>> drivers/regulator/tps62360-regulator.c:351:1: error: expected ',' or ';' before 'extern'
>> make[2]: *** [drivers/regulator/tps62360-regulator.o] Error 1
>> make[1]: *** [drivers/regulator] Error 2
>> make: *** [drivers] Error 2
>>
>> Signed-off-by: Axel Lin<axel.lin@gmail.com>
>> ---
>>    drivers/regulator/tps62360-regulator.c |    2 +-
>>    1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/regulator/tps62360-regulator.c b/drivers/regulator/tps62360-regulator.c
>> index 60765cc..82cd763 100644
>> --- a/drivers/regulator/tps62360-regulator.c
>> +++ b/drivers/regulator/tps62360-regulator.c
>> @@ -347,7 +347,7 @@ static const struct of_device_id tps62360_of_match[] = {
>>    	 { .compatible = "ti,tps62362", .data = (void *)TPS62362},
>>    	 { .compatible = "ti,tps62363", .data = (void *)TPS62363},
>>    	{},
>> -}
>> +};
>>    MODULE_DEVICE_TABLE(of, tps62360_of_match);
>>    #endif
>>
> Really strange!! I am not getting this compilation error in my build.
>
> Acked-by: Laxman Dewangan<ldewangan@nvidia.com>
>
Got reproduced this error if I compile the driver as module.
Now onwards, I will compile as y and m for any change.
Sorry for inconvenience and thanks for fixing this.

Re: [PATCH] regulator: tps62360: Fix build error due to missing semicolon

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

On Mon, May 14, 2012 at 09:41:15PM +0530, Laxman Dewangan wrote:
> On Monday 14 May 2012 09:28 PM, Axel Lin wrote:
> >Fix below build error:
> >   CC [M]  drivers/regulator/tps62360-regulator.o
> >drivers/regulator/tps62360-regulator.c:351:1: error: expected ',' or ';' before 'extern'

> Really strange!! I am not getting this compilation error in my build.

> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>

I suspect it's due to a CONFIG_OF difference.  Applied, thanks.  Are you
OK with Axel's patches to rc5t583?  I'd been holing off on them for your
review.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]