* [PATCH] regulator: tps62360: Fix build error due to missing semicolon
@ 2012-05-14 15:58 Axel Lin
2012-05-14 16:11 ` Laxman Dewangan
0 siblings, 1 reply; 4+ messages in thread
From: Axel Lin @ 2012-05-14 15:58 UTC (permalink / raw)
To: linux-kernel; +Cc: Laxman Dewangan, Liam Girdwood, Mark Brown
Fix below build error:
CC [M] drivers/regulator/tps62360-regulator.o
drivers/regulator/tps62360-regulator.c:351:1: error: expected ',' or ';' before 'extern'
make[2]: *** [drivers/regulator/tps62360-regulator.o] Error 1
make[1]: *** [drivers/regulator] Error 2
make: *** [drivers] Error 2
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/regulator/tps62360-regulator.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/tps62360-regulator.c b/drivers/regulator/tps62360-regulator.c
index 60765cc..82cd763 100644
--- a/drivers/regulator/tps62360-regulator.c
+++ b/drivers/regulator/tps62360-regulator.c
@@ -347,7 +347,7 @@ static const struct of_device_id tps62360_of_match[] = {
{ .compatible = "ti,tps62362", .data = (void *)TPS62362},
{ .compatible = "ti,tps62363", .data = (void *)TPS62363},
{},
-}
+};
MODULE_DEVICE_TABLE(of, tps62360_of_match);
#endif
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] regulator: tps62360: Fix build error due to missing semicolon
2012-05-14 15:58 [PATCH] regulator: tps62360: Fix build error due to missing semicolon Axel Lin
@ 2012-05-14 16:11 ` Laxman Dewangan
2012-05-14 16:33 ` Laxman Dewangan
2012-05-14 16:36 ` Mark Brown
0 siblings, 2 replies; 4+ messages in thread
From: Laxman Dewangan @ 2012-05-14 16:11 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel@vger.kernel.org, Liam Girdwood, Mark Brown
On Monday 14 May 2012 09:28 PM, Axel Lin wrote:
> Fix below build error:
> CC [M] drivers/regulator/tps62360-regulator.o
> drivers/regulator/tps62360-regulator.c:351:1: error: expected ',' or ';' before 'extern'
> make[2]: *** [drivers/regulator/tps62360-regulator.o] Error 1
> make[1]: *** [drivers/regulator] Error 2
> make: *** [drivers] Error 2
>
> Signed-off-by: Axel Lin<axel.lin@gmail.com>
> ---
> drivers/regulator/tps62360-regulator.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/tps62360-regulator.c b/drivers/regulator/tps62360-regulator.c
> index 60765cc..82cd763 100644
> --- a/drivers/regulator/tps62360-regulator.c
> +++ b/drivers/regulator/tps62360-regulator.c
> @@ -347,7 +347,7 @@ static const struct of_device_id tps62360_of_match[] = {
> { .compatible = "ti,tps62362", .data = (void *)TPS62362},
> { .compatible = "ti,tps62363", .data = (void *)TPS62363},
> {},
> -}
> +};
> MODULE_DEVICE_TABLE(of, tps62360_of_match);
> #endif
>
Really strange!! I am not getting this compilation error in my build.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] regulator: tps62360: Fix build error due to missing semicolon
2012-05-14 16:11 ` Laxman Dewangan
@ 2012-05-14 16:33 ` Laxman Dewangan
2012-05-14 16:36 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Laxman Dewangan @ 2012-05-14 16:33 UTC (permalink / raw)
To: Axel Lin; +Cc: linux-kernel@vger.kernel.org, Liam Girdwood, Mark Brown
On Monday 14 May 2012 09:41 PM, Laxman Dewangan wrote:
> On Monday 14 May 2012 09:28 PM, Axel Lin wrote:
>> Fix below build error:
>> CC [M] drivers/regulator/tps62360-regulator.o
>> drivers/regulator/tps62360-regulator.c:351:1: error: expected ',' or ';' before 'extern'
>> make[2]: *** [drivers/regulator/tps62360-regulator.o] Error 1
>> make[1]: *** [drivers/regulator] Error 2
>> make: *** [drivers] Error 2
>>
>> Signed-off-by: Axel Lin<axel.lin@gmail.com>
>> ---
>> drivers/regulator/tps62360-regulator.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/regulator/tps62360-regulator.c b/drivers/regulator/tps62360-regulator.c
>> index 60765cc..82cd763 100644
>> --- a/drivers/regulator/tps62360-regulator.c
>> +++ b/drivers/regulator/tps62360-regulator.c
>> @@ -347,7 +347,7 @@ static const struct of_device_id tps62360_of_match[] = {
>> { .compatible = "ti,tps62362", .data = (void *)TPS62362},
>> { .compatible = "ti,tps62363", .data = (void *)TPS62363},
>> {},
>> -}
>> +};
>> MODULE_DEVICE_TABLE(of, tps62360_of_match);
>> #endif
>>
> Really strange!! I am not getting this compilation error in my build.
>
> Acked-by: Laxman Dewangan<ldewangan@nvidia.com>
>
Got reproduced this error if I compile the driver as module.
Now onwards, I will compile as y and m for any change.
Sorry for inconvenience and thanks for fixing this.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] regulator: tps62360: Fix build error due to missing semicolon
2012-05-14 16:11 ` Laxman Dewangan
2012-05-14 16:33 ` Laxman Dewangan
@ 2012-05-14 16:36 ` Mark Brown
1 sibling, 0 replies; 4+ messages in thread
From: Mark Brown @ 2012-05-14 16:36 UTC (permalink / raw)
To: Laxman Dewangan; +Cc: Axel Lin, linux-kernel@vger.kernel.org, Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 566 bytes --]
On Mon, May 14, 2012 at 09:41:15PM +0530, Laxman Dewangan wrote:
> On Monday 14 May 2012 09:28 PM, Axel Lin wrote:
> >Fix below build error:
> > CC [M] drivers/regulator/tps62360-regulator.o
> >drivers/regulator/tps62360-regulator.c:351:1: error: expected ',' or ';' before 'extern'
> Really strange!! I am not getting this compilation error in my build.
> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
I suspect it's due to a CONFIG_OF difference. Applied, thanks. Are you
OK with Axel's patches to rc5t583? I'd been holing off on them for your
review.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-05-14 16:38 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-14 15:58 [PATCH] regulator: tps62360: Fix build error due to missing semicolon Axel Lin
2012-05-14 16:11 ` Laxman Dewangan
2012-05-14 16:33 ` Laxman Dewangan
2012-05-14 16:36 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox