* [PATCH] ALSA: firewire-digi00x: Drop bogus const type qualifier on dot_scrt()
@ 2016-02-07 14:14 Geert Uytterhoeven
2016-02-08 11:22 ` Takashi Sakamoto
2016-02-09 11:17 ` Takashi Iwai
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2016-02-07 14:14 UTC (permalink / raw)
To: Clemens Ladisch, Jaroslav Kysela, Takashi Iwai
Cc: alsa-devel, linux-kernel, Geert Uytterhoeven
sound/firewire/digi00x/amdtp-dot.c:67: warning: type qualifiers ignored on function return type
Drop the bogus "const" type qualifier on the return type of dot_scrt()
to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
sound/firewire/digi00x/amdtp-dot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/firewire/digi00x/amdtp-dot.c b/sound/firewire/digi00x/amdtp-dot.c
index b02a5e8cad448c40..0ac92aba5bc1c9a4 100644
--- a/sound/firewire/digi00x/amdtp-dot.c
+++ b/sound/firewire/digi00x/amdtp-dot.c
@@ -63,7 +63,7 @@ struct amdtp_dot {
#define BYTE_PER_SAMPLE (4)
#define MAGIC_DOT_BYTE (2)
#define MAGIC_BYTE_OFF(x) (((x) * BYTE_PER_SAMPLE) + MAGIC_DOT_BYTE)
-static const u8 dot_scrt(const u8 idx, const unsigned int off)
+static u8 dot_scrt(const u8 idx, const unsigned int off)
{
/*
* the length of the added pattern only depends on the lower nibble
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ALSA: firewire-digi00x: Drop bogus const type qualifier on dot_scrt()
2016-02-07 14:14 [PATCH] ALSA: firewire-digi00x: Drop bogus const type qualifier on dot_scrt() Geert Uytterhoeven
@ 2016-02-08 11:22 ` Takashi Sakamoto
2016-02-09 11:17 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Sakamoto @ 2016-02-08 11:22 UTC (permalink / raw)
To: Geert Uytterhoeven, Takashi Iwai
Cc: alsa-devel, linux-kernel, Damien Zammit, Robin Gareus
On Feb 7 2016 23:14, Geert Uytterhoeven wrote:
> sound/firewire/digi00x/amdtp-dot.c:67: warning: type qualifiers ignored on function return type
>
> Drop the bogus "const" type qualifier on the return type of dot_scrt()
> to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Yep. It came from original code[1] and I overlooked.
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
> ---
> sound/firewire/digi00x/amdtp-dot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/firewire/digi00x/amdtp-dot.c b/sound/firewire/digi00x/amdtp-dot.c
> index b02a5e8cad448c40..0ac92aba5bc1c9a4 100644
> --- a/sound/firewire/digi00x/amdtp-dot.c
> +++ b/sound/firewire/digi00x/amdtp-dot.c
> @@ -63,7 +63,7 @@ struct amdtp_dot {
> #define BYTE_PER_SAMPLE (4)
> #define MAGIC_DOT_BYTE (2)
> #define MAGIC_BYTE_OFF(x) (((x) * BYTE_PER_SAMPLE) + MAGIC_DOT_BYTE)
> -static const u8 dot_scrt(const u8 idx, const unsigned int off)
> +static u8 dot_scrt(const u8 idx, const unsigned int off)
> {
> /*
> * the length of the added pattern only depends on the lower nibble
Thanks
[1] https://github.com/x42/003amdtp
Takashi Sakamoto
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ALSA: firewire-digi00x: Drop bogus const type qualifier on dot_scrt()
2016-02-07 14:14 [PATCH] ALSA: firewire-digi00x: Drop bogus const type qualifier on dot_scrt() Geert Uytterhoeven
2016-02-08 11:22 ` Takashi Sakamoto
@ 2016-02-09 11:17 ` Takashi Iwai
1 sibling, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2016-02-09 11:17 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Clemens Ladisch, Jaroslav Kysela, alsa-devel, linux-kernel
On Sun, 07 Feb 2016 15:14:15 +0100,
Geert Uytterhoeven wrote:
>
> sound/firewire/digi00x/amdtp-dot.c:67: warning: type qualifiers ignored on function return type
>
> Drop the bogus "const" type qualifier on the return type of dot_scrt()
> to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied now, thanks.
Takashi
> ---
> sound/firewire/digi00x/amdtp-dot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/firewire/digi00x/amdtp-dot.c b/sound/firewire/digi00x/amdtp-dot.c
> index b02a5e8cad448c40..0ac92aba5bc1c9a4 100644
> --- a/sound/firewire/digi00x/amdtp-dot.c
> +++ b/sound/firewire/digi00x/amdtp-dot.c
> @@ -63,7 +63,7 @@ struct amdtp_dot {
> #define BYTE_PER_SAMPLE (4)
> #define MAGIC_DOT_BYTE (2)
> #define MAGIC_BYTE_OFF(x) (((x) * BYTE_PER_SAMPLE) + MAGIC_DOT_BYTE)
> -static const u8 dot_scrt(const u8 idx, const unsigned int off)
> +static u8 dot_scrt(const u8 idx, const unsigned int off)
> {
> /*
> * the length of the added pattern only depends on the lower nibble
> --
> 1.9.1
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-09 11:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-07 14:14 [PATCH] ALSA: firewire-digi00x: Drop bogus const type qualifier on dot_scrt() Geert Uytterhoeven
2016-02-08 11:22 ` Takashi Sakamoto
2016-02-09 11:17 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox