[PATCH] docs: ja_JP: Update SubmittingPatches for 'Fixes:' tag

[PATCH] docs: ja_JP: Update SubmittingPatches for 'Fixes:' tag

[kurita]

The Japanese translation of SubmittingPatches is based on an old
kernel version (2.6.39) and is missing several new sections.

This patch adds the missing description for the 'Fixes:' tag to
bring the document more in line with the current English original
(Documentation/process/submitting-patches.rst).

Signed-off-by:Akiyoshi kurita <akito5623@gmail.com>
---
 Documentation/translations/ja_JP/SubmittingPatches | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/translations/ja_JP/SubmittingPatches b/Documentation/translations/ja_JP/SubmittingPatches
index 5334db471744..053468a20841 100644
--- a/Documentation/translations/ja_JP/SubmittingPatches
+++ b/Documentation/translations/ja_JP/SubmittingPatches
@@ -465,6 +465,10 @@ Suggested-by: タグは、パッチのアイデアがその人からの提案に
 クレジットしていけば、望むらくはその人たちが将来別の機会に再度力を貸す気に
 なってくれるかもしれません。
 
+パッチが特定のコミットのバグを修正するものである場合、
+（例えば、``git bisect`` を使用して問題を発見した場合など）、
+SHA-1 ID の最初の 12 文字以上と 1 行の要約を含む「Fixes:」タグを使用してください。
+
 15) 標準的なパッチのフォーマット
 
 標準的なパッチのサブジェクトは以下のとおりです。
-- 
2.47.3

Re: [PATCH] docs: ja_JP: Update SubmittingPatches for 'Fixes:' tag

[Akira Yokosawa]

Hello Kurita-san,

On Wed,  3 Sep 2025 20:35:04 +0900, kurita <akito5623@gmail.com> wrote:
> The Japanese translation of SubmittingPatches is based on an old
> kernel version (2.6.39) and is missing several new sections.
> 
> This patch adds the missing description for the 'Fixes:' tag to
> bring the document more in line with the current English original
> (Documentation/process/submitting-patches.rst).

Assuming this is the first patch you submitted, I'd like to show you
some background.

In 2022, I did some catch-up work for SubmittingPatches in the hopes
of working with another Japanese-speaker.  Unfortunately, I gave up after
he had moved on to other activities.

howto.rst had a couple of updates worked on at the time.

Please see commits:

    6548e96edb50 ("docs/trans/ja_JP/howto: Don't mention specific kernel versions")
    dc8ab0298028 ("docs/ja_JP/howto: Update for v6.1")

, and/or email threads in the lore archive:

    https://lore.kernel.org/20220501102256.6379-1-fujimotokosuke0@gmail.com/
    https://lore.kernel.org/20221030115209.25924-1-akiyks@gmail.com/

If you think it is worthwhile to spend your time in updating the translation,
please feel free to do so.  I'd be glad to play a reviewer's role.

Comments on this particular patch follow (for your future contributions):

> 
> Signed-off-by:Akiyoshi kurita <akito5623@gmail.com>

Malformed "Signed-off-by".

Also, please set up your Git config so that git-send-email uses
a proper From: field.

This mail has:

    From: kurita <akito5623@gmail.com>

, which does not match your sign off.

Both of them would have been pointed out by ./scripts/checkpatch.pl.

> ---
>  Documentation/translations/ja_JP/SubmittingPatches | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/Documentation/translations/ja_JP/SubmittingPatches b/Documentation/translations/ja_JP/SubmittingPatches
> index 5334db471744..053468a20841 100644
> --- a/Documentation/translations/ja_JP/SubmittingPatches
> +++ b/Documentation/translations/ja_JP/SubmittingPatches
> @@ -465,6 +465,10 @@ Suggested-by: タグは、パッチのアイデアがその人からの提案に
>  クレジットしていけば、望むらくはその人たちが将来別の機会に再度力を貸す気に
>  なってくれるかもしれません。
>  
> +パッチが特定のコミットのバグを修正するものである場合、
> +（例えば、``git bisect`` を使用して問題を発見した場合など）、
> +SHA-1 ID の最初の 12 文字以上と 1 行の要約を含む「Fixes:」タグを使用してください。
> +

This doesn't look like the right position in the translation.

I see it comes from commit 8401aa1f5997 ("Documentation/SubmittingPatches:
describe the Fixes: tag"). Quoting relevant hunk below:

> diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
> index 2a8e89e13e45..7e9abb8a276b 100644
> --- a/Documentation/SubmittingPatches
> +++ b/Documentation/SubmittingPatches
> @@ -132,6 +132,20 @@ Example:
>         platform_set_drvdata(), but left the variable "dev" unused,
>         delete it.
>  
> +If your patch fixes a bug in a specific commit, e.g. you found an issue using
> +git-bisect, please use the 'Fixes:' tag with the first 12 characters of the
> +SHA-1 ID, and the one line summary.
> +Example:
> +
> +       Fixes: e21d2170f366 ("video: remove unnecessary platform_set_drvdata()")
> +
> +The following git-config settings can be used to add a pretty format for
> +outputting the above style in the git log or git show commands
> +
> +       [core]
> +               abbrev = 12
> +       [pretty]
> +               fixes = Fixes: %h (\"%s\")

If you'd like to pursue this route, I'd like you to cover all the changes
made in the commit and mention it in the changelog.

Thanks,
Akira

Re: [PATCH] docs: ja_JP: Update SubmittingPatches for 'Fixes:' tag

[Jonathan Corbet]

kurita <akito5623@gmail.com> writes:

> The Japanese translation of SubmittingPatches is based on an old
> kernel version (2.6.39) and is missing several new sections.
>
> This patch adds the missing description for the 'Fixes:' tag to
> bring the document more in line with the current English original
> (Documentation/process/submitting-patches.rst).
>
> Signed-off-by:Akiyoshi kurita <akito5623@gmail.com>
> ---
>  Documentation/translations/ja_JP/SubmittingPatches | 4 ++++
>  1 file changed, 4 insertions(+)

So I only saw this because of Akira's response; something in how you are
sending your mail drives SpamAssassin nuts.

Thank you for working to improve our documentation!

In addition to everything Akira said, I must express a bit of worry
about updating this document piecemeal in this way.  Backporting
specific pieces in this way will yield a result that is not a
translation of anything - it is a new creation that never existed in the
original form.

It sure would be nicer (says the guy who has no ability to do that work)
to bring the translation as a whole current.

I'll accept pieces with acks from people who can properly judge them,
but I would prefer to just have a current translation.

Thanks,

jon

Re: [PATCH] docs: ja_JP: Update SubmittingPatches for 'Fixes:' tag

[Akira Yokosawa]

On Thu, 04 Sep 2025 07:22:37 -0600, Jonathan Corbet wrote:
> kurita <akito5623@gmail.com> writes:
> 
>> The Japanese translation of SubmittingPatches is based on an old
>> kernel version (2.6.39) and is missing several new sections.
>>
>> This patch adds the missing description for the 'Fixes:' tag to
>> bring the document more in line with the current English original
>> (Documentation/process/submitting-patches.rst).
>>
>> Signed-off-by:Akiyoshi kurita <akito5623@gmail.com>
>> ---
>>  Documentation/translations/ja_JP/SubmittingPatches | 4 ++++
>>  1 file changed, 4 insertions(+)
> 
> So I only saw this because of Akira's response; something in how you are
> sending your mail drives SpamAssassin nuts.

It didn't make my Gmail's inbox nor spam folder either.
I only spotted it at the lore archive.

Akiyoshi, I see you have submitted other two versions of this patch already,
but both of them failed to make my inbox.

Your email message at the lore archive has these in its header:

ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com; spf=none smtp.mailfrom=www.redadmin.org; arc=pass smtp.client-ip=49.212.207.181
Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com
Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=www.redadmin.org

The mail-list is probably generous and accepted it.
But Gmail is getting very strict these days.

I'm not going to review your patches until you fix whatever issue
on your (or your ISP?) side.

> 
> Thank you for working to improve our documentation!
> 
> In addition to everything Akira said, I must express a bit of worry
> about updating this document piecemeal in this way.  Backporting
> specific pieces in this way will yield a result that is not a
> translation of anything - it is a new creation that never existed in the
> original form.
> 
> It sure would be nicer (says the guy who has no ability to do that work)
> to bring the translation as a whole current.

Jon, of course that's the ultimate goal.
And that was exactly I did in commit 991dabb24232 ("docs/ja_JP: Convert
SubmitChecklist into reST with belated updates").
I did it because the original check-list has only 137 lines and its
direct translation would have ended up in odd looking one from Japanese
speaker's POV.

Thanks,
Akira

> 
> I'll accept pieces with acks from people who can properly judge them,
> but I would prefer to just have a current translation.
> 
> Thanks,
> 
> jon