* blackfin drivers/net/smc91x.c build error
@ 2008-06-06 16:22 Adrian Bunk
2008-06-06 19:52 ` Mike Frysinger
0 siblings, 1 reply; 9+ messages in thread
From: Adrian Bunk @ 2008-06-06 16:22 UTC (permalink / raw)
To: Bryan Wu, Jeff Garzik; +Cc: netdev, linux-kernel
drivers/net/smc91x.c fails as follows on blackfin:
<-- snip -->
...
CC drivers/net/smc91x.o
...
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/smc91x.c:1863:36: error: macro "SMC_GET_MAC_ADDR" passed 2 arguments, but takes just 1
...
make[3]: *** [drivers/net/smc91x.o] Error 1
<-- snip -->
The required action seems to be a revert of:
commit 099c736a470c8080a166e7a089f1e48e15f9947c
(Revert "smc91x: fix build breakage from the SMC_GET_MAC_ADDR API upgrade") (sic).
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: blackfin drivers/net/smc91x.c build error
2008-06-06 16:22 blackfin drivers/net/smc91x.c build error Adrian Bunk
@ 2008-06-06 19:52 ` Mike Frysinger
2008-06-10 13:53 ` Adrian Bunk
0 siblings, 1 reply; 9+ messages in thread
From: Mike Frysinger @ 2008-06-06 19:52 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Bryan Wu, Jeff Garzik, netdev, linux-kernel
On Fri, Jun 6, 2008 at 12:22 PM, Adrian Bunk <bunk@kernel.org> wrote:
> drivers/net/smc91x.c fails as follows on blackfin:
> ...
> CC drivers/net/smc91x.o
> ...
> /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/smc91x.c:1863:36: error: macro "SMC_GET_MAC_ADDR" passed 2 arguments, but takes just 1
> ...
it's a known issue (been known for quite a long time actually). Bryan
has brought this up in the past already.
-mike
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: blackfin drivers/net/smc91x.c build error
2008-06-06 19:52 ` Mike Frysinger
@ 2008-06-10 13:53 ` Adrian Bunk
2008-06-10 17:13 ` Mike Frysinger
0 siblings, 1 reply; 9+ messages in thread
From: Adrian Bunk @ 2008-06-10 13:53 UTC (permalink / raw)
To: Mike Frysinger; +Cc: Bryan Wu, Jeff Garzik, netdev, linux-kernel
On Fri, Jun 06, 2008 at 03:52:09PM -0400, Mike Frysinger wrote:
> On Fri, Jun 6, 2008 at 12:22 PM, Adrian Bunk <bunk@kernel.org> wrote:
> > drivers/net/smc91x.c fails as follows on blackfin:
> > ...
> > CC drivers/net/smc91x.o
> > ...
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/smc91x.c:1863:36: error: macro "SMC_GET_MAC_ADDR" passed 2 arguments, but takes just 1
> > ...
>
> it's a known issue (been known for quite a long time actually). Bryan
> has brought this up in the past already.
Is my suggestion of reverting commit 099c736a470c8080a166e7a089f1e48e15f9947c
correct or how else should it be resolved?
This issue is the only remaining problem preventing that all blackfin
defconfigs will compile in 2.6.26...
> -mike
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: blackfin drivers/net/smc91x.c build error
2008-06-10 13:53 ` Adrian Bunk
@ 2008-06-10 17:13 ` Mike Frysinger
2008-06-10 17:34 ` Adrian Bunk
0 siblings, 1 reply; 9+ messages in thread
From: Mike Frysinger @ 2008-06-10 17:13 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Bryan Wu, Jeff Garzik, netdev, linux-kernel
On Tue, Jun 10, 2008 at 9:53 AM, Adrian Bunk wrote:
> On Fri, Jun 06, 2008 at 03:52:09PM -0400, Mike Frysinger wrote:
>> On Fri, Jun 6, 2008 at 12:22 PM, Adrian Bunk wrote:
>> > drivers/net/smc91x.c fails as follows on blackfin:
>> > ...
>> > CC drivers/net/smc91x.o
>> > ...
>> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/smc91x.c:1863:36: error: macro "SMC_GET_MAC_ADDR" passed 2 arguments, but takes just 1
>> > ...
>>
>> it's a known issue (been known for quite a long time actually). Bryan
>> has brought this up in the past already.
>
> Is my suggestion of reverting commit 099c736a470c8080a166e7a089f1e48e15f9947c
> correct or how else should it be resolved?
Bryan is taking care of it ... it may just stay broken in favor of
waiting for the merge from the net tree.
> This issue is the only remaining problem preventing that all blackfin
> defconfigs will compile in 2.6.26...
not really true. but otherwise, failures dont go unnoticed as we have
automated nightly builds for all the relevant trees.
-mike
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: blackfin drivers/net/smc91x.c build error
2008-06-10 17:13 ` Mike Frysinger
@ 2008-06-10 17:34 ` Adrian Bunk
2008-06-11 3:37 ` Bryan Wu
0 siblings, 1 reply; 9+ messages in thread
From: Adrian Bunk @ 2008-06-10 17:34 UTC (permalink / raw)
To: Mike Frysinger; +Cc: Bryan Wu, Jeff Garzik, netdev, linux-kernel
On Tue, Jun 10, 2008 at 01:13:52PM -0400, Mike Frysinger wrote:
> On Tue, Jun 10, 2008 at 9:53 AM, Adrian Bunk wrote:
> > On Fri, Jun 06, 2008 at 03:52:09PM -0400, Mike Frysinger wrote:
> >> On Fri, Jun 6, 2008 at 12:22 PM, Adrian Bunk wrote:
> >> > drivers/net/smc91x.c fails as follows on blackfin:
> >> > ...
> >> > CC drivers/net/smc91x.o
> >> > ...
> >> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/smc91x.c:1863:36: error: macro "SMC_GET_MAC_ADDR" passed 2 arguments, but takes just 1
> >> > ...
> >>
> >> it's a known issue (been known for quite a long time actually). Bryan
> >> has brought this up in the past already.
> >
> > Is my suggestion of reverting commit 099c736a470c8080a166e7a089f1e48e15f9947c
> > correct or how else should it be resolved?
>
> Bryan is taking care of it ... it may just stay broken in favor of
> waiting for the merge from the net tree.
>
> > This issue is the only remaining problem preventing that all blackfin
> > defconfigs will compile in 2.6.26...
>
> not really true.
>...
What other build errors do you get in Linus' tree?
> -mike
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: blackfin drivers/net/smc91x.c build error
2008-06-10 17:34 ` Adrian Bunk
@ 2008-06-11 3:37 ` Bryan Wu
2008-06-11 3:43 ` Bryan Wu
2008-06-11 3:47 ` Linus Torvalds
0 siblings, 2 replies; 9+ messages in thread
From: Bryan Wu @ 2008-06-11 3:37 UTC (permalink / raw)
To: Adrian Bunk, Linus Torvalds
Cc: Mike Frysinger, Jeff Garzik, netdev, linux-kernel
On Wed, Jun 11, 2008 at 1:34 AM, Adrian Bunk <bunk@kernel.org> wrote:
> On Tue, Jun 10, 2008 at 01:13:52PM -0400, Mike Frysinger wrote:
>> On Tue, Jun 10, 2008 at 9:53 AM, Adrian Bunk wrote:
>> > On Fri, Jun 06, 2008 at 03:52:09PM -0400, Mike Frysinger wrote:
>> >> On Fri, Jun 6, 2008 at 12:22 PM, Adrian Bunk wrote:
>> >> > drivers/net/smc91x.c fails as follows on blackfin:
>> >> > ...
>> >> > CC drivers/net/smc91x.o
>> >> > ...
>> >> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/smc91x.c:1863:36: error: macro "SMC_GET_MAC_ADDR" passed 2 arguments, but takes just 1
>> >> > ...
>> >>
>> >> it's a known issue (been known for quite a long time actually). Bryan
>> >> has brought this up in the past already.
>> >
>> > Is my suggestion of reverting commit 099c736a470c8080a166e7a089f1e48e15f9947c
>> > correct or how else should it be resolved?
>>
>> Bryan is taking care of it ... it may just stay broken in favor of
>> waiting for the merge from the net tree.
>>
>> > This issue is the only remaining problem preventing that all blackfin
>> > defconfigs will compile in 2.6.26...
>>
>> not really true.
>>...
>
> What other build errors do you get in Linus' tree?
>
Sorry for jumping in later. I reported this issue 2 months ago.
http://lkml.org/lkml/2008/4/7/38
And Adrian is right, we need to revert this patch.
Linus, could you please revert it?
099c736a470c8080a166e7a089f1e48e15f9947c
Or I send a patch out to revert it?
Thanks
-Bryan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: blackfin drivers/net/smc91x.c build error
2008-06-11 3:37 ` Bryan Wu
@ 2008-06-11 3:43 ` Bryan Wu
2008-06-11 3:47 ` Linus Torvalds
1 sibling, 0 replies; 9+ messages in thread
From: Bryan Wu @ 2008-06-11 3:43 UTC (permalink / raw)
To: Adrian Bunk, Linus Torvalds
Cc: Mike Frysinger, Jeff Garzik, netdev, linux-kernel
On Wed, Jun 11, 2008 at 11:37 AM, Bryan Wu <cooloney@kernel.org> wrote:
> On Wed, Jun 11, 2008 at 1:34 AM, Adrian Bunk <bunk@kernel.org> wrote:
>> On Tue, Jun 10, 2008 at 01:13:52PM -0400, Mike Frysinger wrote:
>>> On Tue, Jun 10, 2008 at 9:53 AM, Adrian Bunk wrote:
>>> > On Fri, Jun 06, 2008 at 03:52:09PM -0400, Mike Frysinger wrote:
>>> >> On Fri, Jun 6, 2008 at 12:22 PM, Adrian Bunk wrote:
>>> >> > drivers/net/smc91x.c fails as follows on blackfin:
>>> >> > ...
>>> >> > CC drivers/net/smc91x.o
>>> >> > ...
>>> >> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/net/smc91x.c:1863:36: error: macro "SMC_GET_MAC_ADDR" passed 2 arguments, but takes just 1
>>> >> > ...
>>> >>
>>> >> it's a known issue (been known for quite a long time actually). Bryan
>>> >> has brought this up in the past already.
>>> >
>>> > Is my suggestion of reverting commit 099c736a470c8080a166e7a089f1e48e15f9947c
>>> > correct or how else should it be resolved?
>>>
>>> Bryan is taking care of it ... it may just stay broken in favor of
>>> waiting for the merge from the net tree.
>>>
>>> > This issue is the only remaining problem preventing that all blackfin
>>> > defconfigs will compile in 2.6.26...
>>>
>>> not really true.
>>>...
>>
>> What other build errors do you get in Linus' tree?
>>
>
> Sorry for jumping in later. I reported this issue 2 months ago.
> http://lkml.org/lkml/2008/4/7/38
>
> And Adrian is right, we need to revert this patch.
>
> Linus, could you please revert it?
> 099c736a470c8080a166e7a089f1e48e15f9947c
> Or I send a patch out to revert it?
>
> Thanks
> -Bryan
>
Oh, sorry for the confusing. we need to recommit the patch to fix this
build breakage.
9e6db60825ef7e7999abc610ce256ba768e58162
"smc91x: fix build breakage from the SMC_GET_MAC_ADDR API upgrade"
Jeff, do you have my this patch in your tree or just we revert the
099c736a470c8080a166e7a089f1e48e15f9947c?
Thanks
-Bryan
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: blackfin drivers/net/smc91x.c build error
2008-06-11 3:37 ` Bryan Wu
2008-06-11 3:43 ` Bryan Wu
@ 2008-06-11 3:47 ` Linus Torvalds
2008-06-11 3:55 ` Bryan Wu
1 sibling, 1 reply; 9+ messages in thread
From: Linus Torvalds @ 2008-06-11 3:47 UTC (permalink / raw)
To: Bryan Wu; +Cc: Adrian Bunk, Mike Frysinger, Jeff Garzik, netdev, linux-kernel
On Wed, 11 Jun 2008, Bryan Wu wrote:
>
> Linus, could you please revert it?
> 099c736a470c8080a166e7a089f1e48e15f9947c
> Or I send a patch out to revert it?
I'd like to see a patch, since by now I'm confused by this all whether
it's a straight revert or if there's a fix.
Linus
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: blackfin drivers/net/smc91x.c build error
2008-06-11 3:47 ` Linus Torvalds
@ 2008-06-11 3:55 ` Bryan Wu
0 siblings, 0 replies; 9+ messages in thread
From: Bryan Wu @ 2008-06-11 3:55 UTC (permalink / raw)
To: Linus Torvalds
Cc: Adrian Bunk, Mike Frysinger, Jeff Garzik, netdev, linux-kernel
On Wed, Jun 11, 2008 at 11:47 AM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
>
> On Wed, 11 Jun 2008, Bryan Wu wrote:
>>
>> Linus, could you please revert it?
>> 099c736a470c8080a166e7a089f1e48e15f9947c
>> Or I send a patch out to revert it?
>
> I'd like to see a patch, since by now I'm confused by this all whether
> it's a straight revert or if there's a fix.
>
> Linus
No problem, I will send a patch soon.
-Bryan
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2008-06-11 3:55 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-06 16:22 blackfin drivers/net/smc91x.c build error Adrian Bunk
2008-06-06 19:52 ` Mike Frysinger
2008-06-10 13:53 ` Adrian Bunk
2008-06-10 17:13 ` Mike Frysinger
2008-06-10 17:34 ` Adrian Bunk
2008-06-11 3:37 ` Bryan Wu
2008-06-11 3:43 ` Bryan Wu
2008-06-11 3:47 ` Linus Torvalds
2008-06-11 3:55 ` Bryan Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox