* [PATCH] arm64: dts: qcom: x1e80100: Add the watchdog device
@ 2025-02-06 10:37 Abel Vesa
2025-02-06 10:44 ` Johan Hovold
2025-02-11 15:02 ` Konrad Dybcio
0 siblings, 2 replies; 4+ messages in thread
From: Abel Vesa @ 2025-02-06 10:37 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Rajendra Nayak,
Abel Vesa
From: Rajendra Nayak <quic_rjendra@quicinc.com>
The X Elite implements Server Base System Architecture (SBSA) specification
compliant generic watchdog.
Describe it.
Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
arch/arm64/boot/dts/qcom/x1e80100.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
index 9d38436763432892ceef95daf0335d4cf446357c..007815699e4b9137c3b5cf72263c9dd3a64e6bb3 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
@@ -3708,6 +3708,13 @@ pcie4_phy: phy@1c0e000 {
status = "disabled";
};
+ watchdog@1c840000 {
+ compatible = "arm,sbsa-gwdt";
+ reg = <0 0x1c840000 0 0x1000>,
+ <0 0x1c850000 0 0x1000>;
+ interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
+ };
+
tcsr_mutex: hwlock@1f40000 {
compatible = "qcom,tcsr-mutex";
reg = <0 0x01f40000 0 0x20000>;
---
base-commit: 00f3246adeeacbda0bd0b303604e46eb59c32e6e
change-id: 20250206-x1e80100-add-watchdog-fa8e3d23d760
Best regards,
--
Abel Vesa <abel.vesa@linaro.org>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: x1e80100: Add the watchdog device
2025-02-06 10:37 [PATCH] arm64: dts: qcom: x1e80100: Add the watchdog device Abel Vesa
@ 2025-02-06 10:44 ` Johan Hovold
2025-02-06 13:59 ` Abel Vesa
2025-02-11 15:02 ` Konrad Dybcio
1 sibling, 1 reply; 4+ messages in thread
From: Johan Hovold @ 2025-02-06 10:44 UTC (permalink / raw)
To: Abel Vesa
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
Rajendra Nayak
On Thu, Feb 06, 2025 at 12:37:13PM +0200, Abel Vesa wrote:
> From: Rajendra Nayak <quic_rjendra@quicinc.com>
>
> The X Elite implements Server Base System Architecture (SBSA) specification
> compliant generic watchdog.
>
> Describe it.
>
> Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/x1e80100.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index 9d38436763432892ceef95daf0335d4cf446357c..007815699e4b9137c3b5cf72263c9dd3a64e6bb3 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> @@ -3708,6 +3708,13 @@ pcie4_phy: phy@1c0e000 {
> status = "disabled";
> };
>
> + watchdog@1c840000 {
Please keep the nodes sorted by unit address. Looks like this ones goes
much further down.
> + compatible = "arm,sbsa-gwdt";
> + reg = <0 0x1c840000 0 0x1000>,
> + <0 0x1c850000 0 0x1000>;
> + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
> + };
> +
> tcsr_mutex: hwlock@1f40000 {
> compatible = "qcom,tcsr-mutex";
> reg = <0 0x01f40000 0 0x20000>;
Johan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: x1e80100: Add the watchdog device
2025-02-06 10:44 ` Johan Hovold
@ 2025-02-06 13:59 ` Abel Vesa
0 siblings, 0 replies; 4+ messages in thread
From: Abel Vesa @ 2025-02-06 13:59 UTC (permalink / raw)
To: Johan Hovold
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel,
Rajendra Nayak
On 25-02-06 11:44:18, Johan Hovold wrote:
> On Thu, Feb 06, 2025 at 12:37:13PM +0200, Abel Vesa wrote:
> > From: Rajendra Nayak <quic_rjendra@quicinc.com>
> >
> > The X Elite implements Server Base System Architecture (SBSA) specification
> > compliant generic watchdog.
> >
> > Describe it.
> >
> > Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
> > Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/x1e80100.dtsi | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > index 9d38436763432892ceef95daf0335d4cf446357c..007815699e4b9137c3b5cf72263c9dd3a64e6bb3 100644
> > --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> > @@ -3708,6 +3708,13 @@ pcie4_phy: phy@1c0e000 {
> > status = "disabled";
> > };
> >
> > + watchdog@1c840000 {
>
> Please keep the nodes sorted by unit address. Looks like this ones goes
> much further down.
Oups. Yes, you are right. Will move and respin.
>
> > + compatible = "arm,sbsa-gwdt";
> > + reg = <0 0x1c840000 0 0x1000>,
> > + <0 0x1c850000 0 0x1000>;
> > + interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>;
> > + };
> > +
> > tcsr_mutex: hwlock@1f40000 {
> > compatible = "qcom,tcsr-mutex";
> > reg = <0 0x01f40000 0 0x20000>;
>
> Johan
Thanks for reviewing,
Abel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: x1e80100: Add the watchdog device
2025-02-06 10:37 [PATCH] arm64: dts: qcom: x1e80100: Add the watchdog device Abel Vesa
2025-02-06 10:44 ` Johan Hovold
@ 2025-02-11 15:02 ` Konrad Dybcio
1 sibling, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2025-02-11 15:02 UTC (permalink / raw)
To: Abel Vesa, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Rajendra Nayak
On 6.02.2025 11:37 AM, Abel Vesa wrote:
> From: Rajendra Nayak <quic_rjendra@quicinc.com>
>
> The X Elite implements Server Base System Architecture (SBSA) specification
> compliant generic watchdog.
>
> Describe it.
>
> Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-11 15:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-06 10:37 [PATCH] arm64: dts: qcom: x1e80100: Add the watchdog device Abel Vesa
2025-02-06 10:44 ` Johan Hovold
2025-02-06 13:59 ` Abel Vesa
2025-02-11 15:02 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox