From: Sohil Mehta <sohil.mehta@intel.com>
To: "Ahmed S. Darwish" <darwi@linutronix.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Borislav Petkov <bp@alien8.de>, <x86@kernel.org>,
Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Richard Weinberger <richard@nod.at>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Tony Luck <tony.luck@intel.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] x86/cpu/intel: Simplify F00F bug notice using pr_notice_once()
Date: Fri, 15 May 2026 15:37:23 -0700 [thread overview]
Message-ID: <a538a486-1c7d-48b1-9205-67160e6313d7@intel.com> (raw)
In-Reply-To: <agdwf2m7YZ0b1HKE@lx-t490>
On 5/15/2026 12:14 PM, Ahmed S. Darwish wrote:
Thank you for the reviewing the series.
>> + pr_notice_once("Intel Pentium with F0 0F bug - workaround enabled.\n");
>
> I think you can go further and just remove the whole dmesg line.
>
It's a long-standing user-visible boot message. It doesn't feel worth
removing to save a single line of code. My intention with this series
was to avoid any visible change because of the rarity of these machines.
Unless there is a strong preference I would prefer to leave it in place.
Would it be beneficial for some future rework?
next prev parent reply other threads:[~2026-05-15 22:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 0:24 [PATCH v2 0/3] x86: Fix a F00F bug warning and cleanup surrounding code Sohil Mehta
2026-05-15 0:24 ` [PATCH v2 1/3] x86/cpu/intel: Don't clear X86_BUG_F00F before setting it Sohil Mehta
2026-05-15 19:16 ` Ahmed S. Darwish
2026-05-15 0:24 ` [PATCH v2 2/3] x86/cpu/intel: Simplify F00F bug notice using pr_notice_once() Sohil Mehta
2026-05-15 19:14 ` Ahmed S. Darwish
2026-05-15 22:37 ` Sohil Mehta [this message]
2026-05-15 23:09 ` Ahmed S. Darwish
2026-05-15 23:23 ` Dave Hansen
2026-05-15 0:25 ` [PATCH v2 3/3] x86/cpufeature: Remove clear_cpu_bug() Sohil Mehta
2026-05-15 19:16 ` Ahmed S. Darwish
2026-05-15 6:18 ` [PATCH v2 0/3] x86: Fix a F00F bug warning and cleanup surrounding code Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a538a486-1c7d-48b1-9205-67160e6313d7@intel.com \
--to=sohil.mehta@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=darwi@linutronix.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=richard@nod.at \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox