Re: [PATCH v2 1/3] tools: gpio: use strscpy() for consumer name

Re: [PATCH v2 1/3] tools: gpio: use strscpy() for consumer name

[David Laight]

On Mon,  4 May 2026 15:50:34 +0800
Zhang Xiaolei <zxl434815272@gmail.com> wrote:

> Replace strcpy() with strscpy() to avoid potential buffer overflow
> when copying the consumer string.

You ought to run code before submitting patches.
This wasn't even compiled.

-- David

> 
> Signed-off-by: Zhang Xiaolei <zxl434815272@gmail.com>
> ---
>  tools/gpio/gpio-utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/gpio/gpio-utils.c b/tools/gpio/gpio-utils.c
> index 4096bcd511d1..176bccfcccb0 100644
> --- a/tools/gpio/gpio-utils.c
> +++ b/tools/gpio/gpio-utils.c
> @@ -82,7 +82,7 @@ int gpiotools_request_line(const char *device_name, unsigned int *lines,
>  		req.offsets[i] = lines[i];
>  
>  	req.config = *config;
> -	strcpy(req.consumer, consumer);
> +	strcpy(req.consumer, consumer, sizeof(req.consumer));
>  	req.num_lines = num_lines;
>  
>  	ret = ioctl(fd, GPIO_V2_GET_LINE_IOCTL, &req);

Re: [PATCH v2 2/3] tools: gpio: validate arguments in gpiotools_request_line

[Maxwell Doose]

On Mon, May 4, 2026 at 2:56 AM Zhang Xiaolei <zxl434815272@gmail.com> wrote:
>
> Add validation for input pointers and number of lines.
>

Perhaps make the commit message more descriptive?

>
> Signed-off-by: Zhang Xiaolei <zxl434815272@gmail.com>
> ---
>  tools/gpio/gpio-utils.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/tools/gpio/gpio-utils.c b/tools/gpio/gpio-utils.c
> index 176bccfcccb0..930a38fe7911 100644
> --- a/tools/gpio/gpio-utils.c
> +++ b/tools/gpio/gpio-utils.c
> @@ -65,6 +65,12 @@ int gpiotools_request_line(const char *device_name, unsigned int *lines,
>         int i;
>         int ret;
>
> +       if (!device_name || !lines || !config || !consumer || !num_lines)
> +               return -EINVAL;
> +
> +       if (num_lines > GPIO_V2_LINES_MAX)
> +               return -EINVAL;
> +

I'm wondering if we might want to use ERANGE here for the num_lines >
GPIO_V2_LINES_MAX check instead of EINVAL.

best regards,
maxwell

Re: [PATCH v2 3/3] tools: gpio: fix ioctl name in error message

[Maxwell Doose]

Hi Zhang,

On Mon, May 4, 2026 at 2:56 AM Zhang Xiaolei <zxl434815272@gmail.com> wrote:
>
> Use the correct ioctl name in the error message.
>
> Signed-off-by: Zhang Xiaolei <zxl434815272@gmail.com>
> ---
>  tools/gpio/gpio-utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
[snip]

Patch looks technically good but when I meant split these patches I
meant into entirely separate patches. Please split this away from the
patch series.

best regards,
max

Re: [PATCH v2 1/3] tools: gpio: use strscpy() for consumer name

[007]

OK, I will check it next time, thanks for the reminder.

Best regards

Zhang Xiaolei


On 5/4/26 20:45, David Laight wrote:
> On Mon,  4 May 2026 15:50:34 +0800
> Zhang Xiaolei <zxl434815272@gmail.com> wrote:
>
>> Replace strcpy() with strscpy() to avoid potential buffer overflow
>> when copying the consumer string.
> You ought to run code before submitting patches.
> This wasn't even compiled.
>
> -- David
>
>> Signed-off-by: Zhang Xiaolei <zxl434815272@gmail.com>
>> ---
>>   tools/gpio/gpio-utils.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/gpio/gpio-utils.c b/tools/gpio/gpio-utils.c
>> index 4096bcd511d1..176bccfcccb0 100644
>> --- a/tools/gpio/gpio-utils.c
>> +++ b/tools/gpio/gpio-utils.c
>> @@ -82,7 +82,7 @@ int gpiotools_request_line(const char *device_name, unsigned int *lines,
>>   		req.offsets[i] = lines[i];
>>   
>>   	req.config = *config;
>> -	strcpy(req.consumer, consumer);
>> +	strcpy(req.consumer, consumer, sizeof(req.consumer));
>>   	req.num_lines = num_lines;
>>   
>>   	ret = ioctl(fd, GPIO_V2_GET_LINE_IOCTL, &req);

Re: [PATCH v2 3/3] tools: gpio: fix ioctl name in error message

[007]

Hi, bro, I will redo it, thanks for the reminder.

Best regards

Zhang Xiaolei

On 5/5/26 01:47, Maxwell Doose wrote:
> Hi Zhang,
>
> On Mon, May 4, 2026 at 2:56 AM Zhang Xiaolei <zxl434815272@gmail.com> wrote:
>> Use the correct ioctl name in the error message.
>>
>> Signed-off-by: Zhang Xiaolei <zxl434815272@gmail.com>
>> ---
>>   tools/gpio/gpio-utils.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
> [snip]
>
> Patch looks technically good but when I meant split these patches I
> meant into entirely separate patches. Please split this away from the
> patch series.
>
> best regards,
> max

Re: [PATCH v2 2/3] tools: gpio: validate arguments in gpiotools_request_line

[007]

OK, I will redo it, thanks.

Best regards,

Zhang Xiaolei

On 5/5/26 00:13, Maxwell Doose wrote:
> On Mon, May 4, 2026 at 2:56 AM Zhang Xiaolei <zxl434815272@gmail.com> wrote:
>> Add validation for input pointers and number of lines.
>>
> Perhaps make the commit message more descriptive?
>
>> Signed-off-by: Zhang Xiaolei <zxl434815272@gmail.com>
>> ---
>>   tools/gpio/gpio-utils.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/tools/gpio/gpio-utils.c b/tools/gpio/gpio-utils.c
>> index 176bccfcccb0..930a38fe7911 100644
>> --- a/tools/gpio/gpio-utils.c
>> +++ b/tools/gpio/gpio-utils.c
>> @@ -65,6 +65,12 @@ int gpiotools_request_line(const char *device_name, unsigned int *lines,
>>          int i;
>>          int ret;
>>
>> +       if (!device_name || !lines || !config || !consumer || !num_lines)
>> +               return -EINVAL;
>> +
>> +       if (num_lines > GPIO_V2_LINES_MAX)
>> +               return -EINVAL;
>> +
> I'm wondering if we might want to use ERANGE here for the num_lines >
> GPIO_V2_LINES_MAX check instead of EINVAL.
>
> best regards,
> maxwell

[PATCH v3] tools: gpio: fix ioctl name in error message

[Zhang Xiaolei]

Use the correct ioctl name in the error message.

Signed-off-by: Zhang Xiaolei <zxl434815272@gmail.com>
---
 tools/gpio/gpio-utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/gpio/gpio-utils.c b/tools/gpio/gpio-utils.c
index 930a38fe7911..0d52d58cc6b6 100644
--- a/tools/gpio/gpio-utils.c
+++ b/tools/gpio/gpio-utils.c
@@ -95,7 +95,7 @@ int gpiotools_request_line(const char *device_name, unsigned int *lines,
 	if (ret == -1) {
 		ret = -errno;
 		fprintf(stderr, "Failed to issue %s (%d), %s\n",
-			"GPIO_GET_LINE_IOCTL", ret, strerror(errno));
+			"GPIO_V2_GET_LINE_IOCTL", ret, strerror(errno));
 	}
 
 	if (close(fd) == -1)
-- 
2.34.1