From: Andrea Righi <arighi@nvidia.com>
To: K Prateek Nayak <kprateek.nayak@amd.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Christian Loehle <christian.loehle@arm.com>,
Koba Ko <kobak@nvidia.com>,
Felix Abecassis <fabecassis@nvidia.com>,
Balbir Singh <balbirs@nvidia.com>,
Joel Fernandes <joelagnelf@nvidia.com>,
Shrikanth Hegde <sshegde@linux.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] sched/fair: Make asym CPU capacity idle rank values self-documenting
Date: Fri, 24 Apr 2026 07:19:16 +0200 [thread overview]
Message-ID: <aer9VPHLTK-6LGgN@gpd4> (raw)
In-Reply-To: <c2800e56-336f-417b-9c74-6f3d06d73074@amd.com>
Hi Prateek,
On Fri, Apr 24, 2026 at 09:59:42AM +0530, K Prateek Nayak wrote:
> Hello Andrea,
>
> On 4/23/2026 1:06 PM, Andrea Righi wrote:
> > From: K Prateek Nayak <kprateek.nayak@amd.com>
> >
> > Introduce enum asym_fits_state for select_idle_capacity() scan
> > preferences, instead of using raw constants to improve readability.
> >
> > No functional change.
> >
> > Signed-off-by: K Prateek Nayak <kprateek.nayak@amd.com>
>
> All I did was suggest an enum; You did all the work on this :-)
Well, actually you wrote the code, I wrote the patch description. :)
> I think this can be squashed into Patch 3 and that way we have we
> can avoid the magic numbers from the get-go. Thoughts?
Yeah, that's probably better, no reason to have a separate patch. I'll do that
in the next version.
Thanks,
-Andrea
next prev parent reply other threads:[~2026-04-24 5:19 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 7:36 [PATCH v3 0/5] sched/fair: SMT-aware asymmetric CPU capacity Andrea Righi
2026-04-23 7:36 ` [PATCH 1/5] sched/fair: Attach sched_domain_shared to sd_asym_cpucapacity Andrea Righi
2026-04-24 5:14 ` K Prateek Nayak
2026-04-24 8:46 ` Andrea Righi
2026-04-24 11:18 ` K Prateek Nayak
2026-04-24 23:29 ` Andrea Righi
2026-04-23 7:36 ` [PATCH 2/5] sched/fair: Prefer fully-idle SMT cores in asym-capacity idle selection Andrea Righi
2026-04-24 5:42 ` K Prateek Nayak
2026-04-23 7:36 ` [PATCH 3/5] sched/fair: Reject misfit pulls onto busy SMT siblings on asym-capacity Andrea Righi
2026-04-24 5:37 ` K Prateek Nayak
2026-04-24 9:21 ` Andrea Righi
2026-04-23 7:36 ` [PATCH 4/5] sched/fair: Add SIS_UTIL support to select_idle_capacity() Andrea Righi
2026-04-24 5:55 ` K Prateek Nayak
2026-04-24 12:32 ` Vincent Guittot
2026-04-24 17:13 ` Andrea Righi
2026-04-27 5:13 ` K Prateek Nayak
2026-04-27 8:35 ` Vincent Guittot
2026-04-27 16:01 ` Andrea Righi
2026-04-27 17:26 ` Vincent Guittot
2026-04-23 7:36 ` [PATCH 5/5] sched/fair: Make asym CPU capacity idle rank values self-documenting Andrea Righi
2026-04-24 4:29 ` K Prateek Nayak
2026-04-24 5:19 ` Andrea Righi [this message]
2026-04-24 12:34 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aer9VPHLTK-6LGgN@gpd4 \
--to=arighi@nvidia.com \
--cc=balbirs@nvidia.com \
--cc=bsegall@google.com \
--cc=christian.loehle@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=fabecassis@nvidia.com \
--cc=joelagnelf@nvidia.com \
--cc=juri.lelli@redhat.com \
--cc=kobak@nvidia.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sshegde@linux.ibm.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox