From: Arun Menon <armenon@redhat.com>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org,
Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [RFC v2 4/5] tpm: Increase TPM_BUFSIZE to 8kB for chunking support
Date: Wed, 13 May 2026 16:39:24 +0530 [thread overview]
Message-ID: <agRb5FClggBcNvGe@fedora> (raw)
In-Reply-To: <af9KnU90yMf8MxnQ@kernel.org>
On Sat, May 09, 2026 at 05:54:21PM +0300, Jarkko Sakkinen wrote:
> On Tue, Mar 24, 2026 at 11:42:43PM +0530, Arun Menon wrote:
> > The size of the command is checked against TPM_BUFSIZE early on before
> > even sending it to the backend. We therefore need to increase the
> > TPM_BUFSIZE to allow support for larger commands.
> >
> > For now, 8KB seems sufficient for ML-KEM and ML-DSA algorithms and it is
> > also order-1 safe.
> >
> > Signed-off-by: Arun Menon <armenon@redhat.com>
> > ---
> > drivers/char/tpm/tpm.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h
> > index 87d68ddf270a7..26c3765fbd732 100644
> > --- a/drivers/char/tpm/tpm.h
> > +++ b/drivers/char/tpm/tpm.h
> > @@ -33,7 +33,7 @@
> > #endif
> >
> > #define TPM_MINOR 224 /* officially assigned */
> > -#define TPM_BUFSIZE 4096
> > +#define TPM_BUFSIZE 8192
> > #define TPM_NUM_DEVICES 65536
> > #define TPM_RETRY 50
> >
> > --
> > 2.53.0
> >
>
> Shouldn't this prepend previous patch?
yes, I am going to put this and the i2c patch before the chunking logic.
Thanks.
>
> BR, Jarkko
>
Regards,
Arun Menon
prev parent reply other threads:[~2026-05-13 11:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260324181244.17741-1-armenon@redhat.com>
[not found] ` <20260324181244.17741-2-armenon@redhat.com>
2026-05-09 14:41 ` [RFC v2 1/5] tpm_crb: Add register definitions of TPM CRB chunking fields Jarkko Sakkinen
[not found] ` <20260324181244.17741-3-armenon@redhat.com>
2026-05-09 14:43 ` [RFC v2 2/5] tpm_crb: Add new wrapper function to invoke start method Jarkko Sakkinen
2026-05-13 11:08 ` Arun Menon
[not found] ` <20260324181244.17741-4-armenon@redhat.com>
2026-05-09 14:53 ` [RFC v2 3/5] tpm_crb: Implement command and response chunking logic Jarkko Sakkinen
2026-05-13 11:07 ` Arun Menon
[not found] ` <20260324181244.17741-5-armenon@redhat.com>
2026-05-09 14:54 ` [RFC v2 4/5] tpm: Increase TPM_BUFSIZE to 8kB for chunking support Jarkko Sakkinen
2026-05-09 15:07 ` Jarkko Sakkinen
2026-05-13 11:06 ` Arun Menon
2026-05-13 11:09 ` Arun Menon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agRb5FClggBcNvGe@fedora \
--to=armenon@redhat.com \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox