[PATCH] dm: crash dump: remove redundant NULL check before kvfree()

[PATCH] dm: crash dump: remove redundant NULL check before kvfree()

[mdshahid03]

From: Mohammad Shahid <mdshahid03@gmail.com>

kvfree() safely handles NULL pointers, so the explicit NULL check
before calling kvfree() is unnecessary.

This issue was reported by ifnullfree.cocci.

Signed-off-by: Mohammad Shahid <mdshahid03@gmail.com>
---
 kernel/crash_dump_dm_crypt.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/kernel/crash_dump_dm_crypt.c b/kernel/crash_dump_dm_crypt.c
index cb875ddb6ba6..cf4d41fd4d5e 100644
--- a/kernel/crash_dump_dm_crypt.c
+++ b/kernel/crash_dump_dm_crypt.c
@@ -364,8 +364,7 @@ static int build_keys_header(void)
 	struct config_key *key;
 	int i, r;
 
-	if (keys_header != NULL)
-		kvfree(keys_header);
+	kvfree(keys_header);
 
 	keys_header = kzalloc(get_keys_header_size(key_count), GFP_KERNEL);
 	if (!keys_header)
-- 
2.43.0

Re: [PATCH] dm: crash dump: remove redundant NULL check before kvfree()

[Pratyush Yadav]

On Fri, Jul 03 2026, mdshahid03@gmail.com wrote:

> From: Mohammad Shahid <mdshahid03@gmail.com>
>
> kvfree() safely handles NULL pointers, so the explicit NULL check
> before calling kvfree() is unnecessary.
>
> This issue was reported by ifnullfree.cocci.
>
> Signed-off-by: Mohammad Shahid <mdshahid03@gmail.com>

Reviewed-by: Pratyush Yadav <pratyush@kernel.org>

BTW, Sashiko [0] pointed out a bunch of problems in the surrounding code,
and they seem to look legit. If you're interested, help in fixing them
would be much appreciated.

[0] https://sashiko.dev/#/patchset/20260703112642.65498-1-mdshahid03@gmail.com

[...]

-- 
Regards,
Pratyush Yadav

Re: [PATCH] dm: crash dump: remove redundant NULL check before kvfree()

[Coiby Xu]

On Fri, Jul 03, 2026 at 02:03:32PM +0200, Pratyush Yadav wrote:
>On Fri, Jul 03 2026, mdshahid03@gmail.com wrote:
>
>> From: Mohammad Shahid <mdshahid03@gmail.com>
>>
>> kvfree() safely handles NULL pointers, so the explicit NULL check
>> before calling kvfree() is unnecessary.
>>
>> This issue was reported by ifnullfree.cocci.
>>
>> Signed-off-by: Mohammad Shahid <mdshahid03@gmail.com>
>
>Reviewed-by: Pratyush Yadav <pratyush@kernel.org>

Hi Pratyush,

Thanks for reviewing this patch!

>
>BTW, Sashiko [0] pointed out a bunch of problems in the surrounding code,
>and they seem to look legit. If you're interested, help in fixing them
>would be much appreciated.
>
>[0] https://sashiko.dev/#/patchset/20260703112642.65498-1-mdshahid03@gmail.com

I'll send a new version of
https://lore.kernel.org/kexec/20260501234342.2518281-1-coiby.xu@gmail.com/
soon which can address Sashiko's feedback scrutinized by Sourabh.

>
>[...]
>
>-- 
>Regards,
>Pratyush Yadav
>

-- 
Best regards,
Coiby

Re: [PATCH] dm: crash dump: remove redundant NULL check before kvfree()

[Pratyush Yadav]

On Fri, Jul 03 2026, Coiby Xu wrote:

> On Fri, Jul 03, 2026 at 02:03:32PM +0200, Pratyush Yadav wrote:
>>On Fri, Jul 03 2026, mdshahid03@gmail.com wrote:
>>
>>> From: Mohammad Shahid <mdshahid03@gmail.com>
>>>
>>> kvfree() safely handles NULL pointers, so the explicit NULL check
>>> before calling kvfree() is unnecessary.
>>>
>>> This issue was reported by ifnullfree.cocci.
>>>
>>> Signed-off-by: Mohammad Shahid <mdshahid03@gmail.com>
>>
>>Reviewed-by: Pratyush Yadav <pratyush@kernel.org>
>
> Hi Pratyush,
>
> Thanks for reviewing this patch!
>
>>
>>BTW, Sashiko [0] pointed out a bunch of problems in the surrounding code,
>>and they seem to look legit. If you're interested, help in fixing them
>>would be much appreciated.
>>
>>[0] https://sashiko.dev/#/patchset/20260703112642.65498-1-mdshahid03@gmail.com
>
> I'll send a new version of
> https://lore.kernel.org/kexec/20260501234342.2518281-1-coiby.xu@gmail.com/
> soon which can address Sashiko's feedback scrutinized by Sourabh.

Oh, great. Thanks!

-- 
Regards,
Pratyush Yadav