From: Sean Christopherson <seanjc@google.com>
To: Jim Mattson <jmattson@google.com>
Cc: Yosry Ahmed <yosry@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Maxim Levitsky <mlevitsk@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 02/25] KVM: SVM: Passthrough the number of supported ASIDs
Date: Wed, 22 Jul 2026 15:09:32 -0700 [thread overview]
Message-ID: <amE_nPDem-imSfqF@google.com> (raw)
In-Reply-To: <CALMp9eRGx=K+UBp76A=dZ=bD_Txonq7j8pSn9HVczdtyyuAs3Q@mail.gmail.com>
On Tue, Jul 14, 2026, Jim Mattson wrote:
> On Tue, Jul 14, 2026 at 4:41 PM Sean Christopherson <seanjc@google.com> wrote:
>
> > What complications? Advertise the lowest common feature set for the pool, just
> > like userspace has to do for literally every other feature.
>
> The problem with passing through the number of host ASIDs to the guest
> is what to do when the combined host plus guest usage exceeds the
> number of available ASIDs, particularly when FlushByASID is not
> available.
But that doesn't have anything to do with the number of ASIDs that KVM enumerates
to L1. As of this series, the number ASIDs KVM will consume in hardware is a
property of the total number of vCPUs in the system (one ASID per vCPU, plus one
more for nested usage). E.g. if KVM advertises 10000 ASIDs to L1, all 10000
(10001, if ASID=0 counts?) of the those ASIDs will map to svm->nested.asid02.
Of course, that completely undermines my statement about suboptimal performance:
And potentially suboptimal for performance. There might be a legitimate reason
why a CPU generation advertises X instead of Y.
My bogus assertion about performance notwithstanding, I still think advertising
what hardware supports is the simple, sane approach. Because at the end of the
day it's just that: advertising. Userspace can do whatever it wants, including
peeking at raw CPUID. E.g. if we want to pull a stupid and emulate the behavior
of ignoring "unsupported" ASIDs, then we'd need to do that based on userspace's
defined CPUID model, not KVM's advertised support.
next prev parent reply other threads:[~2026-07-22 22:09 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-16 0:41 [RFC PATCH v2 00/25] Optimize nSVM TLB flushes Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 01/25] KVM: nSVM: Flush the TLB after forcefully leaving nested Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 02/25] KVM: SVM: Passthrough the number of supported ASIDs Yosry Ahmed
2026-07-14 13:20 ` Yosry Ahmed
2026-07-14 21:28 ` Jim Mattson
2026-07-14 21:43 ` Yosry Ahmed
2026-07-14 23:41 ` Sean Christopherson
2026-07-15 6:32 ` Jim Mattson
2026-07-15 17:45 ` Yosry Ahmed
2026-07-15 18:20 ` Jim Mattson
2026-07-15 19:12 ` Yosry Ahmed
2026-07-16 23:09 ` Jim Mattson
2026-07-22 22:09 ` Sean Christopherson [this message]
2026-07-22 22:39 ` Jim Mattson
2026-07-23 0:27 ` Sean Christopherson
2026-07-23 2:46 ` Jim Mattson
2026-07-15 17:41 ` Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 03/25] KVM: VMX: Generalize VPID allocation to be vendor-neutral Yosry Ahmed
2026-07-22 22:26 ` Sean Christopherson
2026-07-22 22:36 ` Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 04/25] KVM: x86/mmu: Support specifying a minimum TLB tag Yosry Ahmed
2026-07-23 0:28 ` Sean Christopherson
2026-07-23 5:00 ` Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 05/25] KVM: SVM: Add helpers to set/clear ASID flush in VMCB Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 06/25] KVM: SVM: Fallback to flush everything if FLUSHBYASID is not available Yosry Ahmed
2026-07-23 0:29 ` Sean Christopherson
2026-06-16 0:41 ` [RFC PATCH v2 07/25] KVM: SVM: Duplicate pre-run ASID check for SEV and non-SEV guests Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 08/25] KVM: SEV: Stop using per-vCPU ASID for SEV VMs Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 09/25] KVM: SVM: Use a static ASID per vCPU Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 10/25] KVM: nSVM: Add a placeholder ASID for L2 Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 11/25] KVM: x86: hyper-v: Rename kvm_hv_vcpu_purge_flush_tlb() Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 12/25] KVM: x86: hyper-v: Allow puring all TLB flush FIFOs Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 13/25] KVM: nSVM: Flush both L1 and L2 ASIDs on KVM_REQ_TLB_FLUSH Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 14/25] KVM: nSVM: Move svm_switch_vmcb() to nested.c Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 15/25] KVM: nSVM: Call nested_svm_transition_tlb_flush() on every VMCB switch Yosry Ahmed
2026-07-23 0:42 ` Sean Christopherson
2026-07-23 5:07 ` Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 16/25] KVM: nSVM: Split nested_svm_transition_tlb_flush() into entry/exit fns Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 17/25] KVM: nSVM: Service local TLB flushes before nested transitions Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 18/25] KVM: nSVM: Handle nested TLB flush requests through TLB_CONTROL Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 19/25] KVM: nSVM: Flush the TLB if L1 changes L2's ASID in vmcb12 Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 20/25] KVM: nSVM: Do not reset TLB_CONTROL in vmcb02 on nested VM-Enter Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 21/25] KVM: x86/mmu: rename __kvm_mmu_invalidate_addr() Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 22/25] KVM: x86/mmu: Refactor kvm_mmu_invlpg() to allow skipping the gva flush Yosry Ahmed
2026-07-23 0:53 ` Sean Christopherson
2026-07-23 0:56 ` Sean Christopherson
2026-07-23 5:11 ` Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 23/25] KVM: nSVM: Flush L2's ASID when emulating INVLPGA Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 24/25] KVM: nSVM: Use different ASIDs for L1 and L2 Yosry Ahmed
2026-06-16 0:41 ` [RFC PATCH v2 25/25] DO NOT MERGE: Add nested_tlb_force_flush Yosry Ahmed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amE_nPDem-imSfqF@google.com \
--to=seanjc@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=pbonzini@redhat.com \
--cc=thomas.lendacky@amd.com \
--cc=vkuznets@redhat.com \
--cc=yosry@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox