From: Oleg Nesterov <oleg@redhat.com>
To: Joel Granados <joel.granados@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
Kees Cook <kees@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH sysctl-next 2/2] sysctl: remove redundant CONFIG_PROC_FS checks
Date: Mon, 10 Aug 2026 14:07:33 +0200 [thread overview]
Message-ID: <anm_BTMPz9nPWy-n@redhat.com> (raw)
In-Reply-To: <3dr7rtndzf2zhdtyfea6x5k76ccczup5icxm6odrkcnicdz7hh@ftlaoeoq6sqk>
Hi Joel,
On 08/10, Joel Granados wrote:
>
> On Fri, Aug 07, 2026 at 05:48:11PM +0200, Oleg Nesterov wrote:
> > --- a/drivers/parport/procfs.c
> > +++ b/drivers/parport/procfs.c
> > @@ -26,9 +26,9 @@
> >
> > #include <linux/uaccess.h>
> >
> > -#if defined(CONFIG_SYSCTL) && defined(CONFIG_PROC_FS)
> > +#ifdef CONFIG_SYSCTL
> >
> > -#define PARPORT_MIN_TIMESLICE_VALUE 1ul
> > +#define PARPORT_MIN_TIMESLICE_VALUE 1ul
>
> Nit: Please remove the formatting changes from the series.
Hmm. I replaced "#if defined(CONFIG_SYSCTL)" with "#ifdef CONFIG_SYSCTL"
because the latter matches the rest of this file which uses "#ifdef", not
"#if defined(...)" elsewhere...
Plus I removed the extra whitespace after eol in the next line.
What exactly you want me to revert in this cleanup?
In any case, I'd be happy to send V2. But I am travelling without
my work laptop, I can only do this when I return on Aug 19.
Thanks!
Oleg.
next prev parent reply other threads:[~2026-08-10 12:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 15:47 [PATCH sysctl-next 1/2] sysctl: collapse redundant CONFIG_SYSCTL nesting in kernel/sysctl.c Oleg Nesterov
2026-08-07 15:48 ` [PATCH sysctl-next 2/2] sysctl: remove redundant CONFIG_PROC_FS checks Oleg Nesterov
2026-08-07 18:01 ` Bradley Morgan
2026-08-10 10:58 ` Joel Granados
2026-08-10 12:07 ` Oleg Nesterov [this message]
2026-08-07 17:16 ` [PATCH sysctl-next 1/2] sysctl: collapse redundant CONFIG_SYSCTL nesting in kernel/sysctl.c Bradley Morgan
2026-08-10 11:08 ` Joel Granados
2026-08-10 12:24 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anm_BTMPz9nPWy-n@redhat.com \
--to=oleg@redhat.com \
--cc=brauner@kernel.org \
--cc=broonie@kernel.org \
--cc=jack@suse.cz \
--cc=joel.granados@kernel.org \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox