Re: [PATCH sysctl-next 1/2] sysctl: collapse redundant CONFIG_SYSCTL nesting in kernel/sysctl.c

[Oleg Nesterov <oleg@redhat.com>]

On 08/10, Joel Granados wrote:
>
> This looks very nice, but now that you are there, I would propose an
> additional change:
>
> 1. I would move the proc_do_static_key function and the definition of
>    the sysctl_subsys_table into the first CONFIG_SYSCTL definition
>    section; right after proc_do_large_bitmap
>
> 2. Doing one means that there is only one #ifdef CONFIG_SYSCTL
>
> 3. Add a proc_do_static_key stub to the #else section; something like
>    this:
>
>   int proc_do_static_key(const struct ctl_table *table, int dir,
>                          void *buffer, size_t *lenp, loff_t *ppos)
>   {
>     return -ENOSYS;
>   }

Yeees, and I thought about this too ;) Just I decided to send the
minimal and trivial cleanup. Except right now I am not 100% sure
about 3. because I can't read the source code now...

Again, I'd be happy to send V2, but only after I return from PTO on
Aug 19.

But let me ask... Do you want me to incorporate this additional change
into 1/2 or send it as a separate change? I'd prefer the latter, but
I am fine either way.

Oleg.