Re: [LTP] [PATCH] Fix a surprising error in cacheflush01 test

Re: [LTP] [PATCH] Fix a surprising error in cacheflush01 test

[Mike Frysinger]

[-- Attachment #1.1: Type: text/plain, Size: 518 bytes --]

On Friday 19 June 2009 10:13:25 Jiri Palecek > wrote:
> this patch fixes a strange build failure in the cacheflush test. Also, it
> makes the condition where it is build a little broader.

a little too broad -- you probably broke arm systems with this as they define 
__NR_cacheflush but not asm/cachectl.h

> -#if defined __mips__
> +
> +#if defined __NR_cacheflush
>  #include <asm/cachectl.h>

for using the systemcall you should use __NR_cacheflush.  for the header, you 
should use autoconf.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 79 bytes --]

------------------------------------------------------------------------------

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

Re: [LTP] [PATCH] Fix a surprising error in cacheflush01 test

[Subrata Modak]

Satus-quo unchanged. I think this was meant to be only for mips, so, why
even try to see if it can build on others ?

Regards--
Subrata

On Tue, 2009-06-23 at 17:12 -0400, Mike Frysinger wrote: 
> On Friday 19 June 2009 10:13:25 Jiri Palecek > wrote:
> > this patch fixes a strange build failure in the cacheflush test. Also, it
> > makes the condition where it is build a little broader.
> 
> a little too broad -- you probably broke arm systems with this as they define 
> __NR_cacheflush but not asm/cachectl.h
> 
> > -#if defined __mips__
> > +
> > +#if defined __NR_cacheflush
> >  #include <asm/cachectl.h>
> 
> for using the systemcall you should use __NR_cacheflush.  for the header, you 
> should use autoconf.
> -mike
> ------------------------------------------------------------------------------
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list


------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

[LTP] [PATCH] Fix a surprising error in cacheflush01 test

[Jiri Palecek >]

Hello,

this patch fixes a strange build failure in the cacheflush test. Also, it makes the condition where it is build a little broader.

Regards
   Jiri Palecek

Signed-off-by: Jiri Palecek <jpalecek@web.de>
---
 .../kernel/syscalls/cacheflush/cacheflush01.c      |    7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/testcases/kernel/syscalls/cacheflush/cacheflush01.c b/testcases/kernel/syscalls/cacheflush/cacheflush01.c
index cc2fd72..6d1c5f5 100644
--- a/testcases/kernel/syscalls/cacheflush/cacheflush01.c
+++ b/testcases/kernel/syscalls/cacheflush/cacheflush01.c
@@ -45,11 +45,12 @@
 #include <stdlib.h>
 #include <errno.h>
 
-#if defined __mips__
+
+#if defined __NR_cacheflush
 #include <asm/cachectl.h>
 int cacheflush(char *addr, int nbytes, int cache)
 {
-B  B  B  B return syscall(__NR_cacheflush, addr, nbytes, cache);
+	return syscall(__NR_cacheflush, addr, nbytes, cache);
 }
 #endif /* __mips__ */
 
@@ -77,7 +78,7 @@ char *TCID = "cacheflush01";  /* Test program identifier.*/
 int  testno;
 int  TST_TOTAL = 1;                   /* total number of tests in this file.   */
 
-#if defined __mips__
+#if defined __NR_cacheflush
 /* Extern Global Functions */
 /******************************************************************************/
 /*                                                                            */
-- 
1.6.3.1




------------------------------------------------------------------------------
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list