[LTP] [PATCH v2 1/1] ioctl_pidfd06: Update kernel version

[LTP] [PATCH v2 1/1] ioctl_pidfd06: Update kernel version

[Petr Vorel]

Kernel commit ab89060fbc92e ("pidfs: return -EREMOTE when PIDFD_GET_INFO
is called on another ns") from v7.0 was backported into stable/LTS
kernels v6.18.14 (7446125afb6d9) and v6.19.10 (2920abaf56c09).
Update errnos for these stable/LTS kernels (do not treat older behavior
as an error).

Follow-up: f630471a6520 ("ioctl_pidfd06: Select expected errno for PIDFD_GET_INFO across pidns")
Reported-by: Wei Gao <wegao@suse.com>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Alternative approach for Wei's fix:
https://patchwork.ozlabs.org/project/ltp/patch/20260406023538.14739-1-wegao@suse.com/
https://lore.kernel.org/ltp/20260406023538.14739-1-wegao@suse.com/

Changes v1->v2:
* Cover also 6.19.0..v6.19.9
* Add Follow-up: tag (not Fixme: tag), commit was correct at the time.

Link to v1:
https://patchwork.ozlabs.org/project/ltp/patch/20260424060543.462475-1-pvorel@suse.cz/
https://lore.kernel.org/ltp/20260424095900.GA500158@pevik/T/#t

 testcases/kernel/syscalls/ioctl/ioctl_pidfd06.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/testcases/kernel/syscalls/ioctl/ioctl_pidfd06.c b/testcases/kernel/syscalls/ioctl/ioctl_pidfd06.c
index 0f24d4741f..bc90aafd17 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl_pidfd06.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl_pidfd06.c
@@ -54,7 +54,12 @@ static void setup(void)
 	if (!ioctl_pidfd_info_exit_supported())
 		tst_brk(TCONF, "PIDFD_INFO_EXIT is not supported by ioctl()");
 
-	if (tst_kvercmp(7, 0, 0) >= 0)
+	/*
+	 * ab89060fbc92e ("pidfs: return -EREMOTE when PIDFD_GET_INFO is called on another ns")
+	 * from v7.0, backported to v6.18.14 and v6.19.10.
+	 */
+	if (tst_kvercmp(6, 19, 10) >= 0 ||
+	    (tst_kvercmp(6, 18, 14) >= 0 && tst_kvercmp(6, 19, 0) < 0))
 		err_nr = EREMOTE;
 }
 
-- 
2.53.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] ioctl_pidfd06: Update kernel version

[linuxtestproject.agent]

Hi Petr,

On Fri, 24 Apr 2026 12:15:07 +0200, Petr Vorel wrote:
> ioctl_pidfd06: Update kernel version

> -       if (tst_kvercmp(7, 0, 0) >= 0)
> +       if (tst_kvercmp(6, 19, 10) >= 0 ||
> +           (tst_kvercmp(6, 18, 14) >= 0 && tst_kvercmp(6, 19, 0) < 0))
>                 err_nr = EREMOTE;

Reviewed-by: LTP AI Reviewer <ltp-ai@noreply.github.com>

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://github.com/linux-test-project/ltp-agent/actions/runs/24884569804

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2 1/1] ioctl_pidfd06: Update kernel version

[Jan Stancek via ltp]

On Fri, Apr 24, 2026 at 12:15 PM Petr Vorel <pvorel@suse.cz> wrote:
>
> Kernel commit ab89060fbc92e ("pidfs: return -EREMOTE when PIDFD_GET_INFO
> is called on another ns") from v7.0 was backported into stable/LTS
> kernels v6.18.14 (7446125afb6d9) and v6.19.10 (2920abaf56c09).
> Update errnos for these stable/LTS kernels (do not treat older behavior
> as an error).
>
> Follow-up: f630471a6520 ("ioctl_pidfd06: Select expected errno for PIDFD_GET_INFO across pidns")
> Reported-by: Wei Gao <wegao@suse.com>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Alternative approach for Wei's fix:
> https://patchwork.ozlabs.org/project/ltp/patch/20260406023538.14739-1-wegao@suse.com/
> https://lore.kernel.org/ltp/20260406023538.14739-1-wegao@suse.com/
>
> Changes v1->v2:
> * Cover also 6.19.0..v6.19.9
> * Add Follow-up: tag (not Fixme: tag), commit was correct at the time.
>
> Link to v1:
> https://patchwork.ozlabs.org/project/ltp/patch/20260424060543.462475-1-pvorel@suse.cz/
> https://lore.kernel.org/ltp/20260424095900.GA500158@pevik/T/#t
>
>  testcases/kernel/syscalls/ioctl/ioctl_pidfd06.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/testcases/kernel/syscalls/ioctl/ioctl_pidfd06.c b/testcases/kernel/syscalls/ioctl/ioctl_pidfd06.c
> index 0f24d4741f..bc90aafd17 100644
> --- a/testcases/kernel/syscalls/ioctl/ioctl_pidfd06.c
> +++ b/testcases/kernel/syscalls/ioctl/ioctl_pidfd06.c
> @@ -54,7 +54,12 @@ static void setup(void)
>         if (!ioctl_pidfd_info_exit_supported())
>                 tst_brk(TCONF, "PIDFD_INFO_EXIT is not supported by ioctl()");
>
> -       if (tst_kvercmp(7, 0, 0) >= 0)
> +       /*
> +        * ab89060fbc92e ("pidfs: return -EREMOTE when PIDFD_GET_INFO is called on another ns")
> +        * from v7.0, backported to v6.18.14 and v6.19.10.
> +        */
> +       if (tst_kvercmp(6, 19, 10) >= 0 ||
> +           (tst_kvercmp(6, 18, 14) >= 0 && tst_kvercmp(6, 19, 0) < 0))
>                 err_nr = EREMOTE;

lgtm as well,
Acked-by: Jan Stancek <jstancek@redhat.com>

>  }
>
> --
> 2.53.0
>


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2 1/1] ioctl_pidfd06: Update kernel version

[Li Wang]

Petr Vorel wrote:

> Kernel commit ab89060fbc92e ("pidfs: return -EREMOTE when PIDFD_GET_INFO
> is called on another ns") from v7.0 was backported into stable/LTS
> kernels v6.18.14 (7446125afb6d9) and v6.19.10 (2920abaf56c09).
> Update errnos for these stable/LTS kernels (do not treat older behavior
> as an error).
> 
> Follow-up: f630471a6520 ("ioctl_pidfd06: Select expected errno for PIDFD_GET_INFO across pidns")
> Reported-by: Wei Gao <wegao@suse.com>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>

Works for me as well:

Reviewed-by: Li Wang <li.wang@linux.dev>

-- 
Regards,
Li Wang

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH v2 1/1] ioctl_pidfd06: Update kernel version

[Petr Vorel]

Hi all,

thanks for your ack, merged.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

[LTP] [PATCH 1/1] ioctl_pidfd06: Update kernel version

[Petr Vorel]

Kernel commit ab89060fbc92e ("pidfs: return -EREMOTE when PIDFD_GET_INFO
is called on another ns") from v7.0 was backported into stable/LTS
kernels v6.18.14 (7446125afb6d9) and v6.19.10 (2920abaf56c09).

Reported-by: Wei Gao <wegao@suse.com>
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 testcases/kernel/syscalls/ioctl/ioctl_pidfd06.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testcases/kernel/syscalls/ioctl/ioctl_pidfd06.c b/testcases/kernel/syscalls/ioctl/ioctl_pidfd06.c
index 0f24d4741f..cc66d54cf4 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl_pidfd06.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl_pidfd06.c
@@ -54,7 +54,7 @@ static void setup(void)
 	if (!ioctl_pidfd_info_exit_supported())
 		tst_brk(TCONF, "PIDFD_INFO_EXIT is not supported by ioctl()");
 
-	if (tst_kvercmp(7, 0, 0) >= 0)
+	if (tst_kvercmp(6, 18, 14) >= 0)
 		err_nr = EREMOTE;
 }
 
-- 
2.53.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] ioctl_pidfd06: Update kernel version

[linuxtestproject.agent]

Hi Petr,

On 2026-04-24, Petr Vorel wrote:
> ioctl_pidfd06: Update kernel version

> -	if (tst_kvercmp(7, 0, 0) >= 0)
> +	if (tst_kvercmp(6, 18, 14) >= 0)
>  		err_nr = EREMOTE;

tst_kvercmp(6, 18, 14) >= 0 is too broad: because tst_kvercmp compares
(major, minor, patch) as ordered integers, it evaluates true for all
v6.19.x, including v6.19.0-v6.19.9 which do not carry the backport
(which landed in v6.19.10). Those kernels would see a false EREMOTE
expectation and TFAIL.

The check needs to handle both stable branches independently, e.g.:

	if (tst_kvercmp(7, 0, 0) >= 0 ||
	    (tst_kvercmp(6, 18, 14) >= 0 && tst_kvercmp(6, 19, 0) < 0) ||
	    tst_kvercmp(6, 19, 10) >= 0)
		err_nr = EREMOTE;

Also, since this corrects a bug (TFAIL on kernels with the backport),
please add a Fixes: tag referencing the commit that introduced the
original tst_kvercmp(7, 0, 0) check.

---
Note:

Our agent completed the review of the patch. The full review can be
found at: https://github.com/linux-test-project/ltp-agent/actions/runs/24879016987

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] ioctl_pidfd06: Update kernel version

[Petr Vorel]

> Hi Petr,

> On 2026-04-24, Petr Vorel wrote:
> > ioctl_pidfd06: Update kernel version

> > -	if (tst_kvercmp(7, 0, 0) >= 0)
> > +	if (tst_kvercmp(6, 18, 14) >= 0)
> >  		err_nr = EREMOTE;

> tst_kvercmp(6, 18, 14) >= 0 is too broad: because tst_kvercmp compares
> (major, minor, patch) as ordered integers, it evaluates true for all
> v6.19.x, including v6.19.0-v6.19.9 which do not carry the backport
> (which landed in v6.19.10). Those kernels would see a false EREMOTE
> expectation and TFAIL.

> The check needs to handle both stable branches independently, e.g.:

> 	if (tst_kvercmp(7, 0, 0) >= 0 ||
> 	    (tst_kvercmp(6, 18, 14) >= 0 && tst_kvercmp(6, 19, 0) < 0) ||
> 	    tst_kvercmp(6, 19, 10) >= 0)
> 		err_nr = EREMOTE;

Obviously tst_kvercmp(6, 19, 10) >= 0 will match also tst_kvercmp(7, 0, 0) >= 0,
therefore "tst_kvercmp(7, 0, 0) >= 0" is not needed.

Kind regards,
Petr

> Also, since this corrects a bug (TFAIL on kernels with the backport),
> please add a Fixes: tag referencing the commit that introduced the
> original tst_kvercmp(7, 0, 0) check.

Do we want to add Fixes when original commit was correct?

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] ioctl_pidfd06: Update kernel version

[Petr Vorel]

...
> > Also, since this corrects a bug (TFAIL on kernels with the backport),
> > please add a Fixes: tag referencing the commit that introduced the
> > original tst_kvercmp(7, 0, 0) check.

> Do we want to add Fixes when original commit was correct?

Shouldn't be Follow-up: used?

Kind regards,
Petr

> Kind regards,
> Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp